Commit History - (may be incomplete: for full details, see links to repositories near top of page) |
Commit | Credits | Log message |
24.02.0_1 16 Aug 2024 15:32:25 |
Dimitry Andric (dim) |
graphics/poppler: fix build with libc++ 19
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.
This causes graphics/poppler to fail to compile with clang 19 and libc++
19, resulting in errors similar to:
/usr/include/c++/v1/string:820:42: error: implicit instantiation of
undefined template 'std::char_traits<unsigned short>'
820 | static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
| ^
/wrkdirs/usr/ports/graphics/poppler/work/poppler-24.02.0/cpp/poppler-global.h:101:43:
note: in instantiation of template class 'std::basic_string<unsigned short>'
requested here
101 | class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned
short>
| ^ (Only the first 15 lines of the commit message are shown above ) |
24.02.0_1 26 May 2024 10:52:26 |
Daniel Engberg (diizzy) |
*/*: Remove incorrect libtool dependency
All these ports builds without libtool
Tested using Poudriere
Approved by: portmgr (blanket, build fix) |
24.02.0_1 27 Apr 2024 12:44:59 |
Tijl Coosemans (tijl) |
graphics/tiff: Update to 4.6.0
PR: 278577
Exp-run by: antoine |
24.02.0 01 Mar 2024 23:54:25 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 24.02
Release 24.02.0:
core:
* Fix reading some JBIG2 streams. Issue #1319
* Fix saving some annotation interior color when it's empty
* Make searching for fonts when adding annotations a bit faster
* Make sure images are compressed when adding them
* Small internal code cleanup
utils:
* pdfimages: return exit code 2 when error opening output files
Release 24.01.0:
core:
* Don't crash on certain documents on the NSS signature backend
* Fix infinite loop in some annotation code if there's not space for
even one character
* Fix build on Android with generic font configuration
* Small internal code cleanup
PR: 277031
Exp-run by: antoine |
23.12.0 03 Jan 2024 07:18:39 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 23.12
Release 23.12.0:
core:
* Rewrite FoFiType1::parse to be more flexible. Issue #1422
* Small internal code refactoring
Release 23.11.0:
core:
* CairoOutputDev: Use internal downscaling algorithm if image exceeds
Cairo's maximum dimensions.
* Internal code improvements
* Fix crash on malformed files
utils:
* pdftocairo: Add option to document logical structure if output is pdf (Only the first 15 lines of the commit message are shown above ) |
23.05.0_2 28 Jul 2023 17:13:17 |
Daniel Engberg (diizzy) |
*/*: Bump jpeg-turbo users treewide
New major version 3.0.0 |
23.05.0_1 26 Jul 2023 19:58:56 |
Loïc Bartoletti (lbartoletti) |
devel/qt6: bump dependent ports |
23.05.0 14 May 2023 05:57:35 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 23.05
core:
* Fix crash when filling some forms
* Set SigFlags when signing unsigned signature
* Add some infrastructure code to support multiple signing backends
* Fix potential stack overflow in PostScriptFunction::parseCode
* Fix some minor uninitialised memory reads
Exp-run by: antoine
PR: 271223 |
23.04.0 20 Apr 2023 04:05:55 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 23.04.0
core:
* Fix memory issue when signing fails. Issue #1372
* Internal improvements of signature related code
* CairoOutputDev: improve type3 font rendering
* Fix memory leak in GlobalParams::findSystemFontFileForFamilyAndStyle
utils:
* pdftocairo: Fix crash in some special situations
* pdfsig: allow holes in -dump signature list
* pdfsig: Support --help
PR: 270856
Exp-run by: antoine |
23.03.0 11 Mar 2023 10:42:49 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 23.03
core:
* PngWriter: Fix potential uninitialized memory use
PR: 269907
Exp-run by: antoine |
23.02.0 14 Feb 2023 17:46:34 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 23.02
core:
* CairoOutputDev: Fix rendering of color type 3 fonts
* CairoOutputDev: Add handling matte entry
* Fix segfault on wrong nssdir
* Fix "NSS could not shutdown"
utils:
* pdfsig: Point out supports PKCS#11 URIs as nickname
graphics/poppler-data: update to 0.4.12
PR: 269346
Exp-run by: antoine |
23.01.0 09 Jan 2023 08:24:14 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 23.01
Changelog:
core:
* PDFDoc::sign: Fix crash if font can't be found
* PDFDoc::sign: Try Arial to sign if Helvetica isn't found
* FoFiType1::parse: Be more flexible parsing the encoding content. Issue
#1324
* Gfx::opBeginMarkedContent: Support Span with Name. Issue #1327
* Splash: Avoid color issues due to implicit rounding
* Splash: Fix crash on malformed file.
* CairoOutputDev: Ignore text rendering mode for type3 fonts
* Remove unused FoFiType1::load function
build system:
* Increase minimum required versions of several dependencies
* Improve include path handling
qt6:
* Use less deprecated functions
PR: 268721
Exp-run by: antoine |
22.12.0 08 Dec 2022 05:44:34 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.12
The latest stable release is poppler-22.12.0.tar.xz, released on
December 1, 2022:
Release 22.12.0:
core:
* Form::addFontToDefaultResources: Be stubborn in finding a
font we can use. Issue #1272
PR: 268163
Exp-run by: antoine |
22.11.0 08 Nov 2022 05:06:53 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.11
Release 22.11.0:
core:
* CairoOutputDev: Update font after restore
* Protect against broken files
* Small code refactoring
PR: 267496
Exp-run by: antoine |
22.10.0 04 Nov 2022 22:25:29 |
Jan Beich (jbeich) |
graphics/poppler-qt6: install pkg-config support like qt5 |
22.10.0 08 Oct 2022 14:42:48 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.10
Release 22.10.0:
core:
* SplashOutputDev::tilingPatternFill: Properly restore CTM on failure.
Issue #1292
* Protect against malformed files
* Refactor code to not use strndup
* Other small code refactoring
utils:
* pdftoppm: Avoid round-off errors when determining raster dimensions
* pdftocairo: Avoid round-off errors when determining raster dimensions
* pdftotext: Simplify memory handling
qt:
* Take into account flagNoView when getting/setting the visible status.
KDE bug #456313
build system:
* Fix sed invocation
PR: 266812
Exp-run by: antoine |
22.09.0 11 Sep 2022 10:20:14 |
Felix Palmen (zirias) |
Mk/Uses: always use colon for build/run suffix
Most USES use a colon for build/run(/test) suffixes. Change kde.mk,
qt.mk and pyqt.mk to do the same, and update all ports using that.
Document in CHANGES.
PR: 266034
Exp-run by: antoine
Approved by: tcberner (mentor)
Differential Revision: https://reviews.freebsd.org/D36349 |
22.09.0 11 Sep 2022 07:25:44 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.09
Release 22.09.0:
core:
* Splash: Do not truncate line dash patterns with more than 20 entries.
Issue #1281
* Various signature related improvements
* Fix FormField::getFullyQualifiedName in some scenarios
* Splash: Small optimization on dash pattern handling
* JBIG2Stream::readHalftoneRegionSeg: Fix potential memory leak
* Fix crashes on malformed files. Including CVE-2022-38784
* Fix string formatting in error reporting
utils:
* pdfsig: List signature field names when listing signature information
* pdfsig: Add support for specifying signature by field name
* pdfunite: Fix crashes on malformed files
* pdfunite: Fix potential memory leak of docs
glib:
* Fix two potential memory leaks in poppler_document_create_dests_tree
PR: 266151
Exp-run by: antoine |
07 Sep 2022 21:58:51 |
Stefan Eßer (se) |
Remove WWW entries moved into port Makefiles
Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.
This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.
Approved by: portmgr (tcberner) |
22.08.0_1 07 Sep 2022 21:10:59 |
Stefan Eßer (se) |
Add WWW entries to port Makefiles
It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.
Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.
There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.
(Only the first 15 lines of the commit message are shown above ) |
22.08.0_1 23 Aug 2022 06:04:33 |
Tobias C. Berner (tcberner) |
graphics/poppler-qt6: new port - Qt6 wrapper for poppler |
22.08.0_1 12 Aug 2022 14:46:53 |
Dima Panov (fluffy) |
*/*: bump all consumers after recent boost upgrade |
22.08.0 09 Aug 2022 05:48:56 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.08
Release 22.08.0:
core:
* Fix rendering text on some forms
* CairoOutputDev: Support Type3 charprocs having Resources
* Fix crashes on malformed files
Exp-run by: antoine
PR: 265621 |
22.07.0 20 Jul 2022 14:22:04 |
Tobias C. Berner (tcberner) |
graphics: remove 'Created by' lines
A big Thank You to the original contributors of these ports:
* "Waitman Gobble" <uzimac@da3m0n8t3r.com>
* Aaron Dalton <aaron@FreeBSD.org>
* Abel Chow <ozsanh45vds001@sneakemail.com>
* Adam Weinberger <adamw@FreeBSD.org>
* Ade Lovett <ade@FreeBSD.org>
* Ade Lovett <ade@lovett.com>
* Akinori MUSHA aka knu <knu@idaemons.org>
* Aldis Berjoza <aldis@bsdroot.lv>
* Alex Hayward <xelah@xelah.com>
* Alex Ivasyuv <siegerstein@pochta.ru>
* Alex Samorukov <samm@os2.kiev.ua> (Only the first 15 lines of the commit message are shown above ) |
22.07.0 06 Jul 2022 20:00:10 |
Tobias C. Berner (tcberner) |
graphics/poppler-glib: remove accidental patch
Pointy hat: tcberner |
22.07.0 06 Jul 2022 19:54:46 |
Tobias C. Berner (tcberner) |
graphics/poppler: fix poppler-glib
- last minute typo
Reported by: Barbara <barbara.freebsd@gmail.com> |
22.07.0 06 Jul 2022 18:23:47 |
Tobias C. Berner (tcberner) |
graphics/poppler: fix build in unclean environment
poppler will run gperf, when it is present which may be the
case in an unclean environment.
To make this consistent, always pull in gperf, and use gsed to
work around sed/gsed differences.
Reported by: VVD <vvd@unislabs.com> |
22.07.0 06 Jul 2022 16:23:45 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.07
Changelog:
Release 22.07.0:
core:
* Fix crash when filling in forms in some files. Issue #1258
* Fix first lines of Annotations sometimes being cut off. Issue #1246
* Signatures: Don't crash if the signature doesn't have a common name
* CairoFontEngine: increment font_face reference when retrieving from
the cache
* Add ToUnicode support for lessorequalslant and greaterorequalslant
glib:
* Add support for stamp annotation
build system:
* Tweaks on how gperf is run
PR: 265042
Exp-run by: antoine |
22.06.0 05 Jun 2022 14:03:46 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.06
Release 22.06.0:
core:
* Forms: Fix crash in forms with their own DR
* Refactor CairoFontEngine caching
* CairoOutputDev: preserve text color when drawing type 3 glyphs
* Windows: font code simplification
* Minor code improvements
utils:
* pdfattach: Assume filename is utf8 encoded
* pdftohtml: Fix type 3 font size calculation
cpp:
* Add missing header
Exp-run by: antoine
PR: 264419 |
22.05.0 09 May 2022 16:47:40 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.05
Release 22.05.0:
core:
* Annotations: Make sure we embed fonts for the FreeText annots
* Forms: Make sure we embedd fonts as needed
* Signatures: Make sure we embed the needed fonts
* CairoOutputDev: color type 3 fonts
* fix two bugs in multiline find_text()
* code improvements
utils:
* pdftotext: added TSV mode
* HtmlOutputDev: don't use png.h
cpp:
* Use time_t for time
* Add page_transition::durationReal
qt:
* Pass leftFontSize down to
`FormWidgetSignature::signDocumentWithAppearence`
Exp-run by: antoine
PR: 263769 |
22.04.0 26 Apr 2022 16:57:01 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 22.04
Release 22.04.0:
core:
* Fix underline sometimes being drawn only partially
* Fix Adobe Reader not reading some of the contents we write correctly
* Fix code that workarounds some broken-ish files
* FoFiTrueType: Parse CFF2 fonts too
* FoFiTrueType: Support cmap types 2 and 13
* Fix a few small memory leaks
* code improvements
qt:
* Handle SaveAs named action
* Annotations: don't change the text color when changing the font (Only the first 15 lines of the commit message are shown above ) |
22.01.0_1 10 Apr 2022 19:11:41 |
Charlie Li (vishwin) |
textproc/libxml2: bump all LIB_DEPENDS consumers
This is a separate commit to facilitate easier cherry-picking for
quarterly.
PR: 262853, 262940, 262877, 263126
Approved by: fluffy (mentor) |
22.01.0 01 Apr 2022 14:19:30 |
Tobias C. Berner (tcberner) |
graphics/poppler: ignore graphics/openjpeg15 presence
- cmake can under some non-determinstic circumstances find
the OpenJPEGConfig.cmake in
${PREFIX}/lib/openjpeg-1.5
prior to the one in
${PREFIX}/lib/openjpeg2
with would be the wanted one.
- Use CMAKE_IGNORE_PATH to explicitely make it not see
that prefix.
https://cmake.org/cmake/help/latest/variable/CMAKE_IGNORE_PATH.html#variable:CMAKE_IGNORE_PATH
PR: 262888 |
22.01.0 29 Mar 2022 12:44:53 |
Adriaan de Groot (adridg) |
graphics/poppler: update to 22.01, latest release
This release *requires* consumers to use C++17, which makes it one
of the more intrusive poppler releases in recent memory. Consumers
have already been bumped or marked BROKEN if they now require some
impossible combination of libraries. |
21.12.0_1 26 Mar 2022 08:27:27 |
Matthias Fechner (mfechner) |
textproc/libxml2: bump all dependencies
This should make sure that all dependent ports will pick
up the new version commited with a13ec21cd733f67a9fc0dc00ab45268bdc236246 |
21.12.0 13 Dec 2021 20:13:45 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.12
Release 21.12.0:
core:
* Add API to add images
* CairoOutputDev: Fix de-duping of Flate images
* Fix crash on broken files when using non-default
ENABLE_ZLIB_UNCOMPRESS. Issue #393
* Minor code improvements
glib:
* Add API for validation of signatures
* Add API to read/save to file descriptor
utils:
* pdftohtml: Reduce sensitivity of duplicate detection. Issue #1117
build system:
* Increase C++ standard to 17
Exp-run by: antoine
PR: 260344 |
21.11.0 08 Nov 2021 15:16:56 |
Gleb Popov (arrowd) |
graphics/poppler: Update to 21.11.0
Release 21.11.0:
core:
* Fix rendering of some non-standard confirming annotations
* Support rendering of some non-standard Type3 charprocs. Issue #1150
* TextOutputDev: Respect orientation when selecting words. Issue #499
* CairoOutputDev: Don't override the antialias settings from the
cairo_t
* StructElement: support MCID in XObjects
* Fix detection of monospace fonts
* Ignore Adobe-Identity for non embedded CID fonts
* PageLabelInfo::labelToIndex: work on some special no style intervals
* Fix crash in malformed files
* Minor code improvements
utils:
* pdfinfo: add -url option to print all URLs in a PDF
* pdftohtml: document what zoom means in regard to DPI
Exp-run by: antoine
PR: 259656 |
21.10.0 12 Oct 2021 18:19:40 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.10.0
Release 21.10.0:
core:
* Add support for setting custom stamp annotations
* Add default appearance for the well known stamp names
* Correct encoding of signature's properties Reason & Location
* Splash: Fix rendering of some odd patterns
* SignatureHandler::validateCertificate: Add option to not do OCSP
revocation check
* SignatureHandler::validateCertificate: Add support for AIA fetching
to verify certificates
* greallocn: if memory allocation fails, free the previous pointer to
avoid memory leak
* Fix issues with malformed files
* Internal code improvements
utils: (Only the first 15 lines of the commit message are shown above ) |
21.09.0 06 Sep 2021 16:31:18 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.09
Release 21.09.0:
core:
* Splash: Massive speed improvement on files that use lots of
save/restore (q/Q) operators
* Correct decoding of signature properties Reason & Location when they
are Unicode
* Fix issues with malformed files
* MSVC build fixes
build system:
* Call cmake_minium_required() before project()
* Always append to CMAKE_{C,CXX}_FLAGS_${CMAKE_BUILD_TYPE}
* correctly forward user-provided flags to try_compile()
Exp-run by: antoine
PR: 258206 |
21.08.0 15 Aug 2021 05:42:37 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.08.0
Release 21.08.0:
core:
* Add API to allow addition and modification of outlines into a PDF
* Use additional samples to test for constant parts of an axial
gradient
* forms: Create fallback fonts for some well known font names
* Support reading the PDF Version from the Catalog
* Fix XRef::copy when there are modified objects
* Take into account that Date string may be in unicode
* JBIG2Stream: Fix regression in "Do not consider a size-0 to be an
error"
* Replace a local bubble sort implementation by std::sort
* Fix issues with malformed files
build system: (Only the first 15 lines of the commit message are shown above ) |
21.07.0 06 Jul 2021 20:00:58 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.07.0
Release 21.07.0:
core:
* JBIG2Stream: Do not consider a size-0 to be an error. Issue #535
* PSOutputDev: fix off-by-one error for image masking in L1/L2 output.
Issue #1088
* CairoOutputDev: Fix memory leak on broken files
* Minor code improvements
build system:
* set C standard to 11 without extensions
Exp-run by: antoine
PR: 256981 |
21.06.1_1 05 Jul 2021 12:23:28 |
Adriaan de Groot (adridg) |
graphics/poppler: make boost a build-time dependency
Poppler uses Boost small-vectors for efficiency (over std::vector)
when the Splash renderer is enabled. Small-vectors are header-only,
so there is no need to depend on the whole boost-libs at runtime.
The PR asks to drop Boost entirely; we're not going to do that,
but as a build-dep it avoids installed-size bloat.
Bump PORTREVISION also of related ports to make sure they are
rebuilt; don't need to re-do all consumers because Boost was not
linked anyway.
PR: 256821 |
21.06.1 16 Jun 2021 19:35:04 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.06.1
Release 21.06.1:
glib:
* fix poppler_rectangle_free() regression. Issue #1087 |
21.06.0 07 Jun 2021 13:26:18 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.06.0
Release 21.06.0:
core:
* Fix rendering of some extended latin1 characters in annotations.
Issue #1070
* Support some not so well formed documents with password. Issue #1083
* Add API to get notified if the xref is reconstructed
* Add somewhat fancier left/right signature visual representation
* Fix crashes in malformed files
* Minor code improvements
qt6:
* Change some functions to return std::unique_ptr
qt5/qt6: (Only the first 15 lines of the commit message are shown above ) |
21.05.0 06 May 2021 04:12:26 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.05.0
Release 21.05.0:
core:
* Fix crashes in malformed files
* Export SplashFont* symbols used by Scribus
* Minor code improvements
qt5/qt6:
* Make sure new signatures are always properly oriented
* Allow to pass the border width when signing
glib:
* Enhance find to support multi-line matching
utils:
* pdftoppm: Fix regression when using single scaleTo. Issue #1062
build system:
* Allow to disable building manual tests
PR: 255562
Exp-run by: antoine |
21.04.0 16 Apr 2021 04:29:51 |
Tobias C. Berner (tcberner) |
graphics/poppler: update to 21.04.0
Release 21.04.0:
core:
* Hide symbols by default
* TextSelectionDumper: fix word order for RTL text
* Fix rendering of text in some files. Issue #1052
* Implement rendering of Masks of Image subtype. Issue #1058
* Forms: fix unclicking standalone form buttons. Issue #1034
glib:
* Expose more fields from MediaRendition in PopplerMedia
* Use stock glib macro to define boxed type
* Remove incorrecly used volatile from enum type registration code
(Only the first 15 lines of the commit message are shown above ) |
21.03.0 06 Apr 2021 14:31:07 |
Mathieu Arnold (mat) |
Remove # $FreeBSD$ from Makefiles. |
21.03.0 08 Mar 2021 19:32:56 |
tcberner |
graphics/poppler: update to 21.03.0
Release 21.03.0:
core:
* Fix parsing text in some broken pdf files. Issue #1040
* Fix memory issue when using threads. Issue #1050
* TextSelectionDumper: Fix getText() for space after word
* Change signature of OutputDev:tilingPatternFill
* Make PDFDocBuilder return a std::unique_ptr
* Improve well formed check for shading functions
* Fix leak in case of fread failing
* Fix memory leak in broken file in JBIG2Stream::readGenericBitmap
* PSOutputDev: Fix stack overflow in broken files
glib: (Only the first 15 lines of the commit message are shown above ) |
21.02.0 09 Feb 2021 11:10:58 |
tcberner |
graphics/poppler: update to 21.02
Release 21.02.0:
core:
* GfxCal*ColorSpace: introduce Bradford transform for chromatic
adaptation
* Fix memory leak if saving the file fails
* Internal code improvements
* Fix various issues handling broken files
* Make checkedAdd work for long long in MSVC
qt5:
* Properly export NewSignatureData class
* Fix regression in QIODeviceOutStream + MSVC
qt6:
* Properly export NewSignatureData class
* Fix regression in QIODeviceOutStream + MSVC
utils:
* pdftohtml: Fix error() parameter type
PR: 253183
Exp-run by: antoine |
21.01.0 07 Jan 2021 19:23:00 |
tcberner |
graphics/poppler: update to 21.01.0
Release 21.01.0:
core:
* Faster routines for jpeg decoding
* Fix reading signatures in encrypted files
* Add white point correction when lcms is used
* JBIG2Stream: Fix byte counting
* Fix potential data loss if we try to fetch a non existing Ref after
modifying the document
* Specifically use DeviceGray instead of DefaultGray for softmasks
* Fix various issues handling broken files
utils:
* pdftocairo: Setmode binary for windows
* pdfsig: Add hability to digitally sign files (Only the first 15 lines of the commit message are shown above ) |
20.12.1 11 Dec 2020 21:04:38 |
tcberner |
graphics/poppler: update to 20.12.1 (regression fix)
Release 20.12.1:
core:
* PSOutputDev: fixing regression in the rasterization code. Issue #1002
* Add missing profile copy operation in GfxICCBasedColorSpace::copy()
* Fix issue in broken files
build system:
* Use modern CMake linking for Qt and boost
PR: 251537 |
20.12.0 11 Dec 2020 20:10:03 |
tcberner |
graphics/poppler: update to 20.12.0
Changelog:
core:
* Draw better circles for circle annotations
* Fix annotation line width if no appearance stream or style are given
* Tweak rendering of highlight annotations
* Fix border rendering of some annotations
* Fix rendering of some files. Issue #976 Issue #567
* PSOutputDev: provide options to set the rasterization color space and
ICC profile
* PSOutputDev: for splashModeCMYK8 and language level >=2 activate
overprint emulation
* PSOutputDev: use the DeviceN8 bitmap for rasterization with
CMYK-output + overprint
* Use the font name without subset tag when querying for a system font
* Splash: Fix wrong x adjustment during clipping
* Splash: Fix blitImage in uncolored tiling patterns (Only the first 15 lines of the commit message are shown above ) |
20.11.0 03 Nov 2020 19:48:54 |
tcberner |
graphics/poppler: update to 20.11.0
Release 20.11.0:
core:
* More work on rendering of standalone Annot Widgets. Issue #806
* Fix crashes in embedded file handling on broken files. Issue #967
* Fix uninitialized memory read on broken files
* Save a bit of memory in Dict data
cpp:
* Fix crashes in embedded file handling on broken files. Issue #966
utils:
* pdftohtml: HTML and XML output includes font opacity.
(Only the first 15 lines of the commit message are shown above ) |
20.10.0 11 Oct 2020 10:58:15 |
tcberner |
graphics/poppler: update to 20.10.0
Release 20.10.0:
core:
* Filter out repeated forms
* Implement EmbedStream::reset()
* CairoOutputDev: evict just font faces owned solely by cache.
* Splash: Rename Yd to Ydown, Xu to Xup, etc.
* Splash: fix crash in out-of-memory situation.
* Fix some undefined behaviour situation with forged files
PR: 250052
Exp-run by: antoine |
20.09.0 10 Sep 2020 18:32:07 |
tcberner |
graphics/poppler: update to 20.09.0
Release 20.09.0:
core:
* Compability fix for Forms
* Fix fetching of Objects failing in some cases
* Fix clearing date in Annot setModified/setDate
* TextSelectionPainter: support glyphless fonts
* Splash: Don't try read past end of image
* avoid abort() on large memory allocation
* Fix memory leak on broken files
* Fix potential invalid memory read
* Small code improvements
qt5: (Only the first 15 lines of the commit message are shown above ) |
20.08.0_1 14 Aug 2020 04:22:13 |
tcberner |
Bump revisions of poppler consumers after r544863 |
20.08.0 14 Aug 2020 04:02:20 |
tcberner |
graphics/poppler: update to 20.08.0
Release 20.08.0:
core:
* Sub-page objects: initialize clip max values considering the render
resolution. Issue #937
* Splash: Set initial line width to 1. Issue #674
* Fix stack overflow with specially crafted files
* GfxShading: Simplify holding the Function
* Splash: Fix x86 + windows asm build
qt5:
* Deprecate Document::toc
* Deprecate AnnotationUtils
PR: 248419
Exp-run by: antoine |
0.90.1 17 Jul 2020 14:42:19 |
tcberner |
graphics/poppler: update to 0.90.1
Release 0.90.1:
core:
* Fix regression on PS conversion.
Regression only happened on applications that are locale enabled
i.e. Okular but not pdftops, when using a quite new lcms and
the user locale uses , as decimal separator instead of .
* Add UTF16LE support to TextStringToUCS4.
Even if the standard clearly says it should be UTF16BE
PR: 247925
Exp-run by: antoine |
0.90.0_1 06 Jul 2020 06:17:19 |
tcberner |
graphics/poppler: update to 0.90
Release 0.90.0:
core:
* Color profile tweaks
* Small signature improvements
* BBoxOutputDev: Fix calculation when type3 fonts are involved
* Fix potential crash when reading Forms
* Fix infinite loop in broken file
glib:
* Fix adding annots in rotated pages
* Add ability to reset forms
* Several fixes to the documentation
qt5:
* Make it clear we require Qt 5.5 (Only the first 15 lines of the commit message are shown above ) |
0.89.0_1 02 Jun 2020 14:47:30 |
tcberner |
graphics/poppler: update to 0.89.0
Release 0.89.0:
core:
* Add support for ResetForm action. Issue #225
* Fix crash in PDFDoc::getSignatureFields when there's no Forms at all
* Fix exporting to PS of some files with CID fonts
* Use ICC profiles in PS output (if new enough lcms is used)
* Allow almost-singular tiling pattern matrices. Issue #894
* Fix memory leak when failing to load some fonts
* CairoOutputDev: Use stroke opacity when clipping to a stroke path
* CairoOutputDev: Fix tiling patterns when pattern cell is too far.
Issue #190
glib:
* Add poppler_movie_get_aspect
cpp:
* Add the font infos to the text_box object
Exp-run by: antoine
PR: 246848 |
0.88.0 02 May 2020 10:00:12 |
tcberner |
graphics/poppler: update to 0.88.0
Release 0.88.0:
core:
* Support Widget Annotation Buttons not linked to any Form
* SplashOuputDev: Use stroking opacity when clipping to a stroke path
* Handle 1 bit RGB images in ICC colorspace
* Internal code improvements
qt5:
* Add Document::signatures. Returns signatures not attached to any page
* ArthurOutputDev: Fix font hinting
* ArthurOutputDev: Set the opacity when filling with axial gradients
* ArthurOutputDev: Implement the clipToStrokePath method (Only the first 15 lines of the commit message are shown above ) |
0.87.0 02 Apr 2020 04:41:03 |
tcberner |
graphics/poppler: update to 0.87.0
Release 0.87.0:
core:
* Fix crashes due to inconsistent vtables for Clang builds
* Fix leak in broken files
* Internal code improvements
qt5:
* Add option to get form choice for export value
* ArthurOutputDev: Avoid division by zero in updateLineDash. Issue #695
glib:
* Internal code improvements
utils:
* pdftohtml: Fix memory leak in HtmlOutputDev::getLinkDest
PR: 245150
Exp-run by: antoine |
0.86.1_1 28 Mar 2020 15:57:26 |
ashish |
- Add patches from upstream to fix segmentation fault with PDF files
which include links
PR: 245093
Approved by: tcberner (from desktop@) |
0.86.1 21 Mar 2020 12:57:09 |
tcberner |
Update poppler to 0.86.1
Release 0.86.1:
core:
* Fix regression in Browse Link handling
* Internal code improvements
Release 0.86.0:
core:
* Fix link content exfiltration attack
* Splash: Implement gouraudTriangleShadedFill for some non parametrized
shadings. Issue #881
* Fix case unsensitive search for Old Hungarian, Warang Citi,
Medefaidrin and Adlam
* Internal code improvements
glib: (Only the first 15 lines of the commit message are shown above ) |
0.85.0 03 Feb 2020 19:28:40 |
tcberner |
graphics/poppler: update to 0.85.0
Release 0.85.0:
core:
* Fix case unsensitive search for Deseret and Osage. Issue #853
* Fix crash in unicodeToAscii7
* CairoOutputDev: make initialisation thread-safe
* Fix crash on broken files. Issues #869, #870
* Internal code improvements
qt5:
* Fix FormField::name encoding
* Accept UTF-16 uiNames for form fields
* Fix search for "complex" characters
* Allow to load document from QIODevice
utils:
* pdftoppm/pdftocairo: Fix -e/-o printing the wrong pages. Issue #873
* pdftohtml: Fix issue with the font size sometimes being huge
glib:
* make the frontend initialization thread safe.
PR: 243756
Exp-run by: antoine |
0.84.0 25 Jan 2020 20:27:10 |
tcberner |
graphics/poppler-glib: disable gkt-test/demo builds
In unclean build environments GTK could get picked up and lead to linker errrors
in demo applications which are not installed, but still manage to make the build
fail.
Remove the temporary work around added in r523840 which passed
-L${LOCALBASE}/lib
to the linker.
PR: 243525
Reported by: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>, O. Hartmann
<ohartmann@walstatt.org> |
0.84.0 22 Jan 2020 20:16:46 |
tcberner |
graphics/poppler-glib: fix build outside of poudriere
When simply running make in graphics/poppler-glib -L${LOCALBASE}
seems to be missing under some circumstances in the linker flags.
As a work-around, switch to USES=localbase:ldflags until fixed
properly.
Reported by: Walter Schwarzenfeld <w.schwarzenfeld@utanet.at> |
0.84.0 22 Jan 2020 17:59:22 |
tcberner |
graphics/poppler: update to 0.84.0
Release 0.84.0:
core:
* Fix crash when converting from Unicode to ASCII-7
* Splash::scaleImageYdXu: Protect against crash if srcWidth is too big
* JBIG2Stream: fix potential crash in malformed documents
* JBIG2Stream: fix leak in reset() if called several times
* Internal code improvements
utils:
* pdfimages: Add error message if first page is larger then number of
pages.
* pdfinfo: Improved paper size recognition
* pdfsig: Fix exit code when dumping signatures
* pdftocairo: Error out when even/odd selects 0 pages (Only the first 15 lines of the commit message are shown above ) |
0.82.0_1 15 Nov 2019 20:10:21 |
tcberner |
Create desktop@ as maintainer of some shared desktop ports
This idea has been around for quite some time. Time to make it happen.
In order to share the load on the ports required by multiple desktop
environments start to share the responsibility of maintainership.
This is the initial list that came to mind, but we can probably extend it, to
include another handful of ports.
WWW: https://wiki.freebsd.org/DesktopTeam
Mailing List: https://lists.freebsd.org/mailman/listinfo/freebsd-desktop
Approved by: swills, kwm (gnome), madpilot (xfce)
Differential Revision: https://reviews.freebsd.org/D22389 |
0.82.0_1 01 Nov 2019 21:51:36 |
tcberner |
graphics/poppler: update to 0.82.0
Release 0.82.0:
core:
* Fix not being able to open some files. Issue #832
* Fix crashes in malformed files
* Fix memory leak on broken files
* Minor performance improvements
* Minor code improvements
glib:
* Add poppler_document_new_from_bytes
* PopplerAttachment: Silence deprecation warnings for ctime/mtime
build system:
* pdf-inspector: Support builddir != srcdir
* Install Cairo* headers if Cairo has been found
Thanks to adridg@ for fixing all the fallout.
Exp-run by: antoine
PR: 241532
Approved by: gnome (kwm, implicit) |
0.81.0_1 29 Sep 2019 07:25:04 |
tcberner |
graphics/poppler: update to 0.81.0
Release 0.81.0:
core:
* Splash: Always enable support for CMYK rasterization
* CairoOutputDev: Check scaled dimensions for 0. Issue #737
* BaseCryptStream: Fix potential uninitialized memory read
* SplashBitmap: Fix wrong width condition for splashModeDeviceN8
* Fix crashes in malformed files
PR: 240781
Exp-run by: antoine
Approved by: gnome (kwm, implicit) |
0.80.0_1 01 Sep 2019 20:46:39 |
tcberner |
graphics/poppler: update to 0.80.0
Release 0.80.0:
core:
* Annotations: Implement support for setting a different text in the appearance
stream than the real text
* Splash: Optionally use small_vector from boost
* Fix memory leaks on broken files
* Fix abort on broken files
* Small code simplifications
* Remove USE_FIXEDPOINT support. Issue #821
qt5:
* Fix MSVC build
* Add subsitute-font information
* Fix since marker of some functions (Only the first 15 lines of the commit message are shown above ) |
0.79.0 31 Jul 2019 21:14:15 |
tcberner |
graphics/poppler: update to 0.79.0
Release 0.79.0:
core:
* Fix regression on TextSelectionPainter
* Fix parsing of DefaultAppearance
* Fix memory leak in PostScriptFunction
* Fix crashes in fuzzed files
qt5:
* Implemented support for setIcon by changing appearance
* Added option to set the form available to print
* QString::null is deprecated, use QString()
* Replace deprecated qStableSort with std::stable_sort
build system:
* Turn README into README.md and expand it
PR: 239277
Exp-run by: antoine
Approved by: gnome (kwm, implicit) |
0.78.0_2 26 Jul 2019 20:46:57 |
gerald |
Bump PORTREVISION for ports depending on the canonical version of GCC
as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3
to GCC 9.1 under most circumstances now after revision 507371.
This includes ports
- with USE_GCC=yes or USE_GCC=any,
- with USES=fortran,
- using Mk/bsd.octave.mk which in turn features USES=fortran, and
- with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.
PR: 238330 |
0.78.0_1 11 Jul 2019 04:11:32 |
tcberner |
graphics/poppler: add upstream bugfix
Approved by: gnome (kwm, implicit) |
0.78.0 29 Jun 2019 08:55:18 |
tcberner |
graphics/poppler: update to 0.78.0
Release 0.78.0:
core:
* Fix line annotation arrows for usage in dimensioning
* Handle Ink annots without an InkList but with an AP
* Fix typos preventing parsing of Movie start and duration
* Fix crash on malformed files
glib:
* Add poppler_document_create_dests_tree()
* Don't use the deprecated g_type_class_add_private()
* Document the differences between render() and render_for_printing()
* Fix introspection for poppler_document_new_from_data
* Don't create PopplerInputStream with length 0. Issue #414 (Only the first 15 lines of the commit message are shown above ) |
0.77.0 01 Jun 2019 06:39:23 |
tcberner |
graphics/poppler: update to 0.77.0
Release 0.77.0:
core:
* Fix crash on signature handling. Issue #766
* Fix small memory leak in SignatureHandler::getCertificateInfo
* Splash: Restrict filling of overlapping boxes. Issue #750
* Fix crash on malformed files
qt5:
* Fix optional content handling with exclusive layers
cpp:
* Make render_page thread-safe
utils:
* pdfsig: Fix small memory leak
* pdftotext: Fix typo in manpage
PR: 238115
Exp-run by: antoine
Approved by: gnome (kwm, implicit) |
0.76.1 13 May 2019 18:33:10 |
tcberner |
graphics/poppler: update to 0.76.1
From Changelog at https://poppler.freedesktop.org/releases.html :
Release 0.76.1:
core:
* Make the mul tables be calculated at compile time with constexpr.
* splash: Fix compile with SPLASH_CMYK enabled
* Some typo fixing in error messages
qt5:
* Fix regression in annotation handling
build system:
* Fix some typos in build system output and comments (Only the first 15 lines of the commit message are shown above ) |
0.75.0 15 Apr 2019 21:15:59 |
sunpoet |
Update MASTER_SITES
Approved by: portmgr (blanket) |
0.75.0 27 Mar 2019 21:29:31 |
tcberner |
graphics/poppler: update to 0.75
Release 0.75.0:
core:
* Fix rendering of some annotations
* Fix crashes in broken files
* Small internal code improvements
cpp:
* Improve documentation
* tests: Add showing version information to poppler-dump
utils:
* pdfattach: new util
* pdftohtml: add -dataurls parameter
* pdftoppm: add -sep and -forcenum parameters
* pdftohtml: make singleHtml and stout not mutually exclusive
* pdfsig: fix use after free
- bump revisions of dependent ports due to shlib version change
PR: 236791
Exp-run by: antoine
Approved by: kwm (gnome) |
0.74.0 11 Feb 2019 17:10:05 |
tcberner |
Update graphics/poppler* to 0.74.0
Changelog can be found here:
https://poppler.freedesktop.org/releases.html
PR: 235609
Exp-run by: antoine
Approved by: gnome (kde)
Differential Revision: https://reviews.freebsd.org/D18805 |
0.72.0 25 Dec 2018 20:25:40 |
tcberner |
Change cmake default behaviour to outsource.
Ports that build out of source now simply can use "USES=cmake"
instead of "USES=cmake:outsource". Ports that fail to build
out of source now need to specify "USES=cmake:insource".
I tried to only set insource where explictely needed.
PR: 232038
Exp-run by: antoine |
0.72.0 17 Dec 2018 06:06:24 |
tcberner |
graphics/poppler: remove DEPRECATED
- the Qt4 slave port was deprecated.
PR: 234083
Submitted by: <m.ne@gmx.net> |
0.72.0 16 Dec 2018 15:10:42 |
tcberner |
Update poppler to 0.72
This update brings many changes
- the build system has switched to cmake
- some ports needed to be switched to use their bundled
version of poppler:
- print/tex-luatex (r487226)
- print/tex-xetex (r487226)
- editors/opeonffice-devel
- Qt4 support has been dropped
- print/frescobaldi has been removed for this reason.
- most of the added patches can be removed with the next
upgrade of the concerning port.
PR: 233452
Exp-run by: antoine
Approved by: gnome (kwm)
Differential Revision: https://reviews.freebsd.org/D17456 |
0.57.0_2 12 Dec 2018 01:35:36 |
gerald |
Bump PORTREVISION for ports depending on the canonical version of GCC
defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t
GCC 8.2 under most circumstances.
This includes ports
- with USE_GCC=yes or USE_GCC=any,
- with USES=fortran,
- using Mk/bsd.octave.mk which in turn features USES=fortran, and
- with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.
PR: 231590 |
0.57.0_1 02 Dec 2018 15:41:48 |
rene |
Mark QT4 ports/functionality for removal on 2019-03-15
While here, chase some KDE4 ports and functionality, these are scheduled for
removal on 2018-12-31. Change the default option/flavor to QT5 where applicable
or use alternative toolkits like GTK.
Submitted by: tcberner
Reviewed by: adridg, jhale, rene, tcberner
Approved by: portmgr (implicit, flavor hook)
Differential Revision: https://reviews.freebsd.org/D17741 |
0.57.0_1 18 Sep 2018 09:28:35 |
linimon |
Upgrade these ports to USES=compiler:c++11-lang to fix build on gcc-based
archs such as powerpc64.
Tested for no effect on amd64.
While here, pet portlint.
Approved by: portgmr (tier-2 blanket) |
0.57.0_1 08 Aug 2018 09:37:59 |
amdmi3 |
- Update WWW
Approved by: portmgr blanket |
0.57.0_1 28 Jun 2018 17:39:55 |
tcberner |
Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk
From now on, ports that depend on Qt4 will have to set
USES= qt:4
USE_QT= foo bar
ports depending on Qt5 will use
USES= qt:5
USE_QT= foo bar
PR: 229225
Exp-run by: antoine
Reviewed by: mat
Approved by: portmgr (antoine)
Differential Revision: -https://reviews.freebsd.org/D15540 |
0.57.0_1 10 Apr 2018 18:46:48 |
madpilot |
Fix graphics/poppler-qt5 provided include file, causing dependent
ports to fail when including it.
PR: 221805
Submitted by: me
Approved by: gnome (kwm) |
0.57.0 31 Aug 2017 09:14:41 |
kwm |
Correct the OPENJPEG disable configure flag
PR: 221796
Reported by: jakub_lach@mailplus.pl |
0.57.0 24 Aug 2017 01:02:59 |
swills |
graphics/poppler: update to 0.57.0
PR: 220608
Reported by: Andrew Marks <amracks@gmail.com>
Approved by: gnome@ (kwm)
MFH: 2017Q3
Security: eca2d861-76f4-42ed-89d2-23a2cb396c87 |
0.50.0 18 Feb 2017 19:48:05 |
tcberner |
Update Qt5 to 5.7.1, and unify the Qt4 and Qt5 ports some more
* Update Qt5 to 5.7.1
* Move Qt4 binaries to lib/qt4/bin
* Move Qt5 libraries to lib/qt5/lib
By moving the libraries we should finally be able to get rid of the inplace
upgrade bug (see ports bugs 194088, 195105 and 198720): when Qt5's libraries
were lying in /usr/local/lib, which would often get added by pkgconfig to the
linker paths via dependencies, the already installed libraries were linked
against, instead of the ones that were being built. This forced us to make
sure, that -L${WRKSRC}/lib was always coming before -L/usr/local/lib in the
linker flags. With this change this should no longer be the case.
* Rename some ports to match the rest (foo-qtX -> qtX-foo)
* Depend on new port misc/qtchooser [see UPDATING & CHANGES]
There are several new Qt5 ports which all have been created by Marie Loise
Nolden
<nolden@kde.org>. Thanks again.
PR: 216797
Exp-Run by: antoine
Reviewed by: rakuco, mat, groot_kde.org
Approved by: rakuco (mentor)
Differential Revision: https://reviews.freebsd.org/D9213 |
0.50.0 07 Jan 2017 10:35:33 |
olivierd |
- Update to 0.50.0
- Remove unneeded patch
- Enable NSS (Network Security Service)
- Switch to OpenJPEG2
PR: 215358
Submitted by: myself (olivierd@)
Exp-run by: antoine@
Approved by: GNOME team (timeout 3 weeks) |
0.46.0_2 09 Oct 2016 22:42:55 |
jbeich |
graphics/poppler: ignore installed NSS for now
$ make install -C security/nss
$ DEVELOPER=1 make -C graphics/poppler
[...]
====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/nss/libnss3.so from security/nss but it is not declared as a
dependency
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/nss/libsmime3.so from security/nss but it is not declared as a
dependency
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/nss/libssl3.so from security/nss but it is not declared as a
dependency
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/nss/libnssutil3.so from security/nss but it is not declared as a
dependency
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/libplds4.so from devel/nspr but it is not declared as a
dependency
Warning: you need LIB_DEPENDS+=libplds4.so:devel/nspr
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/libplc4.so from devel/nspr but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libplc4.so:devel/nspr
Error: /usr/local/lib/libpoppler.so.63.0.0 is linked to
/usr/local/lib/libnspr4.so from devel/nspr but it is not declared as a
dependency
Warning: you need LIB_DEPENDS+=libnspr4.so:devel/nspr
Reported by: Walter Schwarzenfeld (via r423591 regression)
Approved by: portmgr blanket |
0.46.0_1 30 Sep 2016 19:24:30 |
tijl |
Let USES=localbase add -L${LOCALBASE}/lib to LIBS instead of LDFLAGS.
USES=localbase:ldflags can be used to set LDFLAGS. Normally LDFLAGS
appears too early on the command line causing some ports to link with
their own libraries in LOCALBASE (if installed) instead of WRKSRC.
Also make use of _USES_POST so -L${LOCALBASE}/lib is added as late as
possible after anything a port Makefile might set. Use _USES_POST
instead of .include in libedit.mk and libarchive.mk so things like
'USES=libedit localbase:ldflags' work correctly.
Fix some issues with LIBS in some ports.
Switch ports that don't support LIBS to localbase:ldflags.
PR: 212987
Exp-run by: antoine
Approved by: portmgr (antoine) |
0.46.0_1 23 Sep 2016 08:17:04 |
olivierd |
- Add patch, which fixes crashes of viewers based on Poppler
- Bump PORTREVISION
PR: 212867
Reported by: Bengt Ahlgren
Obtained from: Upstream repository |
0.46.0 05 Sep 2016 19:19:35 |
olivierd |
- Update to 0.46.0
- Replace CPPFLAGS and LDFLAGS by USES= localbase
PR: 211388
Submitted by: myself
Approved by: The GNOME team (timeout)
Exp-run by: antoine@ |
0.40.0 01 Apr 2016 14:00:57 |
mat |
Remove ${PORTSDIR}/ from dependencies, categories d, e, f, and g.
With hat: portmgr
Sponsored by: Absolight |
0.40.0 21 Jan 2016 19:40:10 |
kwm |
Update poppler to 0.40.0. [1]
Add patches to py-poppler [2] and rubygem-poppler [3] to fix the build
of these ports with poppler 0.39+.
PR: 206293 [1]
Submitted by: olivierd@ [1]
Obtained from: ubuntu [2], rubygem-poppler upstream [3] |