net/samba416: fix rl_completion_func_t detection and usage

After a recent devel/readline update, net/samba416 fails to compile with
clang 19, resulting in errors similar to:

  ../../libcli/smbreadline/smbreadline.c:139:38: warning: 'CPPFunction' is
deprecated [-Wdeprecated-declarations]
    139 |                 rl_attempted_completion_function = RL_COMPLETION_CAST
completion_fn;
        |                                                    ^
  ../../lib/replace/system/readline.h:50:31: note: expanded from macro
'RL_COMPLETION_CAST'
     50 | #  define RL_COMPLETION_CAST (CPPFunction *)
        |                               ^
  /usr/local/include/readline/rltypedefs.h:38:50: note: 'CPPFunction' has been
explicitly marked deprecated here
     38 | typedef char **CPPFunction (void) __attribute__((deprecated));
        |                                                  ^
  ../../libcli/smbreadline/smbreadline.c:139:36: error: incompatible function
pointer types assigning to 'rl_completion_func_t *' (aka 'char **(*)(const char
*, int, int)') from 'CPPFunction *' (aka 'char **(*)(void)')
[-Wincompatible-function-pointer-types]

net/samba416: Mark flavor externalldb as BROKEN

databases/ldb25 is not built with Python support by default, which is
required for the externalldb to build correctly. We are going to be
deprecating net/samba416 soon, so let's not introduce unnecessary
instabilities by enabling Python support in databases/ldb25 by default.

Interested parties building their own packages can still set TRYBROKEN
for this flavor and carry on.

For Samba 4.19, we have transitioned to the unbundled model anyway, so
net/samba416 is the only Samba version to be available the externalldb
flavor.

PR:		276835
Reported by:	pkg-fallout
Approved by:	samba (0mp)
Sponsored by:	Klara, Inc.

*/*: Let samba@ maintain ldb, tdb, talloc, tevent, and Samba

PR:		280556
Approved by:	portmgr

net/samba416: Fix startup script in a jail environment

PR:		275343
Approved by:	maintainer timeout (6 months)
Approved by:	mikael (samba419 maintainer, ports committer)

net/samba416: Add externalldb flavor

Why do we need the externalldb flavor? Compiling tools like
security/sssd-devel with Kerberos support often requires a standalone
ldb as a dependency. By adding a externalldb flavor, ports can depend on
a flavor of Samba that does not depend on its bundled version of ldb.

PR:		276835
Approved by:	portmgr (maintainer timeout, 2+ weeks)
Sponsored by:	Klara, Inc.
Co-authored-by:	Mateusz Piotrowski <0mp@FreeBSD.org>

net/samba416: Patch to prevent abnormal smbd abort

Update a call to memcpy() because readdir() only guarantees memory up to
result+result->d_reclen is readable.  Under certain conditions,
result+sizeof(struct dirent) landed in unmapped memory.

Most of the legwork to pinpoint the problem, as well as a solution
similar to the one applied here, was submitted by uratan@miomio.jp.
Martin Simmons <martin@lispworks.com> contributed to understanding the
problem and wrote a useful test case.

PR:		275597
Approved by:	maintainer timeout
Sponsored by:	The FreeBSD Foundation
Differential Revision:	https://reviews.freebsd.org/D43171

net/samba416: Sanitize MANPREFIX

Approved by:    portmgr (blanket)

*/*: Sunset 12.4-RELEASE/12-STABLE from ports tree

- Remove all references to defunct ARCH arm
- Remove all references to defunct ARCH sparc64
- Remove x11-drivers/xf86-video-sunffb which requires defunct sparc64
  ARCH
- Remove sysutils/afbinit requires defunct sparc64 ARCH
- Remove all references to bktr driver
- Remove all references to defunct FreeBSD_12
- Remove all references to OSVERSION/OSREL corresponding to 12
- Remove conditionals in Mk/Uses/cabal.mk
- Remove sparc reference from Mk/Uses/qt-dist.mk
- Remove BROKEN_sparc64/NOT_FOR_ARCH=sparc64
- Remove BROKEN_FreeBSD_12* from:
- Remove OpenSSL patches from:
- Remove conditional flags for OSVERSION >= 1300000 to fixed flags.
  Also move conditional flags for non sparc64/arm ARCH to fixed flags.

Reviewed by:	brooks, jbeich, rene, salvadore
Differential Revision: https://reviews.freebsd.org/D42068

net/samba416: Fix build with lld 17

Building net/samba416 with lld 17 results in the following link errors:

runner ['cc', '-Wl,--as-needed',
'-Wl,--version-script=/wrkdirs/share/dim/ports/net/samba413/work/samba-4.13.17/bin/default/lib/replace/replace.vscript',
'-shared', 'lib/replace/replace.c.2.o', 'lib/replace/strptime.c.2.o',
'lib/replace/cwrap.c.2.o', 'lib/replace/xattr.c.2.o',
'-o/wrkdirs/share/dim/ports/net/samba413/work/samba-4.13.17/bin/default/lib/replace/libreplace-samba4.so',
'-Wl,-Bstatic', '-Wl,-Bdynamic', '-L/usr/local/lib', '-L/usr/local/lib',
'-fstack-protector-strong', '-L/usr/local/lib', '-Wl,-z,relro,-z,now',
'-Wl,-no-undefined', '-Wl,--export-dynamic']
ld: error: version script assignment of 'local' to symbol '_end' failed: symbol
not defined
ld: error: version script assignment of 'local' to symbol '__bss_start' failed:
symbol not defined
ld: error: version script assignment of 'local' to symbol '_edata' failed:
symbol not defined
cc: error: linker command failed with exit code 1 (use -v to see invocation)

Since the linker version scripts are generated dynamically, suppress
errors with lld >= 17 due to these undefined symbols.

Same patch from 8bc0f1e by dim@ to unbreak build on FreeBSD 15.

This is required as the DEFAULT version of sambe is being switched.

Approved by:	portmgr (blanket)

net/samba41[36]: Make 'USES=shebangfix' work as is expected

While testing patch submitted to bug #270383, I noticed
'USES=shebangfix' doesn't work as is expected with current samba
ports. According to the investigation by Tatsuki Makino, it is because
SHEBANG_FILES is defined after bsd.port.options.mk and bsd.port.pre.mk
are included. So fix the issue by moving the definition before the
inclusion of them

Reference:	https://lists.freebsd.org/archives/freebsd-ports/2023-November/004849.html
Reference:	https://lists.freebsd.org/archives/freebsd-ports/2023-November/004852.html
Reference:	https://lists.freebsd.org/archives/freebsd-ports/2023-November/004853.html
PR:		274885
Approved by:	maintainer timeout

devel/icu: update to 74.1

Changes:	https://github.com/unicode-org/icu/releases/tag/release-74-1
Reported by:	GitHub (watch releases)
PR:		274317
Exp-run by:	antoine (incomplete)
Approved by:	fluffy

net/samba416: Update to 4.16.11

ChangeLog:	https://www.samba.org/samba/history/samba-4.16.11.html
PR:		272638
Approved by:	maintainer timeout
MFH:		2023Q3
Security:	441e1e1a-27a5-11ee-a156-080027f5fec9

all: remove support for expired FreeBSD 13.1

Approved by:	portmgr (implicit), salvadore (gcc ports)
Reviewed by:	jbeich

Differential Revision: https://reviews.freebsd.org/D40845

all: remove explicit versions in USES=python for "3.x+"

The logic in USES=python will automatically convert this to 3.8+ by
itself.

Adjust two ports that only had Python 3.7 mentioned but build fine
on Python 3.8 too.

finance/quickfix: mark BROKEN with PYTHON

libtool: compile:  c++ -DHAVE_CONFIG_H -I. -I../.. -I -I. -I.. -I../.. -I../C++
-DLIBICONV_PLUG -DPYTHON_MAJOR_VERSION=3 -Wno-unused-variable
-Wno-maybe-uninitialized -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong
-fno-strict-aliasing -DLIBICONV_PLUG -Wall -ansi
-Wno-unused-command-line-argument -Wpointer-arith -Wwrite-strings
-Wno-overloaded-virtual -Wno-deprecated-declarations -Wno-deprecated -std=c++0x
-MT _quickfix_la-QuickfixPython.lo -MD -MP -MF
.deps/_quickfix_la-QuickfixPython.Tpo -c QuickfixPython.cpp  -fPIC -DPIC -o
.libs/_quickfix_la-QuickfixPython.o
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean
'-Wno-uninitialized'? [-Wunknown-warning-option]
QuickfixPython.cpp:175:11: fatal error: 'Python.h' file not found
          ^~~~~~~~~~
1 warning and 1 error generated.

Reviewed by:	portmgr, vishwin, yuri
Differential Revision:	<https://reviews.freebsd.org/D40568>

devel/icu: update to 73.1

- Temporarily switch to GitHub auto archive (release artifacts are N/A atm)

Changes:	https://github.com/unicode-org/icu/releases/tag/release-73-1
Reported by:	GitHub (watch releases)
PR:		270422
Exp-run by:	antoine

net/samba416: Security update for samba416 to the 4.16.10

Security:	CVE-2023-0225
		CVE-2023-0922
		CVE-2023-0614

MOVED: Use the nox11 flavor for tshark and friends

This includes net/py-pyshark, net/termshark, and the samba ports for
testing.
Reported by:	mat

net/termshark|samba41[36]: Chase the tshark>wireshark change

Reported by:	cperciva

Mk/**ldap.mk: Convert USE_LDAP to USES=ldap

Convert the USE_LDAP=yes to USES=ldap and adds the following features:

- Adds the argument USES=ldap:server to add openldap2{4|5|6}-server as
  RUN_DEPENDS
- Adds the argument USES=ldap<version> and replaces WANT_OPENLDAP_VER
- Adds OPENLDAP versions in bsd.default-versions.mk
- Adds USE_OPENLDAP/WANT_OPENLDAP_VER in Mk/bsd.sanity.mk
- Changes consumers to use the features

Reviewed by:	delphij
Approved by:	portmgr
Differential Revision: https://reviews.freebsd.org/D38233

net/samba416: Security update for the recent Heimdal/KRB5 related
vulnerabilities.

Security:	CVE-2022-38023
		CVE-2022-37966
		CVE-2022-37967
		CVE-2022-45141

net/samba416: Security update for Samba 4.16

Security:	CVE-2022-42898

net/samba416: Update port to address CVE-2022-3437

PR:		267141
Security:	CVE-2022-3437

devel/icu: update to 72.1

Changes:	https://github.com/unicode-org/icu/releases/tag/release-72-1
Reported by:	GitHub (watch releases)
PR:		266582
Exp-run by:	antoine

net/samba416: New port for Samba 4.16

This is an initial attempt to add Samba to the FreeBSD after major
rewrite of the VFS code in the upstream.

Most of the port development is now carried in:

     https://gitlab.com/samba-freebsd

Due to the way how new Samba VFS code is written there is a constrain
that Samba 4.14+ can run only on FreeBSD 13.1+, as it requires support
of the `nodup` option for the `fdesc` file system, as well as it's
presence in the system in general.

    https://gitlab.com/samba-freebsd/-/wikis/The-New-VFS

I'd like to thank CyberSecure Pty Ltd. company for their supoort of
the port development and Andrew Walker from iXsystems Inc. for the
patches he created and made available for the Samba4 on TrueNAS.

PR:		263874