ports-mgmt/synth: add missed patchfile, fixes the build (+)

followup to 8df72f129d791a1d80b2d47e43fb2569ba865c95

PR:	279870

ports-mgmt/synth: update to 3.01 release (+)

PR:	279866

ports-mgmt/synth: Sanitize MANPREFIX

Approved by:    portmgr (blanket)

*/*: Sunset 12.4-RELEASE/12-STABLE from ports tree

- Remove all references to defunct ARCH arm
- Remove all references to defunct ARCH sparc64
- Remove x11-drivers/xf86-video-sunffb which requires defunct sparc64
  ARCH
- Remove sysutils/afbinit requires defunct sparc64 ARCH
- Remove all references to bktr driver
- Remove all references to defunct FreeBSD_12
- Remove all references to OSVERSION/OSREL corresponding to 12
- Remove conditionals in Mk/Uses/cabal.mk
- Remove sparc reference from Mk/Uses/qt-dist.mk
- Remove BROKEN_sparc64/NOT_FOR_ARCH=sparc64
- Remove BROKEN_FreeBSD_12* from:
- Remove OpenSSL patches from:
- Remove conditional flags for OSVERSION >= 1300000 to fixed flags.
  Also move conditional flags for non sparc64/arm ARCH to fixed flags.

Reviewed by:	brooks, jbeich, rene, salvadore
Differential Revision: https://reviews.freebsd.org/D42068

*: Bump PORTREVISIONs for math/mpc update to 1.3.1

ports-mgmt/synth: update to 2.13 release (+)

* Control the port scan environment (#212)
* Adjust umount to prevent ccache directory from getting wiped out (#199)

Release notes:	https://github.com/jrmarino/synth/releases/tag/v2.13

ports-mgmt/synth: bump after devel/adacurses update, remove expiration mark

Ada ports and Synth: extend expiration till the end of the year

Requested by:	fluffy

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

ports-mgmt: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  "Waitman Gobble" <uzimac@da3m0n8t3r.com>
  *  Akinori MUSHA aka knu <knu@idaemons.org>
  *  Alex Dupre <ale@FreeBSD.org>
  *  Alex Stangl <alex@stangl.us>
  *  Anders F Bjorklund <afb@users.sourceforge.net>
  *  Benjamin Lutz
  *  Brendan Molloy <brendan+freebsd@bbqsrc.net>
  *  Conrad J. Sabatier <conrads@cox.net>
  *  Edwin Groothuis (edwin@mavetju.org)
  *  Emanuel Haupt <ehaupt@FreeBSD.org>
  *  Gabriel Linder <linder.gabriel@gmail.com>

cleanup: Expire gcc6-aux consumers on 2022-09-30

This entails:
- devel/adacurses/Makefile
- misc/ini_file_manager/Makefile
- ports-mgmt/synth/Makefile

The DEPRECATED is set via USES=ada

ports-mgmt/synth: update to  2.12 release

* Support pkg 1.17.0 new extension and compression

ports-mgmt/synth: Update to 2.11 release

This fixes https://github.com/jrmarino/synth/issues/193
(sys/sys/param.h in freebsd/main loses comment after __FreeBSD_version)

MFH:	2021Q2

ports-mgmt/synth: update to 2.10 release

While here, take maintainership

abandoning ports-mgmt/synth and lang/gcc6-aux

I have not been using synth for a while and I not interested to maintain synth
and gcc6-aux anymore.

Remove # $FreeBSD$ from Makefiles.

ports-mgmt/synth: allow using base ncurses

PR:		244142
Approved by:	ericbsd (maintainer)

update ports-mgmt/synth to 2.08

PR:		235365
Submitted by:	Jonathan Chen
Approved by:	mentors (implicit)

update ports-mgmt/synth to 2.07

Approved by:	mentors (implicit)

Update ports-mgmt/synth to 2.06

Approved by:	wg (mentor)

Update ports-mgmt/synth to 2.05

PR:		228573
Approved by:	wg (mentor)

Update ports/synth from 2.03 to 2.04

Approved by:	wg (mentor)

Update ports-mgmt/synth to 2.03

Approved by:	wg (mentor)

Update Eric Turgeon ports maintainer email

Approved by:	wg, bapt (mentors)

Bump PORTREVISIONs of all users of math/mpc that we just updated to
version 1.1.0 (via revision 464079).

ports-mgmt/synth: Update to 2.02

- flavor fixes, repo build and package installs

PR:		224139
Submitted by:	Jonathan Chen <jonc@chen.org.nz>
Approved by:	ericturgeon.bsd@gmail.com (maintainer)

ports-mgmt/synth: Update to 2.01

PR:		224075
Submitted by:	Jonathan Chen <jonc@chen.org.nz>
Approved by:	ericturgeon.bsd@gmail.com (maintainer)

ports-mgmt/synth: update 1.71 -> 2.00, add FLAVOR support

PR:		224049
Approved by:	ericturgeon.bsd@gmail.com (maintainer)

ports-mgmt/synth: Update to 1.71

PR:		223350
Submitted by:	Jonathan Chen <jonc@chen.org.nz>
Approved by:	ericturgeon.bsd@gmail.com (maintainer)

ports-mgmt/synth: Build with watchdog monitor by default

Without WATCHDOG Synth will hang on the ports that stop building [1].

While here:
- Rename the double negative NOWATCHDOG option to WATCHDOG

[1] https://github.com/jrmarino/synth/issues/53#issuecomment-335425660

PR:		222900
Submitted by:	ericturgeon.bsd@gmail.com (maintainer)
MFH:		2017Q4

Update to 1.70

Add NOWATCHDOG option

PR:		220812
Submitted by:	jonc@chen.org.nz
Approved by:	ericturgeon.bsd@gmail.com (maintainer)

ports-mgmt/synth: update 1.68 -> 1.69

- FreeBSD/ARM* support

PR:		218253
Submitted by:	Jonathan Chen <jonc@chen.org.nz>
Approved by:	ericturgeon.bsd@gmail.com (maintainer)

Pass maintainership by request to the reporter.

PR:		217075
Submitted by:	mmokhi
Reported by:	ericturgeon.bsd@gmail.com
Reviewed by:	feld, mat
Approved by:	feld (mentor)
Differential Revision:	https://reviews.freebsd.org/D9572

Return ports maintained by John Marino to the pool, see r433827 for details

ports-mgmt/synth: Upgrade version 1.67a => 1.68

1) Create a platform-specific (FreeBSD/DF, NetBSD, Linux, Solaris) version
   of /etc/shells for the builders.  This resolves installation errors on
   packages that manipulate /etc/shells.

2) Give in and finally mount /usr/games if available.  This is a
   performance impact ultimately caused by removing the strfile
   application from ports with the faulty logic that the 400-line C
   program can't exist because it's in a non-standard location in base.
   The alternative is that Synth can't build any applications that
   require strfile from games, e.g. all fortune ports.  Thanks! <sarcasm/>

ports-mgmt/synth: Upgrade version 1.67 => 1.67a

I forgot to bump the version internally, so v1.67 was showing v1.66 still
on the help screen.  Fix and re-release 1.67.

ports-mgmt/synth: Upgrade version 1.66 => 1.67

This version blocks TTY signals to and from background processes, allowing
lang/sbcl to build as well as avoiding disruption of an active ncurses
display by "you've got mail" message.

It also includes a minor duration time formatting fix on build logs and
the many-thousands-open-file-descriptor problem fix on purge-distfiles
command provided by 1.66_1 between releases.

There is also a change in the build order algorithm.  Previously the
categories were ordered alphabetically, but rather scanned in the order
that appears by walking the directory.  Now when the "nothing depends on
these ports" ports block starts building, it's in A-Z order by category/
portname whereas before ony the portname was ordered A-Z (the categories
were blocks in random order).  There is no real benefit to the reordering;
it's mainly to satisfy those bothered by disorder.

ports-mgmt/synth: Fix open file descriptor issue for purge-distfiles cmd

The purge-distfiles command reads the distinfo file of every port in the
tree, but unfortunately never closed the file descriptor when the scan
was complete.  This resulted in 26,000+ open file descriptors, possibly
exceeding the host server's FD limit.  (issue #70)

- Remove always-true/false conditions after FreeBSD 9, 10.1, 10.2 EOL

Approved by:	portmgr blanket

ports-mgmt/synth: Upgrade version 1.65 => 1.66

The primary reason for the creation of v1.66 is to provide support for
pkgsrc on FreeBSD, DragonFly, NetBSD and initial support for Linux and
Solaris.  It represents over 100 commits and was successful.  Along the
way, some improvements were made for the ports version.  A (likely
incomplete) list includes:

- Improve watchdog kill message by including inactive time for trigger
- Add SYNTHPROFILE variable and value to builders' mk.conf which can be
  used by custom local makefiles
- Force users to define TERM in environment if it is not present
- Ensure fetch(1) doesn't check for valid SSL certificates.  Since all
  downloads are hash-checked for authenticity, misconfigured SSL of a
  webserver is not a good reason to break fetching.
- New 6th log which documents why existing packages are obsolete (same
  as setting WHYFAIL in env.) "06_obsolete_packages.log"
- New SELFTEST environment command for test mode which forces new "test"
  phase to execute (for ports with regression tests)
- Updated man page

ports-mgmt/synth: Upgrade version 1.64 => 1.65

Skip new "base" category during ports scanning

  The new base category was never meant to be part of the build so the
  category makefile was intentionally left off so poudriere and friends
  would skip it.

  Unfortunately, this idea didn't account for Synth which has a different
  behavior: If no category makefile exists, *ALL* subdirectories are
  scanned instead of none of them.  (DPorts doesn't use category Makefiles
  because by definition all ports are valid; there are no "unhooked" ones)

  The proper solution would be to include a practically blank
  ports/head/base/Makefile to maintain consistency with the rest of

ports-mgmt/synth: Republish v1.64 as v1.64a

I forgot the internally increment the version number so it was still
showing v1.63.  The version fix is the only difference from v1.64.

ports-mgmt/synth: Upgrade version 1.63 => 1.64

Change in hook behavior:

  Now the initial building of pkg(8) triggers a success or failure hook
  after building.  Before ports-mgmt/pkg was the only port that could
  never trigger these hooks.  The "bulk run start" hook is triggered
  afterwords as pkg(8) is a prerequisite to preparing the bulk run.

Fix potential bad unmount of /usr/src

  In the case where /usr/src exists, but the profiles uses a system root
  that is not "/" and doesn't have an "usr/src" subdirectory, an error
  would be emitted as the unmount of the non-existant mount failed.  This
  uncommon use case has been fixed.

ports-mgmt/synth: Upgrade version 1.62 => 1.63

Fix web report regression caused by cleaning of history files.

  The history files were being removed too late.  Any ignored/skipped
  files erased after writing (but would return with first built/failed
  port).   If more than 500 ports were ignored+skipped, the web report
  would fail to show the history completely and would not recover. The
  old history files are now removed before the ignore/skip cascades.

ports-mgmt/synth: Upgrade version 1.61 => 1.62

Cosmetic: curses display

  Capitalize "Swap" and "Skipped" field labels

Cosmetic: web report

  After the build completes, fade out the builders table in 2.5 seconds.
  Nobody needs to see a table showing all the builders in "shutdown" mode.

Bandwidth: json files

  A history.json file holds up to 500 log entries.  16 bytes of spaces were
  removed which reduces the history file size by 8000 bytes.  Spaces were
  also removed from summary.json which can account for 20%+ of the size.

Only rewrite history files upon change:

  The last history.json file was being written/rewritten every 3 seconds
  regardless if there were changes to it or not.  Now it's only written
  if it's changed since the previous write.  This might help reduce errors
  seen by in nginx access log which are thought to occur when file changes
  as the file is being served.

ports-mgmt/synth: Upgrade version 1.60 => 1.61

Address "[N] Fetch prebuilt packages" bug:

  Once the /usr/local/etc/pkg/repos/00_synth.conf file was created, there
  was a good change that fetching prebuilt packages would stop with a
  fetch error that the checksum didn't match.  This seems to be caused by
  pkg(8) using both the FreeBSD and the Synth repositories and often
  deferring to the latter.  This is incorrect behavior as only the FreeBSD
  repository should be used for prefetching.  This issue is hopefully
  resolved now.

Web report behavior change:

  Any existing ??_history.json files are now deleted at the start of
  each run.  They were only litter as the javascript did not pull in old
  files, so this change just removes them.

  While here, rename the "Elapsed" column on the builders table to
  "Duration" to match the history table lable and also adjust the widths
  of the origin and information columns on the history table.

ports-mgmt/synth: Upgrade version 1.54 => 1.60

Major new feature: Web-based front-end

  A dynamic html report is now generated for each build.  The report is
  placed at <profile log directory>/Report/index.html.

  The report is updated 10 times per minute.  The entire build history
  is retained and is searchable, but that history is reset at the start
  of the next run.

  In addition, several fields are clickable and trigger a quick-filter
  on the history log including the "Built", "Failed", "Ignored",
  "Skipped", "No." column and "ID" column (see tiptool for action hint)
  and the "Total" field clears the search pattern quickly.

devel/adacurses: Prevent building with base ncurses headers

It turns out that the C source files were getting built with the headers
from the base ncurses.  The recent update in Synth's display exposed a
resulting problem with the add chtype routines, resulting in garbled
output.  Since adacurses is a static library, synth requires a revbump.

ports-mgmt/synth: Upgrade version 1.53 => 1.54

Handles remaining resizing exceptions and improves display handling.

Yesterday's work handled most of the common display exceptions, but others
were still possible.  Now all possible exceptions are handled.

Several improvements were made to the display:
  1) lines no longer wrap if the size width is resized too narrow; they
     get truncated as always intended
  2) Elements such as the elapse timer don't get displayed in the wrong
     place when the screen is too narrow (they just don't show)
  3) The dashes now get restored if the screen is sized small and then
     big again (or started small and then expanded).  In many cases those
     lines just never came back before.
  4) The "full" refresh frequency was increased a period of 30 seconds to
     a period of 4 seconds.  This has a side benefit to text-mode watchdog
     as well since that's the same timer for the log inspection.
  5) The history window height ranges from 10 to 50 rows.  If the xterm
     window starts small, the history will be 10 lines.  If it starts
     big, the number of lines will be dictated by the original size of
     the xterm window.  Making the screen small and then bigger again will
     reveal the full number of log lines.

ports-mgmt/synth: Upgrade version 1.52 => 1.53

Major bug fix: ncurses display resize hang fixed

  Until now, resizing the window why synth is running in ncurses mode
  caused synth to hang (it would finish the builds it was working on
  but the display wouldn't update and no new jobs would start).  This
  was due to an unhandled exception thown by ncurses binding as a result
  of the resize event, and now these are handled.

Minor fix: Ports with @info in pkg-plist now pass in test mode

  The mtree exclusion file was improved to allow these leftover info
  directories to be ignored (as is done in poudriere.  Before only
  info/dir was ignored, but the presence of "dir" prevented "info" from
  being removed by pkg(8) upon deinstallation.

enhancement: Augment text mode (requested)

  Now when a builder starts on a new package, the port origin will be
  shown in the running log (before only the completion was logged.)

ports-mgmt/synth: Upgrade version 1.51 => 1.52

Fix regression in text-mode caused by activation of watchdog.
The watchdog is checking the lengths of the build logs to figure out if
a builder has stalled.  It turns out that the logs were only being
inspected in ncurses display mode, so any port that took longer than
20 minutes to build would be aborted by the watchdog.

While here, bump the *BASE* time limit for the build phase from 20 to
25 minutes based on extreme causes (normally involving gcc or tex ports)
and also bump the check-plist phase limit from 3 minutes to 10 minutes.
Some ports have tens of thousands of files in them which takes a long
time to check under test mode, especially if the server is loaded.

ports-mgmt/synth: Upgrade version 1.50 => 1.51

This release changes the watchdog time limits from a fixed value to
one that is affected by the average load.  Using fixed values didn't
work well on extremely (and intentionally) loaded servers, e.g. an
overage load of 200 on an server with ncpu of 32.

The base times which were long to account for loading have been reduced,
and a multiplier of average-5 load / ncpu rounded to the nearest tenth
has been implemented (with 1.0 as the floor value).  For example, a 4-core
machine with an average 5-minute load of 6.0 will multiply the base
timeout by 1.5.  This approach worked well in an extreme test against the
entire ports tree.

ports-mgmt/synth: Upgrade version 1.43 => 1.50

This release improves robustness and activates the watchdog.
It leveraes the procctl functionality to ensure all processes spawned
from a builder are reaped, which in turn ensures that tmpfs mounts can
be dismounted.  Previously stuck processes could prevent those dismounts,
trapping them as new mounts get placed on top.

This also finally enables the watchdog that will kill runaway builds.
The watchdog has a specific time limit per build phase where it will
kill the build if the log doesn't grow over the previous X minutes.

No activity timeout limits per phase are:

  check_sanity    :   1 minute

ports-mgmt/synth: Upgrade version 1.42 => 1.43

This is a minor bug fix version.  Changes include:
 * Set close-on-exec operation mode on popen.  This is required to stop
   leaking file descriptors in highly concurrent modes (e.g. 32 builders).
   It's not supported on FreeBSD 9 or DragonFly 4.4 (and earlier) so this
   modification is removed for those platforms.
 * Remove procfs mount for lang/rust and lang/rust-nightly.  This was
   necessary for DragonFly, but rust has been fixed for DF 4.6 and later
 * Add a stage-QA exception for entries left /var/spool/*.  The presence
   of these are not an identication of a port issue
 * Sanitize synthexec to verify file descriptors 0 .. 2 are in use and
   automatically close any file descriptor > 2 before execv fork.

ports-mgmt/synth: Remove ineffective sed command from port makefile

At one point during development of last changeset, the default.gpr
file needed to have a LOCALBASE correction, but that's no longer true.
This line shouldn't have made it into the previous commit.

ports-mgmt/synth: Upgrade version 1.41 => 1.42

This is a bug fix version.  Changes include:
  * Fix potential exception seen with a large number of builders.  The
    height of the log area was determined by subtracting the height of
    the other two zones from the overall xterm height.  This allowed for
    the possibility of a negative height for the log area resulting in a
    thrown exception.  Now the log is defined to be at least 10 lines
    log, but ncurses will just truncate as necessary.
  * Detection of bad OPSYS value added.  There's a rare case where pkg
    can corrupt the configuration value of the Operating System.  If it
    happens on FreeBSD, Synth thinks it is running on DragonFly which
    causes all sorts of problems.  The corruption can't be auto-fixed,
    but Synth will gracefully abort with instructions on how to correct
    the issue.

ports-mgmt/synth: Upgrade version 1.40 => 1.41

This release adds detection and handling of circular dependencies.
Two users that tried replacing OpenSSL with LibreSSL found out that
ftp/curl depends on itself when its built with GNUTLS.  That's because
Synth goes into an infinity dependency loop, runs out of stack space,
and crashes.

Now Synth can detect a circular dependency and abort gracefully and
informatively, e.g.

> synth status ftp/curl
ftp/curl scan aborted because a circular dependency on ftp/curl was detected.
... backtrace devel/cmake
... backtrace emulators/tpm-emulator
... backtrace security/trousers
... backtrace security/gnutls
... backtrace ftp/curl

While here, build synth with stack-checking on so out-of-stack situations
result in an exception and not an illegal instruction crash.

ports-mgmt/synth: Upgrade version 1.34 => 1.40

This release brings a behavioral change to Synth.  The action of building
package repositories is much more conservative now; packages that would
fail sanity checks are only removed under the following commands:
  * synth prepare-system
  * synth upgrade-system
  * synth rebuild-repository
  * synth everything

That means the following commands will never result in built packages
being removed now:
  * synth install
  * synth build (followed by "yes" to rebuild repo question)
  * synth force (followed by "yes" to rebuild repo question)

ports-mgmt/synth: Stop using bundled adacurses & IFM

Now that the Ada Framework is based on GCC6 by default, it is no
longer required for Synth to bundle and build a local version of
devel/adacurses and misc/ini_file_manager.

Switch the port to normal BUILD_DEPENDS and remove the bundle
distfile information.  No bump is required because these libraries
are statically linked into Synth, so there's no practical difference
between older and newer packages.

ports-mgmt/synth: Upgrade version 1.33 => 1.34

* Incorporate prefetch partial-revert patch (1.33_1) and remove the
  patch and files directory.
* Add lang/rust and lang/rust-nightly to the list of ports that require
  procfs to build.  This is only true for DragonFly.  The plan is to
  eliminate this requirement, but it's a bit tricky right now.  Once
  done, the rust ports will be removed from the list again.
* Move /var/db/fontconfig directory exception from post-build to all
  stages.  The doxygen port has shown that /var/db/fontconfig changes
  during the build phase and this is legitimate.

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

ports-mgmt/synth: Fix regression

The empty-queue check was supposed to improve pre-fetch behavior,
but it negatively affected other use modes, so remove the check
for now.

ports-mgmt/synth: Upgrade version 1.32 => 1.33

Prefetching option fix:
  Until now, if the "prefetch suitable packages" option was enabled, it
  could happen that "synth force" and "synth test" commands wouldn't do
  anything.  Moreover, even though it wouldn't build, it would delete the
  existing package and refetch it because force/test always pre-deletes
  existing packages.

  Now, ports listed with "force" and "test" commands are always built,
  even if suitable remote packages are available.

Improvements with test mode:
  1) Changes to /var/tmp are now ignored.  These are legal modifications
  2) Access time modification to the builder mount are now ignored.  This

ports-mgmt/synth: Upgrade version 1.31 => 1.32

prepare-system, upgrade-system package deletion bug:
  These two commands had a serious logic flaw that resulted in newly-built
  packages to be immediately deleted prior the pkg(8) repo command.  (And
  the obvious result of the system not getting updated without re-running
  the same command.)

  The cause was that the first package validity scan marked the package
  for deletion, and this setting was never reset.  The obsolete package
  was correctly deleted and rebuilt, but then it was quickly deleted
  again during the second package scan because the previous deletion mark
  was still present.  The fix was simple: Reset the deletion marks before
  rebuilding the repository so the second scan proceeds accurately.

  Test case provided by Wapcaplet in FreeBSD forums

ports-mgmt/synth: Upgrade version 1.30 => 1.31

Pkg(8) bug workaround:
  The pkg rquery man page is incorrect.  It lists the invocation of
  pkg rquery as "-U -r reponame" but if it's invoked in that order, it
  will squawk errors if any of the repositories are misconfigured.  The
  command must be "pkg rquery -r reponame -U" in order to limit pkg(8) to
  a single repository.

  The order sensitivity came into play with "synth upgrade-system" command
  on a brand new system.  The 00_synth.conf pkg(8) configuration file was
  created but there were no repository files created yet, cause pkg(8) to
  emit errors on Synth repo when checking the official FreeBSD package
  repo. This resulted in no packages prefetching even though "synth status"
  indicated some would be fetched.  Rearranging the internal rquery
  commands works around the misleading pkg(8) documentation (or bug?).

FreeBSD-specific system root validity check.
  The $SYSROOT/boot directory doesn't have to be present, but if it is,
  there must also be present $SYSROOT/boot/modules directory. Synth now
  checks for this on FreeBSD and stops with an informative message when
  the modules directory needs to be created by the root user.

ports-mgmt/synth: Upgrade version 1.22 => 1.30

This is an enhancement release that contains a bug fix.

Description of bug:
  If synth is launched from mountpoint of the ports directory
  (e.g. /usr/ports), it may malfunction with strange messages such
  as "invalid origins" and printing strange symbols to the screen
  along with parts of a directory.

  As a result, Synth now detects this launch location (as it already
  did with /usr/local) and refuses to run until the current directory
  is changed outside of the ports tree.

Enhancement 1:

ports-mgmt/synth: Upgrade version 1.21 => 1.22

Two minor bug fixes:
 * A specific check during test mode would emit a failure to stdout when
   testing devel/py-setuptools27.  It turns out that there's a file there
   with a space in the filename.  The filename was an argument for
   /usr/bin//file and it wasn't escaped.  The file in question had
   parentheses too which the shell was trying to process.  The fix was
   to escape the filename in the /usr/bin/file command.
 * The builders were mounting the source directory from "/usr/src", not
   $sysroot/usr/src as intended.  This potentially causes breakage when
   the $sysroot reflects a different versions/release than the host
   machine has (e.g. making FreeBSD 10.2 packages on FreeBSD 11-current).
   Now the source directory mount is relative to profile's $sysroot.

ports-mgmt/synth: Upgrade version 1.20 => 1.21

I knew the repository signing enhancements weren't fully tested, but it
was important to get the regressions fixed.  I thought that if there were
any problems with the signing, people not using those features (e.g. 99%
of users) would not be affected.  Unfortunately, that's not true.

Due to a simple boolean logic error, an inaccurate and harmless warning
about not finding the signature fingerprint will show every time the
repository is rebuild.  This minor releases fixes that logic.

ports-mgmt/synth: Upgrade version 1.11 => 1.20

This was meant to be a pure enhancement release to support the signing
of the repository, but there were some regressions brought in with
version 1.1x and also some long standing bugs found.

Fixed:
 * Regression: Interactive test mode
   Changing the TERM setting to "dumb" semi-broke the interactive shell
   when ENTERAFTER is used with the test command.  The fix was to set
   TERM back to cons25 in this particular case.
 * Regression (serious): install command
   The improvement in speed of package validation for the rebuilding of
   the repository resulted in a new bug that caused the "synth install"
   command to install every port in the repository.  It was caused by

ports-mgmt/synth: Upgrade version 1.10 => 1.11

This fixes a regression in building ports that have dependences that
install kernel modules.  When DTrace support was added by providing a
read-only mount of /boot to the builder, the kernel modules could no
longer be installed at /boot/modules by pkg(8).

Previously, although successful, module installs would have caused a file
system violation on test mode checks.  Since /boot is now excluded from
checks (since DTrace support), leftovers in /boot/modules will not be
detected in test mode.  The fix is too elaborate and FreeBSD-specific
to worry about (plus there's the philosophy question about why the ports
framework is even allowed to modify the base but that's out of scope).

ports-mgmt/synth: Upgrade version 1.03 => 1.10

This release addresses unacceptably long repository rebuild times for the
worst cases (FreeBSD [1], slow CPU, slow mechanical disk).  Until now,
rebuilding the repository required a full tree scan (nearly 26k ports).
While I only saw around 4 minutes on a 4-year DragonFly machine equipped
with a SSD, others reported times exceeding 20 minutes.

This new method scans existing packages twice -- first to eliminate those
packages where the port was removed and also those with a mismatching
version (parallel).  This sets up a second pass to serially and
recursively scan the ports of the remaining packages.  That leads to the
final validation (same as previously done) and the actual repository
generation.  Now the repository generation time is much shorter, but
corresponds to the number of build packages in the packages directory.

The long repository generation times were identified prior to the 1.0
release, but I targetted 1.1 for the enhancement.

ports-mgmt/synth: Upgrade version 1.02 => 1.03

bug fixes:
 * cron operation fixed
   The terminal is unset for cron jobs.  The setting of TERM to "cons25"
   in the environment caused a failure, but it's fixed by changing the
   value to "dumb".  Note that curses must be off in the profile invoked
   by cron.
 * dtrace building fixed [1]
   On FreeBSD, /boot is now read-only null-mounted if it exists in the
   profile's system root.  This fixes building dtrace probes when the
   option is set.
 * fix muted pipe exit status
   Pipes have to be read even when no output is expected in order to get
   the correct exit status
 * fix pipe child exit status
   The previous implementation mixed child and parent exit statuses in
   error; now they are isolated and returned correctly.

Enhancement:
 If a muted pipe command fails, an appropriate error message is given
 including which command failed.  This helps identify the real error
 instead of repercussions appearing later which mask the problem.

PR:	207361 [1]

ports-mgmt/synth: Upgrade version 1.01 => 1.02 (tty checked)

Any attempt to alter echo and control flags when the standard input
stream is not connected to a tty will fail.  Fix the resulting nuisance
messages by skipping these steps if a tty is not present.

Reported by kmoore@ on jenkins

ports-mgmt/synth: Upgrade version 1.00 => 1.01 (echo fixed)

The echo and control-flow flags weren't being restored correctly in
general, and they weren't being restored at program exit.  The result
on PuTTY was that nothing would echo to the terminal after Synth
exited, but the new version fixes it.

ports-mgmt/synth: Release version 1.00

I'm pleased to finally issue the first release of Synth.  There were some
significant changes since the last release candidate:

* Rework piped command handling to fix command parsing
  Synth was using ada-util to execute external commands and receive the
  output.  Unfortunately, this implementation currently can not handle
  either extra whitespace nor can it support quoted values.  The author
  is going to fix this soon using popen and pclose for Unix, but I just
  implemented the functionality by binding to those functions myself.
* This was the only use of ada-util (I originally expected to use more
  of this library's functionality) so it's been dropped as a dependency.
  This reduces the stripped executable size by about 30%.
* The environment was prepopulated with UNAME_[x] variables.  This is

ports-mgmt/synth: Yet another release candidate

Unfortunately, there's been a bit too much change since 0.99_6 to
confidently release version 1.00, so another release candidate is
necessary.  Both new features and bug fixes were added.

New features:
  * Provide ability to define environment variables in a profile
    (/usr/local/etc/synth/<profile>-environment)
  * Support fetching by proxy using these environment variables
  * Add zsh and bash completion scripts
  * Accept port origins with trailing file separators (so people
    using completion scripts don't have to backtrack to remove them)
  * In text (non-curses) mode, output the current package build
    tally every 200 seconds (approximately)

Bug fixes:
  * Fix support for system roots that don't match host (e.g.
    ARCH, OSRELEASE, OSVERSION, etc
  * Fix ABI check for system roots that don't match host
  * Remove effect of system /etc/make.conf (originally seen when
    MAKE_JOBS_NUMBER was defined there and disabled synth)

ports-mgmt/synth: bug fixes and feature for port developers

I had hoped that 0.99_5 would be bug-free and the basis for the first
release (1.00), but couple were found.  If use of 0.99_6 reveals no
further issues after a week or so, I'll re-release it as v1.00.

bugs fixed:
  * if the origin started with a directory separator, an exception would
    occur.  Now it properly labels it as an invalid origin.
  * The "extract" stage was labelled as "checksum".  Internally everything
    was fine, but on the display, the order was checksum, extract-depends,
    checksum instead of checksum, extract-depends, extract.
  * During one phase (build), the DEVELOPER flag was set unconditionally.
    This was a regression as it wasn't always the case.  This code was
    tweaked several times since 0.99_5 and now the DEVELOPER setting has

ports-mgmt/synth: Fix end-run regression

A fairly recent change caused a regression after a build was complete.
Previously a "tally" or summary of the build would appear after the
ncurses screen was restored to the regular terminal mode.  It would
list how many ports were built, failed, etc.  After the regressin, it
just ended abruptly.

This commit restores the tally to show as it did previously.

ports-mgmt/synth: new feature, minor bug fixes and improvements

This is a minor update to synth, which includes:
  * Support for the WHYFAIL environment variable.  If this variable
    is defined (to any value) in the environment, Synth will turn on
    the "debug" mode for dependency and option sanity checks.  This
    mode will provide exact details on how the package failed the check.
  * README.md: editorial corrections, 3 images replaced to reflect current
    version of Synth
  * Man page: editorial correction, WHYFAIL documented, and the "Impulse"
    indicator was documented (in NOTES section)
  * Significantly improve ports scan error messages.  In particular,
    eliminate the 'bad value ""' messages that are caused by ports that
    are partially or completely missing.  Also propagate exception
    messages when helping.
  * Log 03 (ignored ports) did not list the actual ports, only the reason
    the port was ignored.  Fix bug to show category/port too.

Erratum on previous commit message: The "Graceful Shutdown" is initiated
with Control-Q, not Control-C!  The typo is doubly unfortunate because
Control-C will exit Synth without cleaning up the mounts.

build/synth: bug fixes, new features

WARNING: rebuild-repository command has changed action!  see below!

The follow changes have been made since v0.99_2:
  * Change the graceful shutdown key from "Escape" to Control-C.
    The former was easy to hit inadvertently (reported) and could be
    interfered with by terminal ANSI codes and/or mouse wheels.  The
    documentation has also been modified to reflect this change.
  * Fixed bug where installed packages that no longer had a port
    might cause the scan to fail rather than be ignored as advertised
  * New feature: SYNTHPROFILE environment variable
    When SYNTHPROFILE is set toTill be loaded rather than the default
    profile.  This is aimed for synth's use in scripts.
  * The "rebuild-repository" command has been renamed to "prepare-system".
    This is partly because the former command will be repurposed.
  * A new command assumed the name "rebuild-repository"; it performs a
    sanity check on all the built packages, removes the bad ones, and
    rebuilds the local Synth repository on command.  It is primarily for
    scripting use, but it has other legitimate uses.
  * Fix case where prefetching packages would try to update a non-existent
    local Synth directory.  As a consequence, prefetching is only done
    from a single external repository (the normal use case thought)

ports-mgmt/synth: two minor but important bug fixes

1) Fixed false "fetched failed" messages that always appear after
   prebuilt packages are fetched
2) Fix bug where "synth configure" command would not run if any directories
   were invalid.  For new systems, /usr/ports/distfiles is always invalid
3) Following 2), greatly improve error message by saying exactly which
   directory is missing and which configuration letter it pertains to
4) If synth is configured to a non-existent /usr/ports/distfiles directory,
   also add a recommendation to consider a better location outside of the
   ports tree and remind them to set DISTDIR in /etc/make.conf too.

ports-mgmt/synth: minor fixes plus linprocfs fix

1) When using prefetch option, list the packages that failed to download
   rather than just say, "at least one failed to download"
2) sysutils/htop requires linprocfs but doesn't set USE_LINUX.  Set this
   port to mount linprocfs based on its origin
3) Fix linprocfs implementation, it was mounting out of order, basically
   resulting in that it was non-functional
4) Close all the logs in the case where no packages are built.  In that
   case, the logs were never modified.  Changes discarded?

ports-mgmt/synth: v0.99 (RC), fixes / use official pkgs feature

Now Synth has all the features envisioned for the first release.  This
edition add an option (off by default) to fetch prebuilt packages if
they are suitable (ABI, options, dependencies match).  This feature is
aimed at people that only want to build ports with customized options,
but for ports with default configurations, they are happy to use the
official packages.  The feature is not heavily tested yet.

Once this version is sufficently tested, Release 1.00 will follow.

Other changes since 0.98_5:
  * curses will redrawn itself (correctly now) every 30 seconds to
    fix any corruption that may have occured
  * Synth everything will build the repository without deleting packages
    now (this was disabled on the last update)
  * The repos directory for pkg is read from pkg config instead of using
    the hardcoded defaults
  * The man page has been updated with new feature descriptions
  * linprocfs is mounted for linux_base ports
  * The regression that prevented linux ports from building has been
    fixed.  It was caused by caching LINUX_OSVERSION, so this variable is
    no longer cached.

ports-mgmt/synth: Finish test mode and various fixes

The following changes have been implemented:
  * The "test" command checks for file system violations between
    the configure and build targets (inclusive)
  * The "test" command hecks for leftover (extra), missing, and
    unexpectedly modified files and directories between the stage and
    deinstall targets (inclusive)
  * Fix bug where success system-upgrade was indicated as a failure
  * Bring in procfs mounts for x11-toolkits/gnustep-gui (only!)
    It appears to the be only port that needs it, but procfs appears to be
    pretty unstable, so we don't mount/dismount it unconditionally
  * Similarly, change linprocfs mounts/dismounts to only occur when when
    linux ports are building.  Linprocfs stability is unknown (and I can't
    test it on DF) so be conservative and use it as little as possible.

ports-mgmt/synth: disable hanging process watchdog due to scons

After setting the group process ID and then execv'ing into the
ports build target, any port using scons just locks up immediately
without any kind of message.  I assume it's a bug in scons but it
will take a while to resolve (probably requires a testcase case and
submitting upstream).   Since it caused a significant regression and
since normally users shouldn't hit hung processes often, I'm disabling
the feature for now.

ports-mgmt/synth: hanging process watchdog and various fixes

The following changes have been implemented:
  * The builder command executer had been upgraded with a watchdog.  It
    does not monitor the overall time of a phase (things like fetch /
    checksum vary depending on the internet connection and the volume it
    needs to download ranges from bytes to gigabytes), but it does monitor
    log progress.  Each phase has a maximum amount of time allowed for the
    log to be static (measured in lines, not file size).  If the log is
    static for too long for that phase, the processes of the builder will
    be killed, and the builder log updated accordingly.
  * The load indicator was stuck at 0.00 for some named locales (only on
    FreeBSD) so this was resolved.
  * Ports tree scanning time was cut nearly in half by caching make
    variables on each builders make.conf
  * Support for /usr/lib/lib32 was added for FreeBSD
  * purge-distfiles command was improved by handling potential exceptions
    and fixing the case of 100-1023 Mb purged (range was too narrow)
  * Typos on man page fixed
  * The directory ${PORTSDIR}/packages are now ignored.  This is the
    default package location and any existing packages were getting
    treated as port directories.
  * Skip some additional questions/actions if a graceful shutdown was
    previously detected

ports-mgmt/synth: Fix potential installation problem

On DragonFly, $LOCALBASE/etc/pkg/repos always exists, so I forgot to
verify that.  On FreeBSD, it doesn't necessarily.  Make sure to create
this path if it's missing before trying to write 00_synth.conf there.
While here, add an error message if it still fails for any reason.

ports-mgmt/synth: Fix two significant bugs

The big one: FreeBSD distfiles are located by default inside the ports
tree (which is kind of insane).  I forgot this and people that did not
modify DISTDIR had this directory full of files, which synth interprets
as non-functioning ports.  Make directory scans skip this directory if
found to correct.

The smaller one: Synth was supposed to squawk if it couldn't find a
valid portsdir at the environment (PORTSDIR), /usr/dports, or /usr/ports.
The squawk didn't work.  Moreover, it wouldn't check PORTSDIR set at
/etc/make.conf.  This change makes synth check there after the env.
check (thank you for the hint, bapt@).  It also correctly squawks
without creating synth.ini when PORTSDIR isn't valid.

Add new port: ports-mgmt/synth

Synth is a custom packge repository builder for FreeBSD and DragonFly.
It is intended to replace Portmaster, portupgrade, and poudriere for
the average user.  It is simple to learn (the powerful options are
limited in number) and user-friendly, but it is extremely fast due
to its parallel building capability.  It will "drop-in" on any system
as it leverages the stock pkg(8) facilities.  All ports are built
in a clean environment, so it is finally safe to build ports as
needed on a live system.  The default profile is the system itself, not
a new jail, which can be a valuable feature for some environments.

(more text on pkg-desc).
It's ready for wider testing now.