emulators/virtualbox-ose{,-kmod}-legacy: Fix MASTER_SITES

Fixes:	b4a6bc8744f4 (Improve ports)

emulators/virtualbox-ose*: Improve ports

* Replace PORTVERSION with DISTVERSION.
* Fix CONFLICTS_INSTALL.
* Fix PYTHON in DEFAULT_OPTIONS in emulators/virtualbox-ose.
* Pet portclippy and portlint.
* Formatting and etc.

PR:	258159

all: drop support for expired FreeBSD 14.0

Simplify expressions for FreeBSD 13.X

Reviewed by:	many

Differential Revision:	https://reviews.freebsd.org/D46601

emulators/virtualbox-ose{,-nox11,-kmod,-additions,-additions-nox11}-legacy: fix
build with llvm15+, fix run with PAE on i386

* Fix build with llvm15+ from ports and from base:
  - ISO C++17 does not allow 'register' storage class specifier;
  - require -fPIC on i386.
* Fix load kernel modules on host and guest i386 if kernel compiled with
PAE option: add non-default option PAE to ports.
Based on patches from mi@.

PR:		279257 224616
Approved by:	vbox (maintainer, timeout 1 month and 6 years)

*/*: llvm15 build fixes

llvm15 was also merged into 13.2-STABLE effective from OSVERSION
1302505. Fix the ports that failed to build with llvm15.

Approved by:	portmgr (blanket)

emulators/virtualbox-ose-kmod-legacy: Unbreak on HEAD

Approved by:	portmgr (blanket)

*: Bump PORTREVISIONs for math/mpc update to 1.3.1

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

*/*: Release my babies from my "created by" comments

emulators/virtualbox-ose-kmod*: Tie to a specific release branch.

Use a more restricted range of supported __FreeBSD_version values for
the virtualbox kernel module since it uses internal KPIs for which KBI
stability is not guaranteed.  DECLARE_MODULE_TIED would tie the module
to a specific __FreeBSD_version which would cause the module to stop
loading when an SA or EN is pushed on a release branch.  Instead, use
DECLARE_MODULE_MAXVER with an upper bound that is limited to the range
of a releng branch so that a module built on X.Y will load on X.Y with
SAs or ENs applied but will fail to load on X.Y-1 or X.Y+1.

Reviewed by:	kevans, imp, madpilot, lwhsu (earlier version)
Differential Revision:	https://reviews.freebsd.org/D16119

emulators/virtualbox-ose-kmod-legacy: Fix kernel panic in DHCP bridge mode

PR:		262656

Fix CONFLICTS entries of multiple ports

There have been lots of missing CONFLICTS_INSTALL entries, either
because conflicting ports were added without updating existing ports,
due to name changes of generated packages, due to mis-understanding
the format and semantics of the conflicts entries, or just due to
typoes in package names.

This patch is the result of a comparison of all files contained in
the official packages with each other. This comparison was based on
packages built with default options and may therefore have missed
further conflicts with optionally installed files.

Where possible, version numbers in conflicts entries have been
generalized, some times taking advantage of the fact that a port

*/*: Remove redundant '-*' from CONFLICTS definitions

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

emulators/virtualbox-ose-kmod-legacy: Fix hang at module loading time

After src commit e266a0f7f001 a module is not allowed to call
kern_kldload while being loaded. The virtualbox module is doing
exactly this though. virutalbox used to do this because the ng_ether
netgraph node did not provide version information in the past and
there was no way to properly depend on it.

ng_ether has gained versioning information in base r238844 more
than ten years ago, so we can now unconditionally properly depend
on it, since this revision is now included in all supported FreeBSD
versions.

Thanks to Tomoaki AOKI for identifying the base commuit exposing
the issue.

Backport fix to legacy port.

WHile here also merge a double patch for the smae file.

PR:		256505
MFH:		2021Q2

emulators/virtualbox-ose-legacy: limit portscout reporting

The VirtualBox legacy ports track version 5.x, limit portscout
reporting accordingly.

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

- Update VirtualBox OSE to 6.1.18
- Old VirtualBox OSE 5.2.44 preserved as "-legacy" versions of the
  ports (repocopied)
- Add back extra patch removed in r528258, actually required to
  build DEBUG kmod
- Correctly define WITH_DEBUG when enabling the DEBUG option, so
  binaries are not stripped

Please note that this new version supports only amd64 CPUs. If you need
to use older hardware please install the legacy ports.

Note that moving VM snapshots across major updates is unsupported, it's
strongly suggested to properly shutdown VMs before upgrading, please
check UPDATING for further details.

Remove virtualbox-*-legacy due to lack of staging

The virtualbox-ose-kmod-legacy port is staged, but it has no purpose
without the unstaged virtualbox-ose-legacy port, so both ports have
been removed at the same time.

Prefer USES=tar:bzip2.

Fix panic for stable/9.  Use vm_page_alloc_contig() as it is now available.

Tested by:	Douglas Berry (doug at bitnix dot ca)
PR:		ports/187580

Work around build problems on recent stable/9.

- Remove devel/dev86 from BUILD_DEPENDS and devel/bcc from CONFLICTS.  It
has not been used for very long time.
- Remove devel/yasm from BUILD_DEPENDS for kernel module.  It is actually
unnecessary for building kmod.

Stage support

Reviewed by:	vbox@ (decke)

Fix properties on pkg-plist

- Update to 4.2.22
- Convert USE_PYDISTUTILS=easy_install to USE_PYDISTUTILS=yes
- Add patch to fix building with new gsoap [1]
- Add direct dependency on qt4-opengl [2]

PR:		ports/185579 [2]
Security:	CVE-2013-5892
Submitted by:	Jung-uk Kim <jkim@FreeBSD.org> [1]
		Jimmy Olgeni <olgeni@FreeBSD.org> [2]

Part 1 at removing now useless FETCH_ARGS redifition

- Update to virtualbox-ose 4.2.20_1
- This update pulls in many changes from the port and brings better support
for FreeBSD 10 and GCC from ports. I am doing that in preparation of the
upcoming VirtualBox 4.3 update that should land soon.

Forgot to commit this port in the previous USES=kmod conversion.

Add NO_STAGE all over the place in preparation for the staging support (cat:
emulators)

- Add VM_OBJECT patch from virtualbox-ose-kmod to use WLOCK/WUNLOCK
on 10-CURRENT.

Submitted by:	Gabor Pali <pgj@freebsd.org>

- Update to 4.1.24
- Fix building with libxslt newer than 1.1.26

Obtained from:	https://www.virtualbox.org/ticket/10940

- Cleanup MASTER_SITES and use upstream mirror as primary

Discussed with:	beat (for chruetertee mirrors)

- Convert to optionsng

Submitted by:	bapt

- Update to 4.0.16
- Fix lib32 checks to use /usr/lib32/libc.so

Obtained from:          redports.org/~virtualbox/

In the rc.d scripts, change assignments to rcvar to use the
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().

In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.

- Bump PORTREVISION which was missing since adding PG_UNMANAGED patch for HEAD
- Pet portlint about LICENSE variables

Reported by:    avg

- Fix PG_UNMANAGED compile problem on HEAD after r224746.

Remove explicit initialization of m->flags and m->oflags because per
default vm_phys_alloc_contig() already initializes the page as unmanaged.
Chase move of PG_UNMANAGED flag from m->flags to m->oflags and renaming
to VPO_UNMANAGED for an additional assert.

PR:             ports/159675
Reported by:    Kyryll A Mirnenko <xmirya@gmail.com>,
                Michael Butler <imb@protected-networks.net>
Thanks to:      beat

- Fix kmod build on 9-CURRENT after removal of cpumask_t
- Bump PORTREVISION

Submitted by:   Jung-uk Kim <jkim@FreeBSD.org>

- Introduce -legacy ports
- Add vboxheadless startscript [1]
- Add vboxwebsrv startscript [2]
- Change CONFLICTS to CONFLICTS_INSTALL [3]
- Remove stale mirror
- Bump PORTREVISION

PR:             ports/156699 (based on) [3]
Submitted by:   Stefan Tollkuehn <stefan.tollkuehn@editura.de>, [1][2]
                Raul Gigea <raul.gigea@editura.de>, [1]
                Tobias Oberstein <tobias.oberstein@tavendo.de>, [1]
                Emil <the_mix_room@hotmail.com> [3]
Thanks to:      dougb@, [1][2]
                Cr4zi3/EFNet, [2]
                crsd [2]

Force commit to note the repocopy: emulators/virtualbox-ose to
emulators/virtualbox-ose-legacy and emulators/virtualbox-ose-kmod to
emulators/virtualbox-ose-kmod-legacy

PR:             ports/156843
Repocopy by:    marcus@