games/gtkradiant: try to fix the port's build against Clang 16

Ancient `register' keyword is gone with C++17, drop it from various
places.  Also, ISO C99 and later no longer tolerate implicit function
declarations, but the code in question is too convoluted and fragile
to fix properly, so just disable the warning for the time being.

While here, do not hardcode -O2 for release builds (system-provided
compilation flags being correctly upheld) and spell -Wextra correctly
(quoting the GCC docs*, this option used to be called -W; the older
name is still supported, but the newer name is more descriptive).

Reported by:	pkg-fallout

*) https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wextra

accessibility/at-spi2-core: update to 2.46.0

What's new in at-spi2-core 2.46.0:
* Fix GetInterfaces documentation on org.a11y.atspi.Accessible
  interface.

What's new in at-spi2-core 2.45.91:
* Send device event controller events using the same signature as other
  events.
* Document the Accessible, Action, and Cache dbus interfaces.
* Fix license of atspi-gmain.c (#87).

What's new in at-spi2-core 2.45.90:
* xml: Add some documentation.
* xml: Fix event arguments.

games/{gtk,net}radiant: fix getting file length on Unix-like systems

Decloak Q_filelength() which takes a pointer to FILE, not an integer
file descriptor, and optimize away superfluous call thereof.

Reported by:	pkg-fallout (clang 15)

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

games: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <benlutz@datacomm.ch>
  *  <janos.mohacsi@bsd.hu>
  *  Aaron Baugher
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Aaron Dalton <aaron@daltons.ca>
  *  Aaron VonderHaar <avh4@usa.net>
  *  Aaron Zauner <az_mail@gmx.at>
  *  Adam Kranzel (adam@alameda.edu)
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Ade Lovett <ade@FreeBSD.org>
  *  Akinori MUSHA aka knu <knu@idaemons.org>

textproc/libxml2: bump all LIB_DEPENDS consumers

This is a separate commit to facilitate easier cherry-picking for
quarterly.

PR: 262853, 262940, 262877, 263126
Approved by: fluffy (mentor)

textproc/libxml2: bump all dependencies

This should make sure that all dependent ports will pick
up the new version commited with a13ec21cd733f67a9fc0dc00ab45268bdc236246

Remove # $FreeBSD$ from Makefiles.

Convert to Python-threeish SCons.

Ensure that there is only one variable definition per each object, as
the C (and C++) standards mandated for years and compilers started to
enforce as of recently (Clang 11, GCC 10).

Reported by:	pkg-fallout

Update USES=scons to specify scons of Python 2

- While I'm here, convert emulators/gem5 and games/marsnomercy to USES=scons

Fix build with scons 3.1.2

Unbreak against Clang 10 and Python 3.

Reported by:	pkg-fallout

Deprecate a few ports

With hat:	portmgr

Bump PORTREVISION for ports depending on the canonical version of GCC
as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3
to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Avoid using `sys/dir.h' to make the port look less abandonware.

Obtained from:	games/netradiant (r504802)

These ports now build on aarch64.

Where necessary, pet portlint.

Approved by:	portmgr
Obtained from:	aarch64 TRYBROKEN run

games/gtkradiant: unbreak with libc++ 8

In file included from plugins/archivepak/plugin.cpp:24:
In file included from include/iarchive.h:25:
In file included from /usr/include/c++/v1/cstddef:38:
include/version:1:1: error: expected unqualified-id
1.5.0
^

PR:		236192
Approved by:	portmgr blanket

Bump PORTREVISION for ports depending on the canonical version of GCC
defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t
GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

Because of linking to libgraphite2, a C++11-compatible compiler is necessary.

Also, GCC needed an additional include.

While here, pet portlint.

PR:		232003
Submitted by:	Piotr Kubaj
Approved by:	portmgr (tier-2 blanket)

- Those ports fail to build with python3
- Add some explicit FLAVOR to dependencies where needed

- Fix build with clang 3.9

PR:		214650
Approved by:	portmgr blanket

Mark as broken on various tier-2 archs.

While here, pet portlint.

Approved by:	portmgr (tier-2 blanket)

Remove ${PORTSDIR}/ from dependencies, categories d, e, f, and g.

With hat:	portmgr
Sponsored by:	Absolight

- Fix broken communication with external tools (e.g. q2map): GtkRadiant's
  network library (libs/l_net) defines its own struct sockaddr_s, which
  has single ``short sa_family'' field instead of ``unsigned char sa_len''
  and ``sa_family_t sa_family'' of struct sockaddr; this, in turn, causes
  problems when sockaddr_s objects bogusly used as sockaddr ones, e.g.:

    connect(4, { sa_len = 2, sa_family = 0, ...) ERR#47 'Address family
    not supported by protocol family'

- Fix missing main window icon by calling pixbuf_new_from_file_with_mask()
  with correct filepath
- Since these changes are likely to improve GtkRadiant user's experience,
  tentatively bump port revision
- Fix comment indentation in `radiant/treemodel.cpp' (broken in r384527)

- Fix build on 64 bit architectures (cast from pointer to int loses precision)
- Drop @dirrm* from plist
- Add empty directories to plist

Approved by:	portmgr blanket

Oops, incomplete version of the patch was committed in r384239.

- Fix the build against modern libpng (do not try to access private data)
- Clang insists that reference cannot be bound to dereferenced null pointer
  in well-defined C++ code (that is correct) and evaluates comparisons like
  &foo == 0 to false, which breaks GtkRadiant; "fix" this with a dirty hack
  by casting those "bad" references to a local volatile int variable
- Remove no longer required and no-op -lpthread vs. -pthread patch hunk
- Report operating system and correct compiler version in the About dialog
- When fixing annoying "GtkSpinButton: setting an adjustment with non-zero
  page size is deprecated" warnings, replace find(1) with grep(1) to narrow
  down initial search results and, subsequently, sed(1) furiousness
- Omit port revision bump as the port was BROKEN for quite some time

Mark BROKEN: Does not support modern png

Bump portrevision after png update

Change libpng15.so to libpng.so in LIB_DEPENDS to prepare the upgrade

- Convert games/ to new USES=python

Approved by:	portmgr (implicit)

Update the default version of GCC in the Ports Collection from GCC 4.7.4
to GCC 4.8.3.

Part II, Bump PORTREVISIONs.

PR:		192025
Tested by:	antoine (-exp runs)
Approved by:	portmgr (implicit)

USES=scons, fix plist

The FreeBSD x11@ and graphics team proudly presents
a zeising, kwm production, with help from dumbbell, bdrewery:

NEW XORG ON FREEBSD 9-STABLE AND 10-STABLE

This update switches over to use the new xorg stack by default on FreeBSD 9
and 10 stable, on osversions where vt(9) is available.
It is still possible to use the old stack by specifying WITHOUT_NEW_XORG in
/etc/make.conf .
FreeBSD 8-STABLE and released versions of FreeBSD still use
the old version.
A package repository with binary packages for new xorg will
be available soon.

This patch also contains updates of libxcb and related ports, pixman, as well

Convert g* to USES=zip

Unbreak the build on recent -CURRENT, where linker is more strict.

Reported by:	pkg-fallout

- Comment out apparently unused yet offending piece of code to unbreak the
  build on amd64 (tested on MacBookPro6,2)
- Unify the usage of pre/do-install targets in both ports and stagify them

Reported by:	pkg-fallout

Add NO_STAGE all over the place in preparation for the staging support (cat:
games)

SSP support has been added to ports with WITH_SSP for i386 and amd64
on FreeBSD 10, and amd64 on earlier versions.

SSP_UNSAFE is added to disable in a port if it fails to build, but
this should only be used in rare circumstances such as kernel modules.
Otherwise, the port may just be failing due to lack of respecting
LDFLAGS.

On FreeBSD 10, this uses an ldscript in /usr/lib/libc.so to pull in
libssp_nonshared.a to address issues linking on i386 [1].

On earlier FreeBSD versions the WITH_SSP knob will add -lssp_nonshared
to LDFLAGS on i386. This is not needed on amd64. However, several hundred
ports do not currently respect LDFLAGS, so this support is disabled currently
as it causes build failures if a dependency is looking for the stack_chk

Add a couple of missing #include <stdlib.h>'s to please contemporary Clang.

Reported by:	pkg-fallout

- Reduce some minor differences with `games/netradiant'; mention the latter
  in the port description
- While here, fix annoying warnings of "GtkSpinButton: setting an adjustment
  with non-zero page size is deprecated"

- Unbreak linking with our new ld(1) by explicitly listing -lgobject-2.0 on
  the LINKFLAGS, otherwise we get this:

    /usr/bin/ld: invalid DSO for symbol `g_signal_connect_data' definition
    /usr/local/lib/libgobject-2.0.so.0: could not read symbols: Bad value
    c++: error: linker command failed with exit code 1 (...)
    scons: *** [build/release/radiant.cpu] Error 1

- Replace PTHREAD_LIBS variable with '-pthread' and tidy up some superfluous
  LOCALBASE-related assignments while here (leftovers from X11BASE era)

- Attempt to unbreak the build against Clang
- Get rid of bogus dependency on devel/py-subversion
- Modernize LIB_DEPENDS syntax, copy files with -a
- Add an explicit dependency on pkgconfig

Reported by:	pkg-fallout

* Update the glib to 2.34.3 and gtk20 to 2.24.17 and gtk30 to 3.6.4 which
  are the latest stable releases.
* Update vala to the newest stable release 0.18.1, also update a few ports
  in the gtk/gnome stack.
* The c++ bindings ports for glib, atk, gconf, etc, have now USE_GNOME toggles.
* Remove pkg-config run depends from glib20 and freetype2. This doesn't
  eliminate pkg-config run dependency completely, a second phase is needed
  and is planned.
* Support for .:run. and .:build. for USE_GNOME components was added.
  Currently only libxml2 and libxslt support this mechanism.
* Updates of the telepathy stack and empathy.
* Trim makefile headers, convert ports to new options, trim off library
  versions for some ports.
* Fix other ports so they build with the new glib version.

Thanks to miwi and crees for helping out with some exp-runs.
Approved by:	portmgr (miwi & bapt)
Obtained from:	gnome team repo

- update png to 1.5.10

-remove MD5

Clean up, add LICENSE, take maintainership.

- Drop maintainership.

- fix build for png-1.4.1

- update to 1.4.1
Reviewed by:    exp8 run on pointyhat
Supported by:   miwi

- update to jpeg-8

- bump all port that indirectly depends on libjpeg and have not yet been bumped
or updated
Requested by:   edwin

- Remove USE_GCC where it can be satisfied with base compiler on following
  FreeBSD versions: 5.3 and up, 6.x, 7.x, 8-CURRENT

  Bump PORTREVISION due to subversion upgrade.

  (1) Upgrade subversion to version 1.5.0.
  (2) Make binding ports to be real ports, which installs only bindings and
      depend on subversion.
  (3) Rename bindings ports to reflect perl5/python/ruby modules naming scheme.
  (4) Re-base subversion-freebsd to `devel/subversion'.
  (5) Fix all ports, which depends on subversion bindings.

Bump portrevision due to upgrade of devel/gettext.

The affected ports are the ones with gettext as a run-dependency
according to ports/INDEX-7 (5007 of them) and the ones with USE_GETTEXT
in Makefile (29 of them).

PR:             ports/124340
Submitted by:   edwin@
Approved by:    portmgr (pav)

- Remove unneeded dependency from gtk12/gtk20 [1]
- Remove USE_XLIB/USE_X_PREFIX/USE_XPM in favor of USE_XORG
- Remove X11BASE support in favor of LOCALBASE or PREFIX
- Use USE_LDCONFIG instead of INSTALLS_SHLIB
- Remove unneeded USE_GCC 3.4+

Thanks to all Helpers:
        Dmitry Marakasov, Chess Griffin, beech@, dinoex, rafan, gahr,
        ehaupt, nox, itetcu, flz, pav

PR:             116263
Tested on:      pointyhat
Approved by:    portmgr (pav)

Remove always-false/true conditions based on OSVERSION 500000

- Fix building with GCC 4.x.

Reported by:    pav

- Welcome X.org 7.2 \o/.
- Set X11BASE to ${LOCALBASE} for recent ${OSVERSION}.
- Bump PORTREVISION for ports intalling files in ${X11BASE}.

- Fix building with GCC 4.x.

Reported by:    pointyhat

- Integrate with bsd.scons.mk.

- Fix wrapper script (wrong file name).
- Increment PORTREVISION.

- Change library version of x11-toolkits/gtkglext in LIB_DEPENDS.
- Bump PORTREVISION.

- Fix building on non-i386 architectures.
- Avoid hacking the SConstruct file, pass information through the environment.

GtkRadiant is a level design program developed by id Software and Loki
Software. It is used to create maps for a number of computer games.

GtkRadiant originated as Q3Radiant, the Quake III Arena level design tool,
which was a Windows-only application. Two major things are different in
GtkRadiant: it is based on the GTK+ toolkit, so it also works in Linux and Mac
OS X, and it's also game engine-independent, with functionality for new games
added as game packs.

GtkRadiant is an Open Source application. Source code is publicly available
from id Software's Subversion repository and new additions to the code are
covered under open source licenses. The core Q3Radiant code, however, was
originally under id Software's proprietary license. The license for both the
editor and toolset (notably Q3Map2, the BSP compiler) was changed in February
2006, and publicly released under the GPL on February 17.

WWW: http://www.qeradiant.com/

PR:             ports/93668
Submitted by:   Alejandro Pulver <alejandro@varnet.biz>
Approved by:    garga (mentor)