net/rsync: fix test patch when all options are disabled

If all options are disabled, the extra-patch distfile is not
extracted, breaking the build.
Make this step optional if at least one option is active.

PR:		284154

net/rsync: fix build with portmaster

Change the fix for tests to unbreak the build with postmaster

PR:		284154
Reported by:	<iron.udjin@gmail.com>

net/rsync: unbreak tests

Fix rsync tests broken by upstream changes since 3.4.0.
Issue reported to upstream.

net/rsync: update to 3.4.1

Full changelog: https://download.samba.org/pub/rsync/NEWS#3.4.1

Major changes:
    * fixed handling of -H flag with conflict in internal flag values

PR:		284091
Reported by:	cy

net/rsync: update to 3.4.0

Full changelog: https://download.samba.org/pub/rsync/NEWS#3.4.0

Security:	CVE-2024-12084 - Heap Buffer Overflow in Checksum Parsing
Security:	CVE-2024-12085 - Info Leak via uninitialized Stack contents defeats
ASLR
Security:	CVE-2024-12086 - Server leaks arbitrary client files
Security:	CVE-2024-12087 - Server can make client write files outside of
destination directory using symbolic links
Security:	CVE-2024-12088 - --safe-links Bypass
Security:	CVE-2024-12747 -⁠ symlink race condition

PR:		284064
Reported by:	osa

net/rsync: upgrade to 3.3.0

Full changelog: https://download.samba.org/pub/rsync/NEWS#3.3.0

Major changes:
    * Several bugfixes around -sparse --inplace,
      buffer overflow in the checksum2,
      string-comparison issue in the internal handling of --progress,
      ensure local transfer marks the sender side as trusted,
      changes the argv handling to work with a newer popt library,
      a problem in the daemon auth for older protocols,
      old stats bug that counted devices as symlinks
   * Many enhancements:
     rrsync with the -no-overwrite option,
     manpages formating,
     mapfrom & mapto perl scripts into a single python script,
     mnt-excl perl script into a python script

PR:		278208
Reported by:	vvd

devel/autoconf: Update to 2.72

PR:		277046
Exp-run by:	antoine

net/rsync: Moved man to share/man

Approved by:    portmgr (blanket)

net/rsync: Fix typos

Approved by:	portmgr blanket

net/rsync: Update to 3.2.7

Major changes:
    * Fixed the client-side validating of the remote sender's filtering
behavior.
    * More fixes for the "unrequested file-list name" name
    * When rsync gets an unpack error on an ACL, mention the filename.
    * Avoid over-setting sanitize_paths when a daemon is serving "/"

Full changelog: https://download.samba.org/pub/rsync/NEWS#3.2.7

PR:		267921
Reported by:	daniel <daniel@nav.ro>

net/rsync: Fix typo in options check

Remove duplicate RENAMED option check and add the missing
FLAGS one. This has no impact on default build configuration.

Reported by:		Juraj Lutter <otis@FreeBSD.org>

net/rsync: Fix distinfo file generation

Fix a long standing issue in distinfo file generation caused
by the way patch distfiles are handled.

In the previous code, every time a patch was activated, it adds its own
entry into the DISTFILES variable, but because all the patches comes
from the same distfile, we ended with duplicate entries in the list.
As a consequence, the make makesum target generates a distinfo file with
duplicate entries, causing issues to the builder who tries to fetch and untar
the same file in paralel.

Now we add the distfile to the list if one of the options is activated,
avoiding duplication in the DISTFILES list.

This fix has no impact on the generated package, so no PORTREVISION
bump is required.

net/rsync: Fix distinfo

Remove duplicate patch lines

net/rsync: Update to 3.2.6

Major changes:
  * fix file-list validator in --files-from for files that ends without a
    line-terminating character
  * safety check when using --remove-source-files in a local copy that prevents
    removing file shared between src and dest
  * fix internal MD4 checksum code who causes sporadic invalid sums
  * rrsync: added "copy-devices" to the list of known args, but left it disabled
    by default
  * rename --protect-args to --secluded-args, environment-variable override did
    not change its name
  * configure option --with-protected-args was renamed to --with-secluded-args
    This option makes --secluded-args the default rsync behavior

Full changelog: https://github.com/WayneD/rsync/blob/master/NEWS.md

PR:		267153
Reported by:	Herbert J. Skuhra <herbert@gojira.at>

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

net/rsync: Remove duplicate entries in distinfo

This is a quick fix to unbreak the port.

The issue was caused by multiple additional patched
coming from the same distfile archive. If you enable
more than one of those options makesum script add a
distinfo description for each option.

PR:		265896

net/rsync: Update to 3.2.5

Major changes:
    * CVE-2022-29154 Added some file-list safety checking
    * CVE-2022-37434 Fix in the bundled zlib (buffer overflow issue)
    * Fix the handling of filenames specified with backslash-quoted wildcards
      whith the remote-arg-escaping
    * Fix configure check for signed char that causes bogus checksums
    * rsync is compiled with an xxhash 0.8 library
    * New --trust-sender option to bypass the extra file-list safety checking

Full changelog: https://github.com/WayneD/rsync/blob/master/NEWS.md

PR:		265633
Reported by:	rob2g2 <rob2g2-freebsd@bitbert.com>
Relnotes:	yes
Security:	CVE-2022-29154
Security:	CVE-2022-37434

*: bump PORTREVISION of all devel/xxhash users...

...except archivers/py-borgbackup, which requires a more complete fix.

net: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <ports@c0decafe.net>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Aaron Straup Cope <ascope@cpan.org>
  *  Aaron Zauner <az_mail@gmx.at>
  *  Adam Jette <jettea46@yahoo.com>
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Alan Eldridge <alane@geeksrus.net>
  *  Alex Bakhtin <Alex.Bakhtin@gmail.com>
  *  Alex Deiter <Alex.Deiter@Gmail.COM>
  *  Alex Dupre <ale@FreeBSD.org>
  *  Alex Dupre <sysadmin@alexdupre.com>

net/rsync: Fix unexpected changes caused by previous rsync commit

 * Remove python dependency introduced in last commit,
   we keep USES=python to fix the rrsync shebang but
   add PYTHON_NO_DEPENDS=yes since Python itself is
   not wanted. Add a pkg-message to notify users.
 * Fix patching issues on manpages and sample files
   which abusively transformes all etc paths into
   /usr/local/etc.
 * Install missing rrsync manpage

 Also add forgotten items in last commit
  * version 3.2.4 fixes CVE-2018-25032 in bundled zlib
  * remove upstreamed patch to fix time limit options (patch-io.c)

PR:		263787
PR:		263794
Reported by:	<jamie@catflap.org>
Reported by:	<freebsd@oldach.net>
Security:	CVE-2018-25032 in the bundled zlib

net/rsync: Update to 3.2.4

* Pet portclippy
* Tidy up Makefile with portfmt

ChangeLog:	https://download.samba.org/pub/rsync/NEWS#3.2.4
PR:		263417
Approved by:	maintainer timeout

net/rsync: Add patch to fix time limit options

In latest version, upstream project breaks
time limit options implementation. The fix
allows the use of this option in both receiver
and sender mode. A merger request was submitted
to upstream project[1] but not yet merged.

Bump portrevision.

[1] https://github.com/WayneD/rsync/pull/179

Reported by:	philip
Tested by:		philip

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

Remove deprecated optional patches

Remove broken options available in the past as additional patches provided
by the project and merged in the latest releases as part of the main source.

time-limit merged in 3.2.3 (6 Aug 2020)
   Added the --stop-after=MINS and --stop-at=DATE_TIME options (with the
--time-limit=MINS option
   accepted as an alias for --stop-after). This is an enhanced version of the
time-limit patch
   from the patches repo.

atimes merged in 3.2.0 (19 Jun 2020)
   Added the --atimes option based on the long-standing patch (just with some
fixes that the patch
   has been needing).

acls merged in 3.2.0 (19 Jun 2020)
   Added the --atimes option based on the long-standing patch (just with some
fixes that the patch
   has been needing).

Since those options are not activated by default, and if so, breaks the build,
no PORTREVISION bump is required.

PR:		250998
Submitted by:	 Zoltan ALEXANDERSON BESSE <zab@zltech.eu>

net/rsync: Update MASTER_SITES

Update list of rsync mirrors.
Remove ftp.fu-berlin.de, add a couple
of new mirrors. Mirrors are prefered
over main site kept as fallback.

No changes in the code so no version bump required

PR:		248319
Submitted by:	<daniel.engberg.lists@pyret.net>

net/rsync upgrade to 3.2.3

major changes:
 - Fix multiple bugs in xattr code.
 - Restored the ability to use --bwlimit=0 to specify no bandwidth limit.
 - Fix a bug when combining --delete-missing-args with --no-implied-dirs & -R
where rsync might create the destination path of a missing arg.
 - Fixed an issue where hard-linked devices could cause the rdev_major value to
get out of sync between the sender and the receiver.
 - Rsync now complains about a missing --temp-dir before starting any file
transfers.
 - A completely empty source arg is now a fatal error.

See full changelog: https://download.samba.org/pub/rsync/NEWS#3.2.3

Also, fix build issue with ACL option (patch is not required anymore)

PR:		248318 247795

- Fix fetch
- Fix license and add LICENSE_FILE
- Add missing dependency on liblz4
- Whitespace fixes
- Switch to options helpers

Approved by:	portmgr blanket

rsync: Unbreak and fix depends

rsync now depends on stuff in LOCALBASE. Previously, clang only needed to know
about LOCALBASE if POPT or ICONV was enabled. When those options are off, xxhash
and zstd were not found by configure.

Also, a depend on libssl was missing, and there were some noop reinplaces.

With hat: portmgr

rsync: Unbreak fetch

net/rsync upgrade to 3.2.2

Major changes and bugfixes:
 3.1.3 -> 3.2.0
 * Avoid potential out-of-bounds read in daemon mode
 * Fix defaul list list of skip-compress files for non-daemon transfers
 * Fix xattr filter rules losing an 'x' attribute in a non-local transfer
 * zlib fixes for CVE-2016-9843, CVE-2016-9842, CVE-2016-9841, and CVE-2016-9840
 * Fixed a crash in the --iconv code
 * Checksum enhancements, including the addition of xxhash
 * The checksum preference order of the negotiation can be customized or forced
 * Compression enhancements, including the addition of zstd and lz4 compression
algorithms
 * Added openssl & preliminary gnutls support to the rsync-ssl script
 * Added the proxy protocol daemon parameter that allows your rsyncd to know the
real remote
   IP when it is setup behind a proxy

Drop the ipv6 virtual category for n* category as it is not relevant anymore

Reorder the net/rsync ditfile sources to try HTTPS first.
Bump portrevision.

PR:		239096
Submitted by:	Miyashita Touka <imagin8r@protonmail.com>

Take maintenership and remove LOCAL/ehaupt/rsync from mirror list

net/rsync: Update to 3.1.3

Changelog:
 SECURITY FIXES:
    - Fixed a buffer overrun in the protocol's handling of xattr names and
      ensure that the received name is null terminated.
    - Fix an issue with --protect-args where the user could specify the arg in
      the protected-arg list and short-circuit some of the arg-sanitizing code.

  BUG FIXES:
    - Don't output about a new backup dir without appropriate info verbosity.
    - Fixed some issues with the sort functions in support/rsyncstats script.
    - Added a way to specify daemon config lists (e.g. users, groups, etc) that
      contain spaces (see "auth users" in the latest rsyncd.conf manpage).
    - If a backup fails (e.g. full disk) rsync exits with an error.

Release maintainer-ship.

- Add patches [1] to fix following security vulnerabilities:
  * CVE-2017-16548
  * CVE-2017-17433
  * CVE-2017-17434
- Bump PORTREVISION
- Move position of PORTREVISION in Makefile to fix portlint warning

PR:		224477
Submitted by:	yasu@utahime.org
Obtained from:	debian
MFH:		2017Q4 (blanket)

- Remove unavailable MASTER_SITES
- Add HTTPS alternatives by request [1], deliberately keep corresponding HTTP
  hosts for providing a variety of sources (not for integrity since this is
  guaranteed by the distinfo checksums)

PR:		221725 [1]
Submitted by:	xmj [1]

Include rrsync with net/rsync
This script can be used to restrict rsync to subdirectory declared in
~/.ssh/authorized_key
bump PORTREVISION

Approved by:	ehaupt (maintainer)
Differential Revision:	https://reviews.freebsd.org/D10851

Convert to options helper and test framework

Approved by:	portmgr (blanket)

Make ICONV a default option.

The iconv option is extremely useful, indeed necessary when exchanging files
with systems that have different encoding. This change does not require third-
party patches.

Discussed on:   ports
Suggested by:   Alan Braslau <alan.braslau@comcast.net> (via mail)

Use POPT_PORT_CONFIGURE_OFF instead of POPT_PORT_CONFIGURE_WITH_OFF.

Really fix popt option logic (real fix of r416270).

Notified by:	adamw

Fix the logic of the POPT_PORT option.

- POPT_CONFIGURE_WITH should actually be POPT_PORT_CONFIGURE_WITH
- The whole ^POPT block logic is reversing the logic
- Bump PORTREVISION since we have a change of dependencie

PR:		209837 (based on)
Submitted by:	Martin Birgmeier <la5lbtyi@aon.at>
MFH:		2016Q2

- Fix trailing whitespace in pkg-descrs, categories [g-n]*

Approved by:	portmgr blanket

Fix ICONV support.

PR:		208958
Submitted by:	mat
Reviewed by:	tijl
Approved by:	maintainer
Sponsored by:	Absolight

- Convert to new options helper

Approved by:	portmgr (blanket)

Fix building with iconv on 10.1 at least.

Sponsored by:	Absolight

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

Restore SIGINFO patch with new rsync version.

Notified by:	des

- Update to 3.1.2
- The non-default ATIMES option is now broken. Add a description and leave
  Makefile glue intact to give interested parties the chance to follow up with
  a patch.
- The popular SIGINFO patch does not apply anymore. Meanwhile, make it a
  non-default option and mark it broken in the description.

Changelog:      https://rsync.samba.org/ftp/rsync/src/rsync-3.1.2-NEWS

Provide a patch to show progress information when SIGINFO is caught. This
addition has been submitted upstream [1]:

https://bugzilla.samba.org/show_bug.cgi?id=11561

Apply an extra patch with the ACL option to add NFSv4 ACLs support [2].

Submitted by:   des [1]
Wished by:      Paul Lecuq <paul.lecuq@factorfx.com> [2]
Obtained from:  FreeNAS [2]

MASTER_SITES cleanup.

- Replace ${MASTER_SITE_FOO} with FOO.
- Merge MASTER_SITE_SUBDIR into MASTER_SITES when possible. (This means 99.9%
  of the time.)
- Remove occurrences of MASTER_SITE_LOCAL when no subdirectory was present and
  no hint of what it should be was present.
- Fix some logic.
- And generally, make things more simple and easy to understand.

While there, add magic values to the FESTIVAL, GENTOO, GIMP, GNUPG, QT and
SAMBA macros.

Also, replace some EXTRACT_SUFX occurences with USES=tar:*.

Checked by:	make fetch-urlall-list
With hat:	portmgr
Sponsored by:	Absolight

Move MASTER_SITES from CRITICAL to LOCAL/ehaupt

Remove @dirrm, @dirrmtry

Use install-strip install target instead of manual ${STRIP_CMD}

Allow specifying config path in rc.conf

PR:		191601
Submitted by:	daniel@blodan.se

Add USES=cpe (forgotten in previous commit)

Notified by:	mat

Add CPE definition.

Submitted by:	timur

Building rsync against zlib from base is NOT broken but leads to an unexpected
behaviour while using -z (see man page). Therefore remove the statement that
the option is broken but keep using the bundled zlib. Since this doesn't affect
package creation no PORTREVISION bump is required.

Bump revision after r359812 introduced a runtime fix

<OPT>_CONFIGURE_ARGS does not exists, fix

Unbreak build: Fix typo in popt library dependency (missing p character),
so that rsync actually finds a preinstalled libpopt.so if it is there.

Approved by:	portmgr (blanket "just fix it" approval)

Use OPTIONS helpers.

After the update from 3.1.0 to 3.1.1 the zlib from our base does not work
anymore (see thread on ports@). Until this this is resolved switch default
option to the bundled libz which still works. Also add a notification that
the option is broken. Should it not be possible to fix this within the next
few weeks I will remove this option.

Reported upstream:
https://bugzilla.samba.org/show_bug.cgi?id=10677

Reported by:	Ben Tung <benpptung@tacol.biz>

- Update to 3.1.1
- Remove the "Renamed and flags options combined" option as the 4th party patch
  does not apply anymore. The author of this patch has been notified about this
  circumstance. I happily re-add this option once a working patch exists.

- Turn file system flags support patch option on by default. FreeBSD has had
  flags since the very beginning, and they are actively used in the base
  system. A standard install includes 27 files and one directory with the schg
  flag set. Thus, rsync, out of the box, is incapable of making or restoring
  an accurate backup of a FreeBSD system.

- Move configuration directory from %%PREFIX%%/etc to %%ETCDIR%% and provide
  a start_precmd() rc.d function to migrate %%PREFIX%%/etc/rsyncd.conf to
  %%ETCDIR%%/rsyncd.conf if found and create a symlink. The reason behind this
  change is that rsyncd in a typical setup will end up with more than one
  configuration file (eg. rsyncd.secrets).

- Use new @sample pkg-plist macro

- Bump PORTREVISION

Discussed with: des

- Bump PORTREVISION after the latest change to converters/libiconv because
  rsync uses locale_charset when the ICONV option is enabled. [1]
- Replace CFLAGS+=-I... with CPPFLAGS+=-I... to fix warnings during
  configure about headers being accepted by the compiler but not the
  preprocessor.
- Replace CONFIGUREDCFLAGS (guard against CFLAGS damage by MAKE_ENV)
  with CPPFLAGS.  The dist makefile contains CFLAGS=@CFLAGS@ so CFLAGS
  in MAKE_ENV isn't a problem.
- Replace ac_cv_header_iconv_h=no with --disable-iconv-open.  The first
  disables HAVE_ICONV_H while the latter disables USE_ICONV_OPEN but both
  are checked in rsync.h:
  #if defined USE_ICONV_OPEN && defined HAVE_ICONV_H
- Set ac_cv_search_libiconv_open=no when empty(ICONV_LIB).  This prevents
  detection of libiconv when the ICONV option is disabled, but it is also
  needed on FreeBSD 10 with libiconv installed to prevent linking with
  -liconv.
- New LIB_DEPENDS syntax.
- Move pre-configure to post-patch.
- Remove malloc.h patching.
- Replace MAKE with MAKE_CMD.  MAKE is the currently running make and
  MAKE_CMD is the make used to build the port.
- Unmute installation commands.

Reported by:	"Kenta S." <kentas@hush.com> [1]
Approved by:	ehaupt

Now that this port is staged and DOCS defined we can stop testing for DOCS in
any install target.

Fix properties on pkg-plist

Add DOCS to OPTIONS_DEFINE as it is documented in the porters handbook.

Since the last update the RENAMED and FLAGS patch do not apply together anymore.
Dmitry Morozovsky has merged the two official patches. Provide an options for
the two combined patches.

Submitted by:	Dmitry Morozovsky <marck@rinet.ru>

Support staging.

PR:		183189
Submitted by:	mat

Re-add ICONV to OPTIONS_DEFINE. This went missing during the
update/OPTIONS_RADIO conversion.

Notified by:	mat

The previously introduced "fix" for the supposedly ignored --with-rsyncd-conf
configure option was bogus. The reason for it being ignored was a clobbered
CONFIGURE_ARGS definition (lack of +=).

Revert previous change and properly append later CONFIGURE_ARGS.

Notified by:    naddy

Provide a patch to workaround a problem with the configure script ignoring
--with-rsyncd-conf.

PR:		182596 (based on)
Submitted by:	Alexey Markov <redrat@mail.ru>

Actually remove files/extrapatch-detect-renamed.diff

- Update to 3.1.0
- Rework OPTIONS to use OPTIONS_RADIO for mutually exclusive options. This
  allows us to get rid of various IGNORE definitions
- Add an option to use zlib from base instead of the bundled one (default)
- Functionality of extrapatch-detect-renamed.diff has been incorporated with the
  upstream patch maintainers
- Provide a patch required for the "file system flags" option (have been
  submitted upstream)

Add NO_STAGE all over the place in preparation for the staging support (cat:
net)

Remove MAKE_JOBS_SAFE which is now default.

- Convert USE_ICONV=yes to USES=iconv
- Change USE_GNOME=pkgconfig|gnomehack to USES=pathfix|pkgconfig while here

Reviewed by:	zeising

Remove indefinite article from COMMENT

- Use DOC instead of NOPORTDOCS
- Pacify portlint
- Convert header

Provide an extra patch to for rsync to support overwriting files with schg set.
This patch is only applied if the FLAGS option is specified. The patch has been
submitted with the upstream project.

Notified by:	wblock
Obtained from:	https://bugzilla.samba.org/show_bug.cgi?id=8941 (upstream)

Restore 'Created by' header information. This has been removed during the
first announcement of the new trimming rule and the finalized overworked
version.

Feature safe:   yes

Fix a condition to correctly check whether the SSH option is used. This error
slipped in when the port was converted to OPTIONSng.

Notified by:	Norbert Augenstein <lists@augenstein.net>

- Use OPTIONSng
- Remove deprecated header information

Move the rc.d scripts of the form *.sh.in to *.in

Where necessary add $FreeBSD$ to the file

No PORTREVISION bump necessary because this is a no-op

Provide an improved version of the "renamed file detection" patch.

This patch was submitted to the upstream project [1] and will hopefully be
included in the next release.

With the new patch, detect-renamed properly detects files moved to new
directories, as well as directory renames.

[1] https://bugzilla.samba.org/show_bug.cgi?id=8847

Submitted by:   J.R. Oldroyd <jr@opal.com>
Obtained from:  rsync bugzilla [1]

Turn off non standard patch (RENAMED) by default. This slipped in on accident
from testing.

Notified by:    sunpoet
Feature safe:   yes

Introduce an option that builds rsync with the "detect-renamed" patch. It
detects renamed hierarchies and avoids re-copying the files in those
hierarchies.

Requested by:   "J.R. Oldroyd" <jr@opal.com> (via mail)
Feature safe:   yes

In the rc.d scripts, change assignments to rcvar to use the
literal name_enable wherever possible, and ${name}_enable
when it's not, to prepare for the demise of set_rcvar().

In cases where I had to hand-edit unusual instances also
modify formatting slightly to be more uniform (and in
some cases, correct). This includes adding some $FreeBSD$
tags, and most importantly moving rcvar= to right after
name= so it's clear that one is derived from the other.

Update to 3.0.9

- Add LDFLAGS to CONFIGURE_ENV and MAKE_ENV (as it was done with LDFLAGS)
- Fix all ports that add {CPP,LD}FLAGS to *_ENV to modify flags instead

PR:             157936
Submitted by:   myself
Exp-runs by:    pav
Approved by:    pav

Update to 3.0.8

Add LICENSE and remove MD5 sums.

Feature safe:   yes

Remove dead mirror

Begin the process of deprecating sysutils/rc_subr by
s#. %%RC_SUBR%%#. /etc/rc.subr#

Update to 3.0.7