treewide: Remove references to USES= fam and move to LIB_DEPENDS

Only a handful of ports in tree uses this helper which
used to make a switch between devel/fam and devel/gamin more
convenient. With devel/fam going away there's no need to maintain
this any further for a handful of ports.

Approved by:	blanket

net/samba422: Fix plist for MANPAGES=off BUNDLED_TALLOC=on

PR:		291831
Reported by:	intellisun@gmail.com

net/samba422: Fix pkg-plist for option CLUSTER

    ===> Checking for items in STAGEDIR missing from pkg-plist
    Error: Orphaned: @dir var/lib/ctdb/persistent
    Error: Orphaned: @dir var/lib/ctdb/state
    Error: Orphaned: @dir var/lib/ctdb/volatile
    Error: Orphaned: @dir var/log
    Error: Orphaned: @dir var/run/ctdb
    ===> Checking for items in pkg-plist which are not in STAGEDIR
    Error: Missing: @dir /var/lib/ctdb/persistent
    Error: Missing: @dir /var/lib/ctdb/state
    Error: Missing: @dir /var/lib/ctdb/volatile
    Error: Missing: @dir /var/lib/ctdb
    Error: Missing: @dir /var/lib
    Error: Missing: @dir /var/run/ctdb

Also, address the problem with an symlink pointing to an absolute path:

    Warning: Bad symlink '/usr/local/etc/ctdb/statd-callout' pointing to an
absolute pathname '/usr/local/libexec/ctdb/statd_callout'

PR:             291104
Reported by:    vvd

samba: Remove MEMORY_DEBUG_IMPLIES=DEBUG

There is no DEBUG option, so this assignment does not make
any sense.

net/samba422: OPTIONify handling bundled dependencies and lint

Before this commit, users could control whether to bundle cmocka, TDB,
Tevent, and talloc by setting an appropriate WITH_BUNDLED_* variable
to "yes". Let's transition to OPTIONS instead so that it's easier to
track the actual port configuration by taking a look at the options,
e.g., with make showconfig.

Additionally, the makefile itself requires less if statements.

While here, lint with portclippy --strict.

net/samba422: Refactor handling of SAMBA4_PRIVATE_LIBS, SAMBA4_BUNDLED_LIBS, and
SAMBA4_MODULES

net/samba422: Simplify handling of SAMBA4_BUNDLED_*

Check if SAMBA4_BUNDLED_* variables are set to either "yes" or "no" once
to avoid having to check if they are defined over and over.

net/samba422: Set TEST_ENV with = instead of +=

"+=" may suggest that we are appending to the default value of TEST_ENV.
This is not true. Use "=" to be explicit about the intent.

net/samba422: Remove redundant LDAP_CONFIGURE_* variables

net/samba422: CLUSTER: Add missing dependency net/libpcap

    Error: /usr/local/bin/ctdb is linked to /usr/local/lib/libpcap.so.1 from
net/libpcap but it is not declared as a dependency
    Warning: you need LIB_DEPENDS+=libpcap.so:net/libpcap

PR:		291104
Reported by:	vvd

net/samba422: Add 95.database.script to post-install-CLUSTER-on

====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/etc/ctdb/events/legacy/95.database.script'
pointing to an absolute pathname
'/usr/local/share/ctdb/events/legacy/95.database.script'

PR:		291104
Reported by:	vvd

net/samba422: Fix pkg-plist.cluster

PR:		291104
Reported by:	vvd

net/samba422: Fix pkg-plist when TDB is bundled

PR:	291104

net/samba422: Use SAMBA4_SUB for bundled dependencies as well

net/samba422: Add a missing dependency: ncurses

This should address the following errors:

    Error: /usr/local/bin/samba-regedit is linked to /usr/local/lib/libform.so.6
from devel/ncurses but it is not declared as a dependency
    Warning: you need USES+=ncurses
    Error: /usr/local/bin/samba-regedit is linked to
/usr/local/lib/libncurses.so.6 from devel/ncurses but it is not declared as a
dependency
    Warning: you need USES+=ncurses
    Error: /usr/local/bin/samba-regedit is linked to
/usr/local/lib/libtinfo.so.6 from devel/ncurses but it is not declared as a
dependency
    Warning: you need USES+=ncurses
    Error: /usr/local/bin/samba-regedit is linked to
/usr/local/lib/libpanel.so.6 from devel/ncurses but it is not declared as a
dependency
    Warning: you need USES+=ncurses

net/samba422: Sort and clean up targets

net/samba422: Address the last portclippy warning

net/samba422: Introduce a TEST option

This way we can handle test-specific build and run dependencies.

net/samba422: Introduce option DEVELOPMENT

DEVELOPMENT is a group option for all the testing, debugging, and
development options offered by Samba.

While here, sort related variables.

net/samba422: Move most *_DEPENDS where they belong

No functional changes intended.

net/samba422: Sort some more variables

No functional changes intended.

net/samba422: Refactor handling of FRUIT and GLUSTERFS manuals

net/samba422: Clean up handling of Python bindings

No functional changes intended.

net/samba422: Use GSSAPI_MIT_PLIST_FILES instead of if statements

net/samba422: Remove remaining bits of GSSAPI_HEIMDAL support

The option is not even present currently, so remove unused code.

net/samba422: Set ADS' SAMBA4_MODULES via ADS_VARS

net/samba422: Standardize check if AD_DC is disabled when ADS is disabled

Use AD_DC_IMPLIES=ADS instead of:

    .if !${PORT_OPTIONS:MADS} && ${PORT_OPTIONS:MAD_DC}
    IGNORE=To disable ADS option you also need to disable AD_DC option
    .endif

net/samba422: Finish removal of the LIBZFS option

The option is no longer present in the port, so remove any lingering
variables we no longer need.

net/samba422: Fix plist entries for AD_DC=off

Some of the .so files that we assumed are AD_DC-specific are installed
also when AD_DC is off. Fix that.

PR:	291541

net/samba422: Do not check for Python in pre-configure

The port is already using AD_DC_IMPLIES=PYTHON3 to require Python when
the AD_DC option is on.

net/samba422: Remove the NO_PYTHON knob

Users should use the PYTHON3 option to disable Python.

net/samba422: Fix location of ldb files

- Use SAMBA_LDB_MODULESDIR consistently
- Move all AD_DC-related plist entries to pkg-plist.ad_dc

This patch fixes a simple "make package" build with default options.

PR:		291541
Reported by:	O. Hartmann <ohartmann@walstatt.org>
Sponsored by:	Klara, Inc.

net/samba422: Add missing bison dependency to GSSAPI_MIT

net/samba422: Sort options variables

No functional changes.

net/samba422: Do not set WRKSRC needlessly and explain PLIST assignment

We need to set PLIST explicitly here because we use

    <OPTION>_VARS=PLIST+=pkg-plist.<option>

to append more files to PLIST. Everything works as expected.

net/samba422: Guard some plist entries with %%AD_DC%%

This fixes the following "package" phase errors:

    ===>  Building packages for samba422-4.22.6
    ===>   Building samba422-4.22.6
    pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/asq.so:No such
file or directory pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/ildap.so:No such
file or directory pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/ldb.so:No such
file or directory pkg-static: Unable to access file
   
/p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/ldbsamba_extensions.so:No
such file or directory pkg-static: Unable to access file
   
/p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/paged_searches.so:No
such file or directory pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/rdn_name.so:No
such file or directory pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/sample.so:No
such file or directory pkg-static: Unable to access file
   
/p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/server_sort.so:No
such file or directory pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/skel.so:No such
file or directory pkg-static: Unable to access file
    /p/net/samba422/work/stage/usr/local/lib/samba4/modules/ldb/tdb.so:No such
file or directory
    *** Error code 1

The commit message was written by 0mp.

PR:	291509 291516

net/samba422: Update to 4.22.6

PR:		290424
Changes:	https://wiki.samba.org/index.php/Samba_4.22_Features_added/changed#Samba_4.22.6
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D54139

net/samba422: Fix USES=cpe and incorporate USES=samba:self

USES=cpe has not been working as it was overwritten by another
assignment of USES later in the file. Fix that by merging those two USES
assignments into one.

Add USES=samba:self, so that we can depend on the directory paths
defined in samba.mk.

PR		290424
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D54137

net/samba422: Make ADS option imply LDAP option

If ADS option is on and LDAP option is off, build fails at configure
phase as below.

need ber_sockbuf_add_io() and LDAP_OPT_SOCKBUF for SASL and TLS support
Active Directory support not available: LDAP support is not available.
Active Directory support not found. Use --without-ads for building without
Active Directory support. ADS support improves communication with Active
Directory domain controllers.
(complete log in
/wrkdirs/usr/ports/net/samba422/work/samba-4.22.3/bin/config.log)
===>  Script "configure" failed unexpectedly.
Please report the problem to samba@FreeBSD.org [maintainer] and attach the
"/wrkdirs/usr/ports/net/samba422/work/samba-4.22.3/bin/config.log" including
the output of the failure of your make command. Also, it might be a good idea
to provide an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).

net/samba422: Fix plist error after commit 6c23ee846dd4

After commit 6c23ee846dd4 plist error happens with default options
setting as below.

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/samba4/modules/ldb/ldap.so
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/net/samba422

While here, use %%SAMBA4_MODULEDIR%% for path of
lib/samba4/modules/ldb/ldap.so and sort plist.

Fixes:	6c23ee846dd4 net/samba422: Fix plist when AD_DC and LDAP are OFF

net/samba422: Fix pkg-plist when building without PYTHON3

The build fails at the packaging step because it tries to
include a file that doesn't exist without PYTHON3.

PR:		290439
Reported by:	Toshimichi Masubuchi
Sponsored by:	Klara, Inc. (0mp)
Co-authored-by:	Toshimichi Masubuchi <t.masub@gmail.com>

net/samba422: Fix plist when AD_DC and LDAP are OFF

PR:		290441
Reported by:	Trond Endrestøl
Sponsored by:	Klara, Inc. (0mp)
Co-authored-by:	Trond Endrestøl <Trond.Endrestol@ximalas.info>

net/samba422: Do not keep ldb private

Since version 4.22, Samba requires ldb to be bundled. This is
problematic for packaging because ldb is also used by ports such as
security/sssd2. In the past, we used a standalone ldb port to address
that.

Luckily, it turns out that Samba can turn its private libraries into
public ones via its configure script. This commit makes Samba's ldb
public.

PR:		289272
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D52377

net/samba422: Update to 4.22.3

Most of this patch is Andrej Ebert's work. I fixed some of the remaining
issues and prepared it for landing in the ports tree under sponsorship
from Klara, Inc.

Changes in the port include:

- There's an unconditional dependency on devel/icu now,
  since Samba pulls it in if it's in the build environment and
  complains afterwards if icu is bumped without a Samba rebuild.

- Remove GSSAPI Builtin converters/p5-JSON build dependency,
  it's not needed since 4.20 as per upstream:
  https://www.samba.org/samba/history/samba-4.20.0.html

net/samba422: Repocopy from net/samba420

PR:		287985
Reported by:	Andrej Ebert <andrej@ebert.su>
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D52167