security/fwbuilder: Remove expired port

2023-09-30 security/fwbuilder: Abandonware since Jan 2021

security/fwbuilder: Deprecate abaondonware

fwbuilder fails to build for many errors due to enforced C++17
standard, i.e. throw. In addition, fwbuilder was abandoned by its
original author when he got a job with a firewall company. Since
then it's maintenance was assumed by someone on github. Unfortunately,
he made a few tweaks but failed to make any other commits since
January 2021. Therefore this port is flagged as broken under 14-CURRENT
and deperecated. It will be removed at the end of 2023Q3.

I had stopped using this port a few years ago because it didn't support
IPv6. I was hoping whoever did take on upstream maintainership on GH
would implement IPv6 support. But they didn't. Therefore I am dropping
maintainership as well.

security/fwbuilder: Point to new WWW on github

Mk/Uses: always use colon for build/run suffix

Most USES use a colon for build/run(/test) suffixes. Change kde.mk,
qt.mk and pyqt.mk to do the same, and update all ports using that.

Document in CHANGES.

PR:			266034
Exp-run by:		antoine
Approved by:		tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D36349

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

security: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  <ports@c0decafe.net>
  *  Aaron Dalton <aaron@FreeBSD.org>
  *  Adam Weinberger <adamw@FreeBSD.org>
  *  Ade Lovett <ade@FreeBSD.org>
  *  Aldis Berjoza <aldis@bsdroot.lv>
  *  Alex Dupre <ale@FreeBSD.org>
  *  Alex Kapranoff <kappa@rambler-co.ru>
  *  Alex Samorukov <samm@freebsd.org>
  *  Alexander Botero-Lowry <alex@foxybanana.com>
  *  Alexander Kriventsov <avk@vl.ru>
  *  Alexander Leidinger <netchild@FreeBSD.org>

*/*: Remove redundant '-*' from CONFLICTS definitions

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

*: fix tab vs. space issues, and comments according to the guide.

cleanup: drop support for EOL FreeBSD 11.X

Search criteria used:
- 11.4
- OSREL*
- OSVER*
- *_FreeBSD_11

Input from:
- adridg: devel/qca-legacy
- jbeich: _WITH_DPRINTF, _WITH_GETLINE, GNU bfd workarounds
- sunpoet: security/p5-*OpenSSL*

Reviewed by:	doceng, kde, multimedia, perl, python, ruby, rust
Differential Revision: https://reviews.freebsd.org/D32008
Test Plan: make index

Remove # $FreeBSD$ from Makefiles.

Unmark certain ports as broken on powerpc64 elfv2, after a trybroken run.

(Note that these have not yet been re-tested on elfv1.)

While here, pet portlint (e.g. location of BROKEN_*, and, in one case,
USES).

Approved by:	portmgr (tier-2 blanket)

Fix Qt5 symbol version scripts to put the catch-all clause first.  When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call

Add missing qt5 dependency.

Reported by:	pi@
MFH:		2019Q1

Add QT5 buildtools to the mix.

Fix USE_GITHUB usage.

Problem:
	QT4 support is deprecated and will be removed in March 2019.
	fwbuilder upline is no longer supported.

Solution:
	Use the fwbuilder fork on github. This:
	- updates fwbuilder from 5.1.0 to 5.3.7.
	- uses QT5.
	- is supported.

Mark QT4 ports/functionality for removal on 2019-03-15

While here, chase some KDE4 ports and functionality, these are scheduled for
removal on 2018-12-31. Change the default option/flavor to QT5 where applicable
or use alternative toolkits like GTK.

Submitted by:	tcberner
Reviewed by:	adridg, jhale, rene, tcberner
Approved by:	portmgr (implicit, flavor hook)
Differential Revision:	https://reviews.freebsd.org/D17741

Add DOCS options to ports that should have one.

Also various fixes related to said option.

PR:		230864
Submitted by:	mat
exp-runs by:	antoine

Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk

From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	-https://reviews.freebsd.org/D15540

Mark as broken on powerpc64.

While here, pet portlint.

Approved by:	portmgr (tier-2 blanket)

clang 6 is full of surprises. Fix build on 12-CURRENT 1200056.

Make defining both PORTVERSION and DISTVERSION a DEV_ERROR.

There are two cases:

- The upstream versionning is compatible with our versionning, or using
  DISTVERSION's magic leads to a compatible PORTVERSION, use
  DISTVERSION.  If it is possible to use DISTVERSIONPREFIX and
  DISTVERSIONSUFFIX to make it compatible, use them.
- The upstream versionning is not compatible with our versionning, and
  DISTVERSION's magic does not lead to a correct PORTVERSION, then set
  PORTVERSION to the equivalent of our versionning, and set DISTNAME.
  It is possible to use a third variable where you store upstream's
  version and use it to compute PORTVERSION and/or DISTNAME, like the
  dns/bind9* ports do.

Sponsored by:	Absolight

Remove all USE_OPENSSL occurrences.

Sponsored by:	Absolight

Get rid of QT_PREFIX in favour of PREFIX.

QT_PREFIX was a remnant of a bygone time.

Reviewed by:    rakuco
Approved by:    rakuco (mentor)
Differential Revision:  https://reviews.freebsd.org/D8825

security/fwbuilder: Fix bad RUN_DEPENDS specification for rcs

The fwbuilder makefile specifies devel/rcs as a run dependency for
FreeBSD 10 and later, but the specification is ignored on a stock
FreeBSD 10.3 installed from an ISO.  At some point rcs was removed
before FreeBSD-10 release, but it seems to have been put back and
controlled with a build knob, so it may or may not be present on
FreeBSD 10 or later.

Change the test from checking OSVERSION to checking for the existence
of /usr/bin/rcs.  It's a better chek and it fixes a potential dependency
mismatch issue between the port and the built package.

While here, change RUN_DEPENDS= to RUN_DEPENDS+= to avoid a potential
overwrite of existing values.

Approved by:	infrastructure blanket (redundant deps work)

- Fix trailing whitespace in pkg-descrs, categories [p-x]*

Approved by:	portmgr blanket

Remove ${PORTSDIR}/ from dependencies, categories r, s, t, and u.

With hat:	portmgr
Sponsored by:	Absolight

Run included autogen.sh instead of autoreconf because it will also copy
config.sub and config.guess

Reported by:	antoine

Modernise configure.in

Reported by:	antoine

Convert to USES=autoreconf

Remove OSVERSION checks that do not make sense any more.

For example (${OSVERSION} >= 900000 && ${OSVERSION} < 900021) is always true,
as is (${OSVERSION} > 900002 || ${OSVERSION} < 900000 && ${OSVERSION} > 800107).

Regarding patches, when an EXTRA_PATCHES is no longer needed, I remove it, when
it is always needed, I renamed it, in one case, I merged two patches.

Differential Revision:	https://reviews.freebsd.org/D2209

Cleanup plist

Rename security/ patches to reflect the files they modify.

Remove NOPORTDOCS and NOPORTEXAMPLES.

Unbreak

Stagify. Modernize.

- Convert gmake, bzip2 to USES

Approved by:	portmgr

- Remove manual creation and removal of share/applications, as it's now in the
mtree (categories starting with [st])

Approved by:	portmgr (bdrewery)

r329531 makes this patchfile unnecessary.

With the impending removal of rcs from base/head/, add new rcs 5.7 port
which is compatible with the soon to be removed rcs (5.7) in base/ and make
security/fwbuilder (which will not work with any rcs newer than 5.7)
depend on it.

Add NO_STAGE all over the place in preparation for the staging support (cat:
security)

On installations that have devel/rcs (GNU rcs) installed, fwbuilder fails
to check in udates to its .fwb files (they are saved but not checked into its
RCS database). This patch prefers rcs in base (/usr/bin/rcs) over GNU rcs
(/usr/local/bin/rcs).

- Convert USE_QT_VER=4 and QT_COMPONETS to USE_QT4

Review by:      bapt, David Naylor (kde team)

- update png to 1.5.10

Update 5.0.1 ---> 5.1.0

Update 5.0.0 --> 5.0.1

Feature safe:   yes

Adjust -devel bits for use in -devel version of this port.

Feature safe:   yes

Set default DEVEL option (documentation).

Add version 4 to conflicts.

Adjust version 5 nightly builds URL for devel version of this Makefile.

Feature safe:   yes

Update 4.2.2 --> 5.0.0

Feature safe:   yes

- Add LDFLAGS to CONFIGURE_ENV and MAKE_ENV (as it was done with LDFLAGS)
- Fix all ports that add {CPP,LD}FLAGS to *_ENV to modify flags instead

PR:             157936
Submitted by:   myself
Exp-runs by:    pav
Approved by:    pav

Now builds under 9.0-CURRENT.

- Chase net-snmp shlib version bump.

Update 4.2.1 --> 4.2.2. This is a bugfix release.

Notified by:    Vadim Kurland <vadim@netcitadel.com> (Fwbuilder upline)

Update 4.2.0 --> 4.2.1. This is a bugfix release.

Notified by:    Vadim Kurland <vadim@netcitadel.com> (Fwbuilder upline)

Fix build on AMD64. Debugging information caused failure on pointyhat due
to ulimit. Rremoval of debugging information reduces the size of a static
library file by 80%.

Discovered by:  pointyhat on amd64 8

Update 4.1.3 --> 4.2.0.

Libfwbuilder has been merged into fwbuilder.

Update 4.1.2 --> 4.1.3

Sync to new bsd.autotools.mk

Punt autoconf267->autoconf268

Update 4.1.1 --> 4.1.2

Round one migration of ports from automake{19,110} to automake111

Autotools update.   Read ports/UPDATING 20100915 for details.

Approved by:    portmgr (for Mk/bsd.port.mk part)
Tested by:      Multiple -exp runs

Update 4.0.1 --> 4.1.1

Fix build error.

Update 4.0.0 --> 4.0.1.

Fix an autotools dependency issue.

Thans to Mike Harding <mvharding@gmail.com> for allowing me to use one of his
systems to debug this problem.

Add AUTOTOOLS dependency when using packages as opposed to ports
to satisfy dependencies.

Resolve autotools issue.

Thanks to:      pointyhat

Update 3.0.7 --> 4.0.0.

- update to 1.4.1
Reviewed by:    exp8 run on pointyhat
Supported by:   miwi

- Mark BROKEN on HEAD: fails to build with new utmpx

Reported by:    pointyhat

Incorporate a fix for fwbuilder commit #2844561 which introduced a bug
when generating IP Filter statements for bi-directional filtering.

Update 3.0.5 --> 3.0.7 which fixes a security issue with generated iptables
scripts when used to generate static routing configurations.

Feature safe:   Yes

- Switch SourceForge ports to the new File Release System: categories starting
with P,R,S

Author re-released 3.0.5 based on build 1116 to fix a small last minute bug.

PR:             136167

Update 3.0.4 --> 3.0.5

PR:             135924

Fix QT4 dependencies

PR:             134904
Submitted by:   makc

Update from build 778 to build 793. This fixes PR 134178.

PR:             134178

Update to 3.0.4.

Update to 3.0.3 (release, aka build 688).

Update to 3.0.3 Build 687.

Update 3.0.2 Build 676 to 3.0.3 Build 683 (3.0.3 prerelease) to fix an
IPv6 address issue in address and network objects.

- Clean up shared directory share/applications

Reported by:    pointyhat

Update to 3.0.2 Build 676. This repairs PR 129204.

PR:             129204

Update 3.0.0 --> 3.0.2

Add qt4-rcc as a prerequisite.

Fixup CONFLICTS and dependencies.

Fix configure brokenness.

Submitted by:   gahr
Approved by:    portsmgr (pav)

Display a message suggesting that users back up their fwbuilder database
files prior to invoking fwbuilder after an upgrade.

Welcome fwbuilder and libfwbuilder 3.0.0, replacing 2.1.19. The old version
is deprecated and scheduled for deletion as it is no longer supported by its
author.

Update CONFIGURE_ARGS for how we pass CONFIGURE_TARGET to configure script.
Specifically, newer autoconf (> 2.13) has different semantic of the
configure target. In short, one should use --build=CONFIGURE_TARGET
instead of CONFIGURE_TARGET directly. Otherwise, you will get a warning
and the old semantic may be removed in later autoconf releases.

To workaround this issue, many ports hack the CONFIGURE_TARGET variable
so that it contains the ``--build='' prefix.

To solve this issue, under the fact that some ports still have
configure script generated by the old autoconf, we use runtime detection
in the do-configure target so that the proper argument can be used.

Changes to Mk/*:
 - Add runtime detection magic in bsd.port.mk

Bump portrevision due to upgrade of devel/gettext.

The affected ports are the ones with gettext as a run-dependency
according to ports/INDEX-7 (5007 of them) and the ones with USE_GETTEXT
in Makefile (29 of them).

PR:             ports/124340
Submitted by:   edwin@
Approved by:    portmgr (pav)

NOPORTDOCS (r1.41) is not supported by the base release of fwbuilder.
Mark the port BROKEN when NOPORTODOCS is specified.

Update 2.1.17 --> 2.1.19

Update 2.1.16 --> 2.1.17

PR:             122472
Submitted by:   "Beat G\xe4tzi" <beat@chruetertee.ch>

- Chase shlib version of net-mgmt/net-snmp.
- Bump PORTREVISIONs.

- Remove USE_GETOPT_LONG which is a no-op since March 2007

Update 2.1.14 --> 2.1.16

[PATCH] security/fwbuilder: cleanup non-supported FreeBSD versions

        - removed support to 4.X (EOL)
        - add correct NOPORTDOCS

PR:             ports/111822
Submitted by:   Marcelo Araujo <araujo@bsdmail.org>
Approved by:    maintainer timeout