security/putty: SECURITY update to 0.81

This fixes a vulnerability where NIST P521 ecdsa-sha2-nistp521 (only!)
keys can be recovered easily because signature generation in PuTTY used
a biased random number generator.

MFH:		2024Q2
Security:       080936ba-fbb7-11ee-abc8-6960f2492b1d
Security:       CVE-2024-31497

*/*: Bump consumers of x11-toolkits/gtk30

New version of gtk3 in tree

security/putty: security update → 0.80 to fix Terrapin vulnerability

Note this requires the server side to also add the protocol extension.

Security:	91955195-9ebb-11ee-bc14-a703705db3a6
Security:	CVE-2023-48795
Changelog:	https://lists.tartarus.org/pipermail/putty-announce/2023/000037.html
MFH:		2023Q4

security/putty: update → 0.79

ChangeLog: 	https://lists.tartarus.org/pipermail/putty-announce/2023/000036.html
MFH:		2023Q3

accessibility/at-spi2-core: update to 2.46.0

What's new in at-spi2-core 2.46.0:
* Fix GetInterfaces documentation on org.a11y.atspi.Accessible
  interface.

What's new in at-spi2-core 2.45.91:
* Send device event controller events using the same signature as other
  events.
* Document the Accessible, Action, and Cache dbus interfaces.
* Fix license of atspi-gmain.c (#87).

What's new in at-spi2-core 2.45.90:
* xml: Add some documentation.
* xml: Fix event arguments.

security/putty: update to 0.78 release

FreeBSD relevant changes since 20221023 snapshot:

* f9a8213d 2022-10-29 | Docs: add a 'pdf' cmake target. (origin/main,
origin/HEAD) [Jacob Nevins]
* 4ff82ab2 2022-10-28 | Update version number for 0.78 release. (tag: 0.78)
[Simon Tatham]
* 475c2387 2022-10-28 | Unix: stop accessing ctrl->fileselect for font
selectors. [Simon Tatham]
* 329a4cdd 2022-10-24 | authplugin-example.py: Flush stderr. [Jacob Nevins]
* 538c8fd2 2022-10-24 | authplugin-example.py: Mention documentation. [Jacob
Nevins]
* a7106d8e 2022-10-23 | Add missing initialisation of term->osc_strlen. [Simon
Tatham]
* bdb3ac9f 2022-10-23 | Restrict -pwfile / -pw to apply to server prompts only.
[Simon Tatham]
* 2fbb9284 2022-10-23 | Fix outdated comment relating to -pw. [Jacob Nevins]
* f7e86ca2 2022-10-22 | README: remove mention of doc/Makefile. [Jacob Nevins]
* f229aab2 2022-10-23 | Rewrap a paragraph in README. [Jacob Nevins]

MFH:		2022Q4 (after 10 days)

According to Simon, he caught this assertion error in the act,
and 475c2387 should fix
PR:		267253

security/putty: update to snapshot 20221023

FreeBSD-relevant changes since previous snapshot:
* 75ac4443 2022-10-22 | Document subdomain matching of cert expr wildcards.
[Jacob Nevins]
* 500568d2 2022-10-22 | Docs: fix trivial typo from 6472f7fc77. [Jacob Nevins]
* 5f3b743e 2022-10-21 | Tweak certified-host-key prompt. [Jacob Nevins]
* bb1ebc9b 2022-10-21 | Docs: tweak certified-host-key warning responses. [Jacob
Nevins]
* 5716c638 2022-10-21 | Docs: cross-reference host-key warning sections. [Jacob
Nevins]
* 8c534c26 2022-10-21 | Docs: note "wrong host key" warning is stronger. [Jacob
Nevins]
* 1d1d81d6 2022-10-21 | Fix regressions in Gtk host key "More info". [Jacob
Nevins]
* dc9ab5e0 2022-10-21 | Rename NTRU Prime / Curve25519 kex in UI. [Jacob Nevins]
* 6472f7fc 2022-10-21 | Docs: update Pageant key list description. [Jacob
Nevins]
* 5d5a6a8f 2022-10-21 | Docs: MD5 is forced for SSH-1 key fingerprints. [Jacob
Nevins]
* d4298308 2022-10-21 | Docs: prime generation defaults are usually fine. [Jacob
Nevins]
* 2b5b7b5c 2022-10-21 | Docs: note warning about <2048-bit RSA/DSA keys. [Jacob
Nevins]

security/putty: fix ARM NEON AES-GCM code

Cherry-pick a test patch from upstream maintainer:

- this uses fallback code for compilers not providing vaddq_p128
  (f.i. clang-10 on FreeBSD 12.3 AMD64/aarch64)
- and uses vaddq_p128 on systems that provide it, for instance,
  FreeBSD 13-STABLE AMD64/aarch64 with clang 14.0.5

Obtained from:	Simon Tatham
MFH:		2022Q4

security/putty: fix aarch64 build on clang 10.

clang 10 (FreeBSD 12.3) does not support vaddq_p128 and similar
ARM NEON intrinsics, but clang 13 (FreeBSD 13.1) does.

Abuse the HAVE_NEON_PMULL cmake test to disable aesgcm-neon.c
unless vaddq_p128() is available.

http://ampere1.nyi.freebsd.org/data/123arm64-quarterly/31229ca1324c/logs/putty-nogtk-0.78~pre20220922.log:
/wrkdirs/usr/ports/security/putty-nogtk/work/putty-0.78~pre20220922.9fcfd67/crypto/aesgcm-neon.c:125:16:
warning: implicit declaration of function 'vaddq_p128' is invalid in C99
[-Wimplicit-function-declaration]
	ctx->acc = vaddq_p128(ctx->acc, load_p128_be(coeff));

security/putty: update to 0.78~pre20220922

This permits a FreeBSD build without patches; the two remaining
items are 1. avoiding the GSSAPI-related call into pkg-config because it
would not cover base-GSSAPI so we force the fallback to krb5-config
(which we control by way of ports/Mk/Uses/gssapi.mk), and
2. making sure PuTTY's build would not ascend directory hierarchy to
pick up our ports tree's Git information. We are only packaging
(pre-)release tarballs where we do not need to run Git.

Thanks to Simon Tatham, upstream maintainer, for issuing the
pre-releases and being very responsive and open to making the
build experience smooth for everyone.

security/putty: add Git patch to fix X11 inclusion

Pull in a fix from upstream's Git to avoid pulling in X11 headers
in no-GTK builds, so we can remove one more local workaround.

security/putty: Update to pre20220919 + 2 Git patches

This allows us to remove all local patch files.

security/putty: permanently remove GSSAPI_DYNAMIC

While it seems a nice idea to load the GSS provider library at run-time,
the existing search code hardwires library versions and only works
with krb5 (MIT Kerberos), and does not attempt to control library paths.

This sort of defeats the purpose, and we do not need a brittle
alternative for a robust GSSAPI_MIT.

So, drop the commented-out GSSAPI_DYNAMIC stuff from the Makefile.

security/putty: Pick right Kerberos version

Make sure that putty only compiles and links against the configured
static GSSAPI version, especially against base even if krb5 or heimdal
are installed.

To that end, hand down the right krb5-config executable,
and punch out pkg-config from the shipped unix.cmake.

security/putty*: clean up options and patches

security/putty: Fix static GSSAPI solutions,

with a patch received from Simon Tatham, and mask GSSAPI_DYNAMIC
for now, because it is not working. Debugging going on, but let's
get GSSAPI working at all for now, and make GSSAPI_BASE the default.

security/putty: upgrade to pre-release 0.78~pre20220916.e1b73f0

ChangeLog: https://lists.tartarus.org/pipermail/putty-announce/2022/000034.html

Please test this thoroughly and if you happen to have a Kerberos-
or GSSAPI-enabled SSH server, please give the maintainer feedback
whether GSSAPI works for you and which GSSAPI library you have
installed.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

cleanup: remove trailing whitepaces

security/putty: update to 0.77

PuTTY 0.77 changed its build system to cmake, and restructured the
source code, thus the patches were regenerated and updated.

As a consequence, GSSAPI_BASE no longer works because cmake wants
pkg-config and hence .pc files.

GSSAPI_HEIMDAL does not compile due to #define (&_foo) xxx.
Both GSSAPI_BASE and GSSAPI_HEIMDAL were disabled. Assistance solicited.

There is a new experimental GSSAPI_DYNAMIC which permits configuring the
GSS provider at run-time, which the package maintainer cannot test
for lack of Kerberized access somewhere. Feedback solicited.

*/*: Remove redundant '-[0-9]*' from CONFLICTS_INSTALL

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

security/putty: Fix CPE information because current one is deprecated

Approved by:    portmgr (blanket)

security/putty: update to 0.76.

FreeBSD relevant changes per
https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

+ New option to abandon an SSH connection if the server allows you to
  authenticate in a trivial manner.
+ Bug fix: user colour-palette reconfiguration via 'Change Settings'
  were delayed-action.
+ Bug fix: server colour-palette reconfigurations were sometimes lost.
+ Bug fix: a tight loop could occur on reading a truncated private key
  file.

security/putty: update to 0.75

https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

Deprecate -gtk2 version for Mid-December 2021.

Clean up a bit.

One more small cleanup, forgotten yesterday.
Reported by:	lwhsu

Remove # $FreeBSD$ from Makefiles.

security/putty*: take LICENCE file from extracted source,

...rather than copying it into $FILESDIR where it would require
maintenance.

Reported by:	danfe@

security/putty*: rename and update LICENCE from tarball.

security/putty*: rename and update LICENCE from tarball.

security/putty*: upgrade to 0.74 security fix release

Changelog:
https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

among them are these two---and more bugfixes beyond not listed here:

  * Security fix: if an SSH server accepted an offer of a public key
    and then rejected the signature, PuTTY could access freed memory,
    if the key had come from an SSH agent.

  * Security feature: new config option to disable PuTTY's dynamic
    host key preference policy, if you prefer to avoid giving away
    to eavesdroppers which hosts you have stored keys for.

MFH:		2020Q2
Security:       6190c0cd-b945-11ea-9401-2dcf562daa69
Security:       CVE-2020-14002
Security:       FZI-2020-5

WWW/DL link maintenance in pkg-descr and Makefile

...to avoid permanent redirects, or broken sites.

MFH:		2020Q2 (blanket, download/WWW URL chase)

Update to upstream release 0.73 (security fixes)

Relevant changes taken from this...
ChangeLog:	https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

* Security fix: in bracketed paste mode, the terminal escape sequences that
  should delimit the pasted data were appearing together on one side of it,
  making it possible to misidentify pasted data as manual keyboard input.
* Bug fix (possibly security-related): an SSH-1 server sending a disconnection
  message could cause an access to freed memory.
* Bug fix: tweaked terminal handling to prevent lost characters at the ends of
  lines in gcc's coloured error messages.
* Bug fix: removed a bad interaction between the 'clear scrollback' operation
  and mouse selection that could give rise to the dreaded "line==NULL"
  assertion box.

MFH:		2019Q4

Drop the ipv6 virtual category for s* category as it is not relevant anymore

Security update to new upstream release 0.72.

Security fixes found by the EU-funded bug bounty:
- two separate vulnerabilities affecting the obsolete SSH-1 protocol, both
available before host key checking
- a vulnerability in all the SSH client tools (PuTTY, Plink, PSFTP and PSCP) if
a malicious program can impersonate Pageant

Changelog:	https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

Switch off -DSTATIC_GSSAPI build as that produces non-working executables
(assertion failures). Bug has been reported upstream.

MFH:		2019Q3
Security:	5914705c-ab03-11e9-a4f9-080027ac955c

Reinstate GSSAPI_NONE option.

Not bumping PORTREVISION as the default build is unaffected.

Obtained from:	Jacob Nevins, upstream Git commit 7ad08649

Update security/putty to 0.71 security fix release

Unfortunately, this new release breaks GSSAPI_NONE, which is removed
for now. Bug has been reported upstream.

Changelog: https://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

MFH:		2019Q1
Security:	46e1ece5-48bd-11e9-9c40-080027ac955c

Reinstate support for GTK2 (rather than GTK3) as an OPTION.

While here, add a putty-gtk2 slave port and update _CONFLICTS.

Since the default package does not change, and pkg would handle conflicts
around attempted installation of the new -gtk2 package, omit the
PORTREVISION bump from Miroslav's original patch.

PR:		227200
Submitted by:	Miroslav Lachman

Retire WITHOUT_DEBUG flag.

The flag has partial support across the tree, and the same effect
can be obtained by using ".undef WITH_DEBUG".

Reviewed by:		mat, rene
Approved by:		portmgr (rene)
Differential Revision:	https://reviews.freebsd.org/D12548

Update to 0.70, and make GSSAPI impl. selectable.

PR:		220838
Submitted by:	cy@

security/putty: install icon and .desktop file

PR:		219095
Submitted by:	ehaupt@

Update to new upstream release 0.69.

Upstream change "You can now explicitly configure SSH terminal mode
settings not to be sent to the server, if your server objects to them."

Enable pageant, was missing from the 0.68 upgrade.

Switch to GTK3, no longer compiles with GTK2.

The security fixes contained in 0.69 are only good on Windows, so not
flagging this as a security update.

Remove leftover files.

The reference to these had been removed as of r184036 on 2007-02-03 already.

Add forgotten patch for Linux -> BSD portability.

Submitted by:	cy@
Reported by:	cy@
MFH:		2017Q1
Differential Revision:	https://reviews.freebsd.org/D10023

Update to new upstream release 0.68 (security fixes)

Additional minor updates on top of cy@'s patch (USE_GNOME, USE_XORG,
LDFLAGS).

ChangeLog: http://www.chiark.greenend.org.uk/~sgtatham/putty/changes.html

Submitted by:	cy@
MFH:		2017Q1
Security:	CVE-2017-6542
Security:	9b973e97-0a99-11e7-ace7-080027ef73ec
Differential Revision:	https://reviews.freebsd.org/D10023

Add new putty-nogtk port as alternative SSH implementation.

Cleanup $() variables in ports Makefiles.

Mostly replace with ${}, but sometime, replace with $$() because it is
what was intended in the first place. (I think.)

Sponsored by:	Absolight

Security upgrade to new upstream release 0.67.

Unix-relevant changes:
* Security fix: a buffer overrun in the old-style SCP protocol when receiving
  the header of each file downloaded from the server is fixed. (CVE-2016-2563)
* Assorted other robustness fixes for crashes and memory leaks.

MFH:		2016Q1
Security:	7f0fbb30-e462-11e5-a3f3-080027ef73ec
Security:	CVE-2016-2563

security/putty: Fix typo

security/putty: Fix krb5 dependency

Due to using both <bsd.port.pre.mk> and <bsd.port.options.mk>, the
USES+= gssapi:mit directive was ignored and not included in the build
dependency list.  Remove <pre>/<post> includes to fix.

Approved by:	mandree (maintainer)

Update to new upstream release 0.66 (security fix).

Switch to USES=gssapi:mit.

Security:	CVE-2015-5309
Security:	0cb0afd9-86b8-11e5-bf60-080027ef73ec

Drop 8 support.

With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3694

Update to new upstream bug-fix release 0.65

Release notes:
http://lists.tartarus.org/pipermail/putty-announce/2015/000021.html

MASTER_SITES cleanup.

- Replace ${MASTER_SITE_FOO} with FOO.
- Merge MASTER_SITE_SUBDIR into MASTER_SITES when possible. (This means 99.9%
  of the time.)
- Remove occurrences of MASTER_SITE_LOCAL when no subdirectory was present and
  no hint of what it should be was present.
- Fix some logic.
- And generally, make things more simple and easy to understand.

While there, add magic values to the FESTIVAL, GENTOO, GIMP, GNUPG, QT and
SAMBA macros.

Also, replace some EXTRACT_SUFX occurences with USES=tar:*.

Checked by:	make fetch-urlall-list
With hat:	portmgr
Sponsored by:	Absolight

Add CPE info.

PR:		198369
Submitted by:	shun.fbsd.pr@dropcut.net

Upgrade to upstream bugfix release 0.64.

This fixes a security bug, various other bugs, and supports SSH
connection sharing between multiple instances of PuTTY and its tools.

MFH:		2015Q1
Security:	92fc2e2b-c383-11e4-8ef7-080027ef73ec
Security:	CVE-2015-2157

Modernize LIB_DEPENDS

With hat:	portmgr

Convert GMAKE to MAKE_CMD
Please note that lots of invocation of MAKE_CMD here are wrong as they do not
properly respect MAKE_ENV and friends

With hat:	portmgr

Support staging.

Add NO_STAGE all over the place in preparation for the staging support (cat:
security)

Add explicit dependency on pkgconf (27 ports)

Upgrade PuTTY to new 0.63 beta upstream release, adding vulnerability info.

Quoting the upstream's change log:

- Security fix: prevent a nefarious SSH server or network attacker from
  crashing PuTTY at startup in three different ways by presenting a maliciously
  constructed public key and signature.
- Security fix: PuTTY no longer retains the private half of users' keys in
  memory by mistake after authenticating with them.
- Revamped the internal configuration storage system to remove all fixed
  arbitrary limits on string lengths. In particular, there should now no longer
  be an unreasonably small limit on the number of port forwardings PuTTY can
  store.
- Port-forwarded TCP connections which close one direction before the other
  should now be reliably supported, with EOF propagated independently in the

Bump PORTREVISION, to get the ports rebuilt with ${CC}.

- Convert to Options NG. Renames GTK option to GTK2 for consistency.
- Strip Makefile header.
- Make sure that the port build heeds ${CC}, passing it through MAKE_ARGS.
- Replace CC-is-clang specific -Wno-empty-body by unconditional -Wno-error.
- Remove LIB_DEPENDS ABI versions.

Add CONFLICTS.

Suggested by:	ketas's ports conflicts checker
Feature safe:	yes

- cleanup comments
Feature safe: yes

- update png to 1.5.10

Update PuTTY to new upstream security and bug fix release 0.62,
and add a new VuXML entry.

Changelog:     
http://lists.tartarus.org/pipermail/putty-announce/2011/000017.html
Security:       bbd5f486-24f1-11e1-95bc-080027ef73ec
Feature safe:   yes

Revise OPTIONS wording.

Feature safe: yes

Fix build with GSSAPI under 9.0.

Approved by:    tabthorp (portmgr)
Feature safe:   yes

- Take over maintainership from beat@ along his suggestion,
  permit him to take it back or commit without my approval.
- Update to upstream version 0.61.
- Add OPTIONS for GSSAPI and GTK (both enabled by default).

  NOTE: GSSAPI is currently broken on 9-CURRENT because the
  Kerberos in base expects MD2 which isn't provided by OpenSSL.

- mark BROKEN on OSVERSION >= 900000 when GSSAPI is enabled
- heed CFLAGS, CC, WITH_DEBUG, INSTALL_* settings.
- WITHOUT_X11 is now an alias for WITHOUT_GTK
- drop utmp support, the upstream requires a utmpx implementation that
  FreeBSD does not provide in any version.
- Preliminary clang support (adds files/patch-timing.c)
- Refreshed patches.

-remove MD5

- Remove unneeded utmp.h include to fix build on CURRENT

Reported by:    pointyhat via erwin

Update my email address to @FreeBSD.org.

Approved by:    miwi (mentor)

- Pass maintainership to submitter

Submitted by:   "Beat Gätzi" <beat@chruetertee.ch>

Bump portrevision due to upgrade of devel/gettext.

The affected ports are the ones with gettext as a run-dependency
according to ports/INDEX-7 (5007 of them) and the ones with USE_GETTEXT
in Makefile (29 of them).

PR:             ports/124340
Submitted by:   edwin@
Approved by:    portmgr (pav)

Drop maintainership

- Add one more MASTER_SITE

- Update to 0.60

PR:             ports/112377
Submitted by:   Dima Panov <fluffy@ael.ru>

- Welcome X.org 7.2 \o/.
- Set X11BASE to ${LOCALBASE} for recent ${OSVERSION}.
- Bump PORTREVISION for ports intalling files in ${X11BASE}.

Install puttygen even if you set WITHOUT_GTK since it doesn't require gtk.

PR:             ports/110335
Submitted by:   Kenneth Vestergaard Schmidt<kvs@pil.dk>

Update to 0.59

- Remove 4.x support on my ports

Remove USE_REINPLACE from all categories starting with S

Bump PORTREVISION on glib12/gtk12 consumer ports to ease the upgrade path.

Discussed with: kris
Approved by:    portmgr (implicit)

- Add SHA256

Change MAINTAINER to my @FreeBSD.org account

Approved by:    flz (mentor)

- Update to 0.58
- Assign maintainership

PR:             80460
Submitted by:   Renato Botelho <freebsd@galle.com.br>

Security update to 0.57.

Security:      
http://vuxml.FreeBSD.org/a413ed94-836e-11d9-a9e7-0001020eed82.html
Approved by:    erwin (mentor)

- Security Update to 0.56

- drop maintainership

- Security update to 0.55

- improve supoort of gtk
Submitted by:   fjoe

- Enable IPV6 Support per default
- new Option WITHOUT_IPV6
Submitted by:   ume

PuTTY is a client program for the SSH, Telnet and Rlogin network protocols.

These protocols are all used to run a remote session on a computer,
over a network. PuTTY implements the client end of that session:
the end at which the session is displayed, rather than the end
at which it runs.

WWW: http://www.chiark.greenend.org.uk/~sgtatham/putty/