emulators/virtualbox-ose-kmod: Fix kernel panic on 13/14 with bridge mode by
adding EPOCH support

In r560502, I added a patch to support EPOCH to VirtualBox 5. When we upgraded
to VirtualBox 6, that patch was (unintentionally) removed, making it impossible
to use bridge move without this current patch.

Approved by:	jkim, madpilot
Differential Revision:	https://reviews.freebsd.org/D29319

Remove trailing spaaces from patch.

- Update VirtualBox OSE to 6.1.18
- Old VirtualBox OSE 5.2.44 preserved as "-legacy" versions of the
  ports (repocopied)
- Add back extra patch removed in r528258, actually required to
  build DEBUG kmod
- Correctly define WITH_DEBUG when enabling the DEBUG option, so
  binaries are not stripped

Please note that this new version supports only amd64 CPUs. If you need
to use older hardware please install the legacy ports.

Note that moving VM snapshots across major updates is unsupported, it's
strongly suggested to properly shutdown VMs before upgrading, please
check UPDATING for further details.

Fix VirtualBox build on recent head and 13 after src commit
0659df6faddf

PR:		252675
Submitted by:	O. Hartmann <ohartmann@walstatt.org>
		Mateusz Piotrowski <0mp@FreeBSD.org> (duplicate)
Reported by:	se (mailing lists), others
Approved by:	ports-secteam (fluffy)
MFH:		2020Q1

emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and
bridge mode.

Reviewed by:		kp, jkim (previous version)
Approved by:		kp, jkim (previous version), 0mp (mentor)
Differential Revision:	https://reviews.freebsd.org/D26359

Fix patch to virtualbox-ose-additions OpenGL ssupport to actually
work at runtime as much as possible.

The OpenGL bits in VirtualBox 5 are an old implementation that does
not play too well with what wee have in the tree now. Thesse patches
simply change the funzionn prototypess in VirtualBox to match the
ones from mesa so it caan compile and interface as much as possible
with it.

Thanks to Ronald Klop <ronald-lists@klop.ws> for testing.

PR:		250315
Submitted by:	rozhuk.im@gmail.com
Approved by:	portmgr (fixit blanket)

Fix emulators/virtualbox-ose build after r552109.

VirtualBox embeds an outdated version of glext.h, causing it to
fail to build due to symbols being redefined incorrectly.

Import patch which forces virtualbox to append it's own include
paths, thus not "obscuring" the system provided OpenGL include file.

PR:		250315
Submitted by:	rozhuk.im@gmail.com
Approved by:	portmgr (fixit blanket)

emulators/virtualbox-ose: Turn off aio usage and make VirtualBox use generic
Unix implementation.

This fixes instabilities on some loads involving disk IO.

PR:		168298, 221294
Approved by:	vbox (timeout)

emulators/virtualbox-ose-kmod: Fix a pair of VM bugs

- Use vm_pager_allocate() to allocate OBJT_PHYS objects.  This ensures
  that they're initialized properly.
- Don't assume that user wiring will succeed.

This had been a team effort, with multiple independent reports,
a wide variety of experiments, and patches written by kib@
and refined by markj@.

I'm bumping PORTREVISION and aligning the revision of both kmod and
application; it's possible the application bump isn't actually
needed but let's make sure they both get rebuilt with this
important (because of changed kernel assumptions) fix.

PR:		249326
Submitted by:	kib, markj
Reported by:	adridg, Rainer Hurling
Reviewed by:	adridg
Approved by:	koobs (vbox)
MFH:		2020Q3

Fix crash when accessing physical CD/DVD

PR:		248333
Reported by:	mfv@bway.net
Approved by:	koobs (vbox)
MFH:		2020Q3

Fix emulators/virtualbox-os-additions on head after vget(9) change.

Do not allow compiling C++ files for drivers with built-in functions.

This change lets us do "kldload vboxvfs.ko" (although it is still broken).

Remove unncessary memcpy(3) and fix file system ID handling.

I removed a bzero() call to reduce compiler warnings in the previous commit
(r544829).  It turned out the next memcpy() call was also wrong.  Just use
natural assignments here not to obfuscate the code.

Reported by:	Martin Simmons (martin at lispworks dot com) (some time ago)

Remove a superfluous bzero(3) call to reduce compiler warnings.

PR:	226073

Fix building emulators/virtualbox-ose-additions on head after vaccess(9) KPI
change.

- Update VirtualBox ports to 5.2.44
- Adapt and regenerate patches
- Reduce differences in patch-src_VBox_Devices_PC_vbox-cpuhotplug.dsl [1]

Patch based on one provided by Mario Lobo <lobo@bsd.com.br>.

Many thanks to people who provided ideas and suggetions in the
PR and review.

PR:			244212
Submitted by:		Nikita Stepanov <nikitastepan0v@bk.ru>
Reviewed by:		kevans [1]
Tested by:		lwshu
Approved by:		ports-secteam (joneum)
MFH:			2020Q3
Security:		1e7b316b-c6a8-11ea-a7d5-001999f8d30b
Differential Revision:	https://reviews.freebsd.org/D25496

emulators/virtualbox-ose: UNBREAK with gsoap 2.8.103

- gSoap 2.8.103 macro soap_socket_errno changed from:
  soap_socket_errno(s) -> soap_socket_errno

PR:		246910
Submitted by:	dereks@lifeofadishwasher.com
Reported by:	transitive@gmail.com

emulators/virtualbox-ose: prepare for Qt5-5.15

Fix r531689 i386 build.

PR:		236616, 244847
Submitted by:	kevans
MFH:		2020Q2 (blanket: major runtime build fix)
MFH-with:	r531689

emulators/virtualbox-ose: Switch build to USES= compiler:c++14-lang

The runtime breakage that started occurring after the LLVM 7 -> 8 transition
has been diagnosed with help from cem@, and the attached patch fixes it. The
problem ended up being that tail-call optimization was being applied to this
function (which should probably be written in assembly instead) and moving
the tail-call to later on after some stack manipulations. The problem with
this is that this particular function uses alloca() to carefully craft a
stack that it's expecting to be used for the function it's calling at the
end.

The new patch fixes this using a technique that was committed later on in
upstream changeset 75061 to address a similar failure with GCC sanitizers
enabled. The FreeBSD-specific component of this patch is using the different
stack setup if __clang__ is defined as well.

- Fix runtime for gcc rpath. [1]
  This is a regression of something that was working in the past. Please
  keep the _GCC_RUNTIME handling even if removing USE_GCC as it may
  come back again in the future and be forgotten.
- Fix build on 11.3 with ports ssl. [2]

PR:		245048 [1]
PR:		243315 [2]
Submitted by:	John Hein <jcfyecrayz at liamekaens.com> [2]

emulators/virtualbox-ose: use contemporary GCC instead of old llvm

The bug in PR 236616 resulted in virtualbox getting pinned to llvm7. This is
less than ideal, and in-fact has been broken by improvements to
machine/atomic.h
on x86 that require a more modern compiler.

Switch the build to USE_GCC= any. The patches that were previously applied
if COMPILER_TYPE == clang are actually needed by newer GCCs as well, so make
those
standard patches instead, folding the Config.kmk patches together.

We should put some effort into testing llvm10 and working out why llvm
breaks
it, but fixing the build is more important at the moment.

Update xorg x11 servers to 1.20.7

Update xorg x11 servers to 1.20.7.  This updates x11-servers/xorg-server,
xephyr, xorg-dmx, xorg-nestserver, xorg-vbserver and xwayland.

Enable the UDEV backend by default, instead of the DEVD backend, for
autoconfiguration of input devices on FreeBSD 12 and later.
FreeBSD 11 lacks the needed support in base and will keep on using the DEVD
backend.
Support for the HAL backend is dropped completely, it has been deprecated
for a long time.
Update and improve the DEVD backend.
Add a pkg message about sysctl configuration that might be needed when using
UDEV.

Build emulators/virtualbox-ose-additions on head after r355537.

Add USES=xorg USES=gl, ports categories e

Add USES=xorg, USES=gl and in a few cases USES=gnome to ports in categories
starting with 'e'.

Fix build with the recent iasl(8) on head after r353764.

Note this error was added in ACPICA 20190816.

Update to 5.2.34.

https://www.virtualbox.org/wiki/Changelog-5.2#v34

Qt5 update to 5.13.0

For new features, check: https://wiki.qt.io/New_Features_in_Qt_5.13

Thanks to adridg who helped to fix a lot of packages.

Exp-run by:	antoine
PR:		238782

emulators/virtualbox-ose*: Use ECHO_CMD not ECHO per bsd.commands.mk

- Unbreak `make -s` builds

PR:		240433, 240426
Submitted by:	Franco Fichtner <franco@opnsense.org> (based on)

Convert to UCL & cleanup pkg-message (categories e-g)

Bump PORTREVISION for ports depending on the canonical version of GCC
as defined in Mk/bsd.default-versions.mk which has moved from GCC 8.3
to GCC 9.1 under most circumstances now after revision 507371.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

Update to 5.2.32.

https://www.virtualbox.org/wiki/Changelog-5.2#v32

Revert r501849 and restore the previous behaviour.  No functional change.

Work around a build issue.

Update to 5.2.30.

https://www.virtualbox.org/wiki/Changelog-5.2#v30

set VirtualBox MASTER_SITES to download.oracle.com

The SSL certificate of the host does not have download.virtualbox.org
in it's SubjectAltName anymore (download.virtualbox.org points to the
same CDN and is the same host as download.oracle.com, and checksums still
match).

Reported by:	Duncan Young

Add USES=sdl when USE_SDL=sdl is set.  No functional change.

PR:		237539

Update to 5.2.28.

https://www.virtualbox.org/wiki/Changelog-5.2#v28

Update KDE Applications to 19.04.0

The changelog can be found here:
	- https://kde.org/announcements/announce-applications-19.04.0.php

Due to crashes on start, multimedia/kdenlive was kept at 18.12.3 for now.

Apply a bandaid to work around runtime issues with Clang 8.0.

PR:		236616

Work around build issues with LLD on i386.

Fix emulators/virtualbox-ose-additions build with lld on i386.

Fix build with lld on head after r345349.

PR:		236775

Revert r494756 and r494757 for now.  It seems this patch needs more work.
Somehow it prevented executables from starting properly.

Reported by:	Martin Birgmeier <d8zNeCFG@aon.at>
		Petyo Milotinov <petyo@petyo.org>

Fix a typo in the previous patch.

Make linker option for executables closer to Linux equivalent, i.e.,
"-z noexecstack", "-z relro", and "--as-needed".

Use system X.Org header files instead of the bundled files.

PR:		227238

multimedia/libvpx: update 1.8.0

www/firefox, www/firefox-esr, mail/thunderbird wait for upstream fix via
https://bugzilla.mozilla.org/show_bug.cgi?id=1525393

Changes:	https://chromium.googlesource.com/webm/libvpx/+log/v1.7.0..v1.8.0
ABI:		https://abi-laboratory.pro/tracker/timeline/libvpx/

Appease stage-qa.

PR:		217511

Fix OpenGL dependency and appease stage-qa.

PR:		217511

Prefer HTTPS for MASTER_SITES.

Update to 5.2.26.

https://www.virtualbox.org/wiki/Changelog-5.2#v26

- Bump PORTREVISION of ports that depends of net/libvncserver after it
  was updated to version 0.9.12

Submitted by:	dereks_lifeofadishwasher.com
Differential Revision:	https://reviews.freebsd.org/D18836

Update to 5.2.24.

https://www.virtualbox.org/wiki/Changelog-5.2#v24

Fix Qt5 symbol version scripts to put the catch-all clause first.  When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call

Bump PORTREVISION for ports depending on the canonical version of GCC
defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t
GCC 8.2 under most circumstances.

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.

PR:		231590

Fix build when SRC_BASE is not /usr/src.

PR:		233626

Fix a VNC regression since 5.2.20.

PR:		232528
Obtained from:	VirtualBox Ticket #18153

Update to 5.2.22.

https://www.virtualbox.org/wiki/Changelog#22

Support SMAP for amd64.

This should stop kernel panics on SMAP supported CPUs after r336876.

PR:		230460
MFH:		2018Q4

Update to 5.2.20.

https://www.virtualbox.org/wiki/Changelog#20

Change x11/xorgproto to become a build dep

Change x11/xorgproto to become a build time dependency when added to
USE_XORG.  Change the dependency to be on the port, rather than a file the
port installs.
Fix fallout.
Bump portrevision on depending ports.

PR:		230909
Reviewed by:	eadler
Approved by:	portmgr (antoine)
Obtained
from:	https://github.com/FreeBSDDesktop/freebsd-ports/tree/feature/xorgproto
exp-run:	antoine
Differential Revision:	https://reviews.freebsd.org/D16906

Update to 5.2.18.

https://www.virtualbox.org/wiki/Changelog#18

Switch to xorgproto instead of individual packages

Upstream used to distribute protocol headers as separate packages, but has
decided to merge those to a common package, named xorgproto.  This update
tracks that change.

* Add a new port, x11/xorgproto, with are protocol headers for xorg.
* Hook the new protocol port to the build and to infrastructure in
  bsd.xorg.mk.
* Update all ports with a dependency on any of the old *proto packages to
  instead depend on xorgproto.  Bump portrevision.
* Delete the old *proto packages, update MOVED.

PR:		230023
Submitted by:	zeising
Approved by:	portmgr (antoine)
exp-run by:	antoine

emulators/virtualbox-ose: Fix build when using 3.? as default Python

When using DEFAULT_VERSIONS=python=3.6 or similar the build fails
with

kBuild: Generating python -
.../out/freebsd.amd64/release/obj/VBoxOGLgen/spu_dispatch_table.h
kmk_builtin_redirect: posix_spawnp(python-not-found) failed: No such file or
directory

Explicitly use Python 2.7 for the time being to fix the build.

PR:		225734
Submitted by:	Peter Wullinger <freebsd@dhke.de>
Approved by:	vbox (maintainer timeout, 5 months+)

vboxheadless: Fix start of specific machine after base r291770.

The vboxheadless rc script has its own pid checking, so the rc.subr
version in run_rc_command is not needed.

PR:		212074

Update to 5.2.16.

https://www.virtualbox.org/wiki/Changelog#16

Unbreak emulators/virtualbox-ose-additions and emulators/virtualbox-ose-kmod
on head after r335879.

Update to 5.2.14.

https://www.virtualbox.org/wiki/ChangeLog#14

Remove obsolete patches.

Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk

From now on, ports that depend on Qt4 will have to set
	USES=		qt:4
	USE_QT=		foo bar
ports depending on Qt5 will use
	USES=		qt:5
	USE_QT=		foo bar

PR:		229225
Exp-run by:	antoine
Reviewed by:	mat
Approved by:	portmgr (antoine)
Differential Revision:	-https://reviews.freebsd.org/D15540

Remove obsolete kludges.  All supported versions do not need these hacks.
Furthermore, these hacks break build on head.

PR:		228433

Fix emulators/virtualbox-ose-additions build with OpenGL option.

Reported by:	mat, des

emulators/virtualbox-ose: add pkg-message about sysctl tuning with AIO

- New values for several sysctl vfs.aio.max* parameters are suggested

PR:		168298
Submitted by:	rozhuk.im@gmail.com
Reported by:	petefrench@ingresso.co.uk

Update to 5.2.12.

https://www.virtualbox.org/wiki/Changelog#12

Fix build on head after r333077.

Chase Guest Additions change.

Reported by:	Patrick Mackinlay (patrick at spacesurfer dot com)

- Update WWW

Approved by:	portmgr blanket

Fix pkg-plist

Update to 5.2.10.

https://www.virtualbox.org/wiki/Changelog#v10

Bump PORTREVISIONs of all users of math/mpc that we just updated to
version 1.1.0 (via revision 464079).

Work around the lack of definition of union semun per POSIX.

When feasible do this by adding -D_WANT_SEMUN to CFLAGS or CXXFLAGS.
Where this fails due to ports not honoring C*FLAGS, patch using
__FreeBSD_version to enable the definition.

PR:		224300, 224443 (exp-run)
Approved by:	portmgr (antoine)
Exp-run:	antoine
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D14137

Update to 5.2.8.

https://www.virtualbox.org/wiki/Changelog#v8

emulators/virtualbox-ose: remove extra dependency on cdrtools.

Dependency on cdrtools was introduced 6 years ago for sake of mkisofs:
https://svnweb.freebsd.org/ports/head/emulators/virtualbox-ose/Makefile?revision=274444&view=markup

In fact, VirtualBox build system does not use makeisofs
while building for FreeBSD because it does not even try to buid
VirtualBox Additions ISO image as its documentation says
in the Prerequisites section:

	mkisofs (required only for additions which aren't supported yet)
	=> /usr/ports/sysutils/cdrtools

	https://www.virtualbox.org/wiki/FreeBSD%20build%20instructions

And it never really used mkisofs.
Drop the dependency and bump PORTREVISION.

PR:		225376
Approved by:	vbox (maintainer timeout, 2 weeks)

multimedia/libvpx: update 1.7.0

Changes:	https://chromium.googlesource.com/webm/libvpx/+log/v1.6.1..v1.7.0
ABI:		https://abi-laboratory.pro/tracker/timeline/libvpx/

Re-enable AVX/AVX2 support for guest.

This patch is no longer necessary according to the original reporter.

PR:		211651

Fix emulators/virtualbox-ose-additions build with Clang 6.0.

Update to 5.2.6.

Update to 5.2.4.

https://www.virtualbox.org/wiki/Changelog#v4

Reduce build dependency.

PR:		223709

Update to 5.2.2.

Convert Python ports to FLAVORS.

  Ports using USE_PYTHON=distutils are now flavored.  They will
  automatically get flavors (py27, py34, py35, py36) depending on what
  versions they support.

  There is also a USE_PYTHON=flavors for ports that do not use distutils
  but need FLAVORS to be set.  A USE_PYTHON=noflavors can be set if
  using distutils but flavors are not wanted.

  A new USE_PYTHON=optsuffix that will add PYTHON_PKGNAMESUFFIX has been
  added to cope with Python ports that did not have the Python
  PKGNAMEPREFIX but are flavored.

  USES=python now also exports a PY_FLAVOR variable that contains the

Fix stage-qa warnings.

Sponsored by:	Absolight

- Work around build failures with Clang 3.4.
- Fix build without WEBSERVICE option. [1]

PR:		223201 [1]

Fix emulators/virtualbox-ose-nox11 build.

PR:		223202

Update to 5.2.0.

Update to 5.1.30.

Revert r450636.  It did not work as we expected.

Build recompiler with Clang if global register variable is supported.

Note support for global register variable was proposed in the following
upstream code reviews:

https://reviews.llvm.org/D3261
https://reviews.llvm.org/D3797

and commits:

http://llvm.org/viewvc/llvm-project?view=revision&revision=208104
http://llvm.org/viewvc/llvm-project?view=revision&revision=209149

However, it has very limited support as described in the following upstream
PR in the gory details:

Update to 5.1.28.