net-mgmt/net-snmp: Fix scenario where a user does not have a config in the
default location

PR:		280284
Reported by:	gebhart@secnetix.de

net-mgmt/net-snmp: Add an upgrade message for running snmpd as non-root

Explain that snmpd now drops privileges by default, and describe how one
can configure snmpd to run without any root privileges at all.

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield

net-mgmt/net-snmp: Make snmpd and snmptrapd drop privileges by default

Now that we have a better idea of what problems can arise with this
change, let's try again, this time providing better documentation and
some troubleshooting steps.

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield

net-mgmt/net-snmp: Fix a typo in the pkg-message

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield

net-mgmt/net-snmp: Provide an option for snmptrapd to drop privs

As with snmpd, we can run snmptrapd with reduced privileges, which is
certainly desirable since snmptrapd's main function is to receive SNMP
traps and log them somewhere.

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield

net-mgmt/net-snmp: Update ownership of snmpd.log

Otherwise snmpd isn't able to re-open its log file after rotation, when
configured to run as the snmpd user.

Approved by:	zi
Sponsored by:	Stormshield
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D45317

net-mgmt/net-snmp: Print a warning if config files aren't readable

Motivated by a bug report from dvl@.  In his case, snmpd was able to
read the configuration file initially, but failed to reload it upon
receiving SIGHUP during log rotation.

Approved by:	zi
Sponsored by:	Stormshield
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D45343

net-mgmt/net-snmp: Avoid changing to the snmpd user for now

Switching the user might break existing configurations, for reasons that
are not fully clear yet.  Avoid surprises by letting users opt-in to
that change, for now.

Also provide an rc.conf variable to make it easy to configure snmpd to
drop privileges if they so choose.

Reported by:	dvl
Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield
Differential Revision:	https://reviews.freebsd.org/D45199

net-mgmt/net-snmp: Let snmpd run as a non-root user

- Compile without /dev/kmem access.  This requires a small patch which
  opens libkvm in a dummy mode which uses sysctls to implement most of
  its interfaces rather than /dev/kmem access.  This way we can drop the
  dependency on /dev/kmem without rewriting existing code.
- Add a new snmpd user.  Configure snmpd to drop privileges once it's
  finished initialization.
- Remove the JAIL option.  Now that snmpd avoids using /dev/kmem,
  there's no need to have a special mode for running snmpd in jails.

The patch has been proposed upstream here:
https://sourceforge.net/p/net-snmp/mailman/net-snmp-coders/thread/ZjEwNV5BiTOQ-Adi%40nuc/#msg58766857

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield
Differential Revision:	https://reviews.freebsd.org/D45031

net-mgmt/net-snmp: Fix the IPV6 MIB implementation

The implementations of var_tcp6() and var_udp6() on FreeBSD don't work
and fail to compile.  var_tcp6() also makes uses of kmem access, which
I'm trying to disable in snmpd.  Provide a patch to fix these problems.
This has been committed to the 5.9 branch upstream.

Readd mibII/ipv6 since it now compiles and works in my manual testing.
Also, simply remove the IPV6 option.  It has no effect, as --enable-ipv6
is the default.

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield
Differential Revision:	https://reviews.freebsd.org/D45030

net-mgmt/net-snmp: Fix freebsd15.h

It was copied from freebsd14.h without updating it.

Also remove some bogus copying in the port makefile.  5.9.4 provides
freebsdN.h for N up to 14, and we have a patch which adds freebsd15.h.
So, get rid of the copying too.

Approved by:	zi
Sponsored by:	Klara, Inc.
Sponsored by:	Stormshield
Differential Revision:	https://reviews.freebsd.org/D45029

framework: reintroduce the feature enabling code

For each feature (see in Mk/Features) users can now set these variables
in their make.conf. Using LTO as an example.

To enable globally:

  WITH_LTO= yes

To disable globally (for example ssp is enabled by default):

  WITHOUT_LTO=	yes

To enable for a specific list of ports:

  WITH_LTO_PORTS= lang/perl5.36

To disable for a specific list of ports:

  WITHOUT_LTO_PORTS= lang/perl5.36

Differential Revision:	https://reviews.freebsd.org/D44750

net-mgmt/net-snmp: Update to 5.9.4

PR:		277436
Submitted by:	Ivan Rozhuk <rozhuk.im@gmail.com>

net-mgmt/net-snmp: Impelled to share/man

Approved by:    portmgr (blanket)

net-mgmt/net-snmp: Add include for freebsd 15.x to fix build

net-mgmt/net-snmp: Fix ports depending on this port under 15-CURRENT

Also add freebsd15.h to ${LOCALBASE}/include/net-snmp/system, missing
in 710a64c4471d. ${LOCALBASE}/include/net-snmp/system/freebsd15.h is
used by ports which depend on net-mgmt/net-snmp. Without this file
they also fail to build under 15-CURRENT.

Approved by:	portmgr (blanket)
Fixes:		710a64c4471d

net-mgmt/net-snmp: Fix build for 15-CURRENT

Add support for 15-CURRENT by adding a freebsd15.h (header) file.

Approved by:	portmgr (blanket)

devel/py-setuptools: convert individual consumers to ${PY_SETUPTOOLS}

Currently a no-op, but in the future outputs the correct setuptools
port depending on whether USES_PYTHON=distutils is specified.

With hat: python
PR: 270510, 270358

all: remove explicit versions in USES=python for "3.x+"

The logic in USES=python will automatically convert this to 3.8+ by
itself.

Adjust two ports that only had Python 3.7 mentioned but build fine
on Python 3.8 too.

finance/quickfix: mark BROKEN with PYTHON

libtool: compile:  c++ -DHAVE_CONFIG_H -I. -I../.. -I -I. -I.. -I../.. -I../C++
-DLIBICONV_PLUG -DPYTHON_MAJOR_VERSION=3 -Wno-unused-variable
-Wno-maybe-uninitialized -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong
-fno-strict-aliasing -DLIBICONV_PLUG -Wall -ansi
-Wno-unused-command-line-argument -Wpointer-arith -Wwrite-strings
-Wno-overloaded-virtual -Wno-deprecated-declarations -Wno-deprecated -std=c++0x
-MT _quickfix_la-QuickfixPython.lo -MD -MP -MF
.deps/_quickfix_la-QuickfixPython.Tpo -c QuickfixPython.cpp  -fPIC -DPIC -o
.libs/_quickfix_la-QuickfixPython.o
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean
'-Wno-uninitialized'? [-Wunknown-warning-option]
QuickfixPython.cpp:175:11: fatal error: 'Python.h' file not found
          ^~~~~~~~~~
1 warning and 1 error generated.

Reviewed by:	portmgr, vishwin, yuri
Differential Revision:	<https://reviews.freebsd.org/D40568>

net-mgmt/net-snmp: fix net-snmp-config on jail hosts

re https://github.com/net-snmp/net-snmp/issues/280

This patch allows 'net-snmp-config --create-snmpv3-user' to succeed
if run on a jail host and snmpd is also running in one of the jails.

Thhis patch limits the check to the host, ingnoring jails.

PR:		269791

net-mgmt/net-snmp: Fix missing datarootdir, Bump PORTREVISION

net-mgmt/net-snmp: Fix build under 14-CURRENT > 1400066

IPFRAGTTL was removed in 81a34d374ed6e5a7b14f24583bc8e3abfdc66306
(1400067). Define the value in the port.

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

net-mgmt: remove 'Created by' lines

A big Thank You to the original contributors of these ports:

  *  @BABOLO <.@babolo.ru>
  *  Alex Samorukov, samm@freebsd.org
  *  Alexander Kriventsov <avk@vl.ru>
  *  Alexander Sulfrian <alexander@sulfrian.net>
  *  Alexander Y. Grigoryev <alexander.4mail@gmail.com>
  *  Alexandre Biancalana <ale@biancalanas.net>
  *  Alexandre Snarskii <snar@paranoia.ru>
  *  Alexandre Snarskii <snar@snar.spb.ru>
  *  Alexey Bobkov <mr.deadlystorm@gmail.com>
  *  Alexey Dokuchaev <danfe@FreeBSD.org>
  *  Alexey V. Degtyarev

net-mgmt/net-snmp: Fix asterisk build

Always install IPv6 headers, regardless of IPv6 OPTION
PR:		264749

net-mgmt/net-snmp: Update to 5.9.1

re https://net-snmp.sourceforge.io/about/ChangeLog.html

  libnetsnmp:
      - Fixed the mib-parsing-bug introduced shortly before 5.7

  agent:
      - fixed rounding errors for disk percentage calculations

  openbsd:
      - better support for recent openbsd releases

  features:
      - bug fixes with minimalist support after additional user feedback

  Many other miscellaneous minor bug fixes

Approved by:	maintainer (via private communication)

*: fix tab vs. space issues, and comments according to the guide.

cleanup: drop support for EOL FreeBSD 11.X

Search criteria used:
- 11.4
- OSREL*
- OSVER*
- *_FreeBSD_11

Input from:
- adridg: devel/qca-legacy
- jbeich: _WITH_DPRINTF, _WITH_GETLINE, GNU bfd workarounds
- sunpoet: security/p5-*OpenSSL*

Reviewed by:	doceng, kde, multimedia, perl, python, ruby, rust
Differential Revision: https://reviews.freebsd.org/D32008
Test Plan: make index

net-mgmt/net-snmp: Fix CPE information

Approved by:    portmgr (blanket)

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

net-mgmt/net-snmp: Fix packaging with Python 3.8 if option PYTHON is set

PR:		253815
Approved by:	python (with hat)

- Move SCTP support to an OPTION, off by default, to reflect 13.x changes
- Bump PORTREVISION

PR:		254056

- Bring in upstream commit to resolve badly formed responses
(92f0fe9e0dc3cf7ab6e8cc94d7962df83d0ddbec)
- Bump PORTREVISION

PR:		253393

- Add memory calculation fix
- Bump PORTREVISION

PR:		251103
Submitted by:	ncrogers@gmail.com

- Fix PYTHON OPTION
- Require python 3.5+

PR:		249298
Submitted by:	John Hein <jcfyecrayz@liamekaens.com>

- Update to 5.9
- Add OPTION to disable libpkg support

- Add OPSYS to conditional

PR:		243048

Chase rename of security/openssl111

 - Categories n-z

MFH:		2020Q1

Drop the ipv6 virtual category for n* category as it is not relevant anymore

net-mgmt/net-snmp: revert back to 5.7.3 due to side-effects

PR:		232025
Submitted by:	dvl
Reviewed by:	zi, otis@sk.FreeBSD.org

net-mgmt/net-snmp: fix for first byte of IF-MIB::ifPhysAddress is always 0

- netsnmp_arch_interface_container_load() writes terminating NUL
  directly to the sdl_data *past* the length specified in sdl_nlen,
  overwriting first byte of physadrr.

PR:		231996
Submitted by:	Yuri Pankov <yuripv@yuripv.net>
Reviewed by:	Bart Van Assche <bvanassche@acm.org> (upstream maintainer)
Approved by:	zi (maintainer)
Obtained from:	https://sourceforge.net/p/net-snmp/code/merge-requests/20/

net-mgmt/net-snmp: Do not set LIB_DEPENDS twice

net-mgmt/net-snmp: update 5.7.3 -> 5.8

PR:		232025
Approved by:	zi (maintainer timeout)
Relnotes:	https://sourceforge.net/p/net-snmp/mailman/message/36386084/

Convert to UCL & cleanup pkg-message (categories n)

(and missed 3 missed files from previous categories.)

- Real unbreak with openssl111 from ports
- Use ${OPENSSLBASE} instead of hardcode path
- Add more conditions to check for extra patch
- TLS option is fine now

PR:		228898
Submitted by:	myself (this patch)
Approved by:	maintainer timeout (>2 months after submission)
MFH:		2019Q3

- Add 13.x support

PR:		234395
Submitted by:	Mark Linimon <linimon@freebsd.org>

security/openssl-devel was removed, but there is a security/openssl111 now.

Remove compatibility code for FreeBSD < 11.2 from all ports.

Simplify some ports where DragonFlyBSD no longer needs to be special-cased.
Submitted by:	rene
Reviewed by:	bapt, jbeich
Differential Revision:	https://reviews.freebsd.org/D17724

- Unbreak build on 13-CURRENT

Fix build with OpenSSL 1.1.1 in base.

PR:		228898
Submitted by:	w.schwarzenfeld@utanet.at
Reported by:	brnrd
Approved by:	maintainer

- Bump PORTREVISION to chase pkg PORTREVISION bump

- Make newsyslog config file installation OPTIONable
- Convert USE_MYSQL to USES=mysql

PR:		231085
Submitted by:	Dries Michiels <driesm.michiels@gmail.com>

Use BROKEN_SSL

Approved by:	portmgr (blanket)

- Do not try to build under mips/mips64 as SSP is broken per r306364

Reported by:	sbruno

Bump PORTREVISION after r459281.

Sponsored by:	Absolight

- Resolve build failure under 12-CURRENT

PR:		217589
Submitted by:	pi@

- Add flavor support for python

PR:		224092
Submitted by:	Henrik Hudson

Convert Python ports to FLAVORS.

  Ports using USE_PYTHON=distutils are now flavored.  They will
  automatically get flavors (py27, py34, py35, py36) depending on what
  versions they support.

  There is also a USE_PYTHON=flavors for ports that do not use distutils
  but need FLAVORS to be set.  A USE_PYTHON=noflavors can be set if
  using distutils but flavors are not wanted.

  A new USE_PYTHON=optsuffix that will add PYTHON_PKGNAMESUFFIX has been
  added to cope with Python ports that did not have the Python
  PKGNAMEPREFIX but are flavored.

  USES=python now also exports a PY_FLAVOR variable that contains the

- Update MFD description

PR:		222331

- MASTER_SITES cleanup

Fix LIB_DEPENDS of ports which link to libpkg.so

spine and snmpd link to libpkg.so, but it is not properly declared in
the port.

MFH:		2017Q2

Fixing net-snmpd after src revision r317061 (struct vmmeter changes),
I discovered that net-snmpd tries to read { CTL_VM, VM_TOTAL } mib into
'struct vmmeter' variable, instead of 'struct vmtotal'.  Of course,
sysctl(3) fails, but net-snmpd doesn't check for errors.  Basicly this
is broken for all supported FreeBSD versions, and I believe for all
unsupported as well.  OIDs that report interruprs, context switches,
paging and swap in/out were returning garbage from the application
stack.

To patch that problem, provide dummy struct __vmmeter, which works
both on pre-r317061 and after, and add block of code that reads all
necessary stats one by one.  To keep with the style of the file, do
not check for errors from sysctl(3).

Always pass MNT_NOWAIT to getfsstat() as documented in the manpage.

One of the four calls in net-snmp currently passes 0 which triggers an
EINVAL change after recent changes in HEAD and 11-stable to add stricter
argument checking for the flags passed to getsstat().

Bump PORTREVISION.

PR:		218011
Reported by:	Slawa Olhovchenkov <slw@zxy.spb.ru>
Reviewed by:	brooks
Approved by:	maintainer (zi)

Fix build when IPv6 is disabled.

Submitted by:	kan

- Force use of base OpenSSL for now (libpkg links against this) to resolve build
failures under 10.3 i386

PR:		210299
Submitted by:	Michael Osipov
Reported by:	software@bertram-scharpf.de

Make it compilable on FreeBSD 12 after struct inpcb and struct tcpcb were
stopped being exported.

Rename python setuptools ports to better match other python ports

Reviewed by:	mat, sunpoet
With hat:	portmgr
Differential Revision:	https://reviews.freebsd.org/D9983

Bump portrevision as it is linked to libpkg

Reported by:	madpilot

- Always check OPSYS along with OSVERSION

Approved by:	portmgr blanket

- Add TLS OPTION to net-mgmt/net-snmp
- While here replace USE_OPENSSL by USES=ssl

Approved by:	maintainer (zi@)
Obtained from:	pfSense
Sponsored by:	Rubicon Communications (Netgate)
Differential Revision:	https://reviews.freebsd.org/D9140

Mark some ports as not openssl-devel ready.

Sponsored by:	Absolight

Fix build on head (freebsd 12)

Reported by:	pkg-fallout

Rename all files containing a : in their filename.

While there, run make makepatch on affected ports, and rename patches
accordingly.

Sponsored by:	Absolight

Fix usage of WITH_OPENSSL_BASE, WITH_OPENSSL_PORT and OPENSSL_PORT.

WITH_OPENSSL_* can't be set after bsd.port.pre.mk.
Fold all other usage into using SSL_DEFAULT == foo

PR:		210149
Submitted by:	mat
Exp-run by:	antoine
Sponsored by:	The FreeBSD Foundation, Absolight
Differential Revision:	https://reviews.freebsd.org/D6577

- Add OPTION to pass --disable-snmptrapd-subagent to configure

PR:		209885
Submitted by:	emz@norma.perm.ru

Remove NLS, DOCS, EXAMPLES and IPV6 from OPTIONS_DEFAULT, they are enabled by
default anyway and don't need to be listed

Approved by:	portmgr blanket

Remove ${PORTSDIR}/ from dependencies, categories m, n, o, and p.

With hat:	portmgr
Sponsored by:	Absolight

Fix net-snmp ipv6 option handling when other options are also used.

r381568 added CONFIGURE_ARGS+=--with-out-mib-modules="mibII/ipv6", but the
handling of other options can result in two different --with-out-mib-modules
arguments being passed to configure, and only the second one has
effect. That leads to build failures because it tries to build the old
mibII/ipv6 which is no longer supported on freebsd.

This change adds mibII/ipv6 to the list of excluded modules that gets turned
into the --with-out-mib-modules argument, so it plays nice with other option
handling.

PR:		199401
Approved by:	mat(mentor)
Differential Revision:	https://reviews.freebsd.org/D5329

- Add newsyslog rotation configuration for /var/log/snmpd.log
- Bump PORTREVISION

Submitted by:	Jan Joris Vereijken <janjoris@acm.org>

Drop 8 support.

With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3694

- Fix two memory leaks (reported in upstream bug #2674)
- Bump PORTREVISION

Submitted by:	Laurent GOUHIER <lg@efficientip.com>
Obtained from:	valgrind

- Honor WITHOUT_SSP

PR:		203369
Submitted by:	Kenneth Salerno <kennethsalerno@yahoo.com>

Typos, whitespace and capitalization fixes (G-P).

- Merge in fix for upsteam bug #2647
- Bump PORTREVISION

Fix build with the two latest lang/perl5-devel.

Approved by:	zi
Sponsored by:	Absolight

Fix build with lang/perl5-devel after 16d89be.

Approved by:	zi
Obtained from:	Jarkko Hietaniemi
Sponsored by:	Absolight

- Fix CVE-2015-5621
- Bump PORTREVISION

PR:		202099
Submitted by:	serg@tmn.ru

- Don't cat pkg-message from Makefiles

Approved by:	portmgr blanket

- Add CPE info

Approved by:	portmgr blanket

Bump after upgrade of pkg

Remove OSVERSION checks that do not make sense any more.

For example (${OSVERSION} >= 900000 && ${OSVERSION} < 900021) is always true,
as is (${OSVERSION} > 900002 || ${OSVERSION} < 900000 && ${OSVERSION} > 800107).

Regarding patches, when an EXTRA_PATCHES is no longer needed, I remove it, when
it is always needed, I renamed it, in one case, I merged two patches.

Differential Revision:	https://reviews.freebsd.org/D2209

On head do not build deprecated IPV6-MIB implementations in mibII/ipv6.c,
now superseeded by the INET-XXX-MIB versions. And no need for _WANT_IFADDR
hack now.

This fixes build on head, since cuts away the main kvm(3) abuser from
net-snmp.

Discussion:	http://sourceforge.net/p/net-snmp/mailman/message/33539005/
Sponsored by:	Netflix
Sponsored by:	Nginx, Inc.
Approved by:	zi

- Bring back lost patch to fix memory usage calculations
- Bump PORTREVISION

PR:		148339

- Fix error in previous patch that was causing threads to be included in the
process count
- Bump PORTREVISION

- Add JAIL OPTION to build with options that are happy for running snmpd within
a jail(8)

PR:		197763
Submitted by:	Athanasios Douitsis <aduitsis@gmail.com>

- Fix hrSystemProcesses regression
- Bump PORTREVISION

PR:		197124
Submitted by:	Lukasz Wasikowski <lukasz@wasikowski.net>
Obtained from:	upstream: https://sourceforge.net/p/net-snmp/bugs/2595/

- Never link against libpci
- Fix build under 11
- Bump PORTREVISION

PR:		196904, 194881

Get libpkg detection working again on 8 and 9, fixes hrSWInstalled's MIB.

Approved by:	zi
Sponsored by:	Absolight