emulators/virtualbox-ose{,-additions,-kmod}{,-legacy}: Update CONFLICTS_INSTALL
and PORTSCOUT before commit new ports with VirtualBox 7.0.x

PR:	271146

emulators/virtualbox-ose{,-legacy}: Merge patches and unify patch names for
src/VBox/Devices/PC/ipxe/Makefile.kmk

emulators/virtualbox-ose-kmod: Add check for MAXCPU and mp_maxcpus before load
vboxdrv.ko

If the MAXCPU option is not the default for the running kernel, then
'kldload vboxdrv.ko' will result in a kernel panic.
Due to ABI difference (vboxdrv passes cpuset_t parameter (bitfield with
CPU_SETSIZE -> MAXCPU bits) into smp_rendezvous_cpus()) kernel panics
with "ncpus is 0 with non-zero map" message.

PR:	219913

emulators/virtualbox-ose-additions{,-nox11}: Fix vboxvfs bugs

This commit fixes vboxvfs (shared foler) kernel module bugs:
* fix open file leaks on creating files that causes file descriptor
  leaks on host;
* fix halfway lookups.

PR:	245865
MFH:	2025Q1

emulators/virtualbox-ose{,-nox11}{,-legacy}: Fix listen VNC on TCP port on IPv6
address

Four new options are available:
 - "VNCAddress4" -> IPv4 address to use
 - "VNCPort4" -> IPv4 Port to use
 - "VNCAddress6" -> IPv6 address to use
 - "VNCPort6" -> IPv6 port to use

"TCP/Ports" is used for backward compatibility as IPv4 and IPv6 ports if
"VNCPort4" or "VNCPort6" is not defined.

Detailed description is here:
https://www.virtualbox.org/browser/vbox/trunk/src/VBox/ExtPacks/VNC/VBoxVNC.cpp#L361

PR:	193778

emulators/virtualbox-ose*: Improve ports

* Replace PORTVERSION with DISTVERSION.
* Fix CONFLICTS_INSTALL.
* Fix PYTHON in DEFAULT_OPTIONS in emulators/virtualbox-ose.
* Pet portclippy and portlint.
* Formatting and etc.

PR:	258159

emulators/virtualbox-ose: Rename patch from *.bak to *

PR:	282780
Fixes:	1b244fbbf4d6 (Fix build error since 1500027 (struct ifnet is now hidden))

emulators/virtualbox-ose-kmod: Fix build error since 1500027 (struct ifnet is
now hidden)

Based on patch from wulf.

PR:		282780
Tested by:	groenveld@acm.org

*: Bump PORTREVISIONs of Pulseaudio consumers

Sponsored by:	Future Crew, LLC

filesystems: add new category for file systems and related utilities

The filesystems category houses file systems and file system utilities.
It is added mainly to turn the sysutils/fusefs-* pseudo-category into
a proper one, but is also useful for the sundry of other file systems
related ports found in the tree.

Ports that seem like they belong there are moved to the new category.
Two ports, sysutils/fusefs-funionfs and sysutils/fusefs-fusepak are
not moved as they currently don't fetch and don't have TIMESTAMP set
in their distinfo, but that is required to be able to push a rename
of the port by the pre-receive hook.

Approved by:	portmgr (rene)
Reviewed by:	mat
Pull Request:	https://github.com/freebsd/freebsd-ports/pull/302
PR:		281988

multimedia/libvpx: update 1.15.0

Changes:	https://chromium.googlesource.com/webm/libvpx/+log/v1.14.1..v1.15.0
Reported by:	Repology

all: drop support for expired FreeBSD 14.0

Simplify expressions for FreeBSD 13.X

Reviewed by:	many

Differential Revision:	https://reviews.freebsd.org/D46601

emulators/virtualbox-ose-kmod: Catch up with FreeBSD KPI changes

After 1500021, kick_proc0() doesn't exist.

PR:		280495
Approved by:	vvd (maintainer)
Reported by:	Michael Butler <imb@protected-networks.net>

emulators/virtualbox-ose{,-nox11}: fix USB passthrough fails with: Failed to
create a proxy device for the USB device

Failed to create a proxy device for the USB device. (Error:
VERR_INVALID_PARAMETER)

00:00:24.961804 usbProxyConstruct: Failed to open '/dev/ugen0.6',
rc=VERR_INVALID_PARAMETER

00:00:24.961881 ERROR [COM]: aRC=NS_ERROR_FAILURE (0x80004005)
aIID={872da645-4a9b-1727-bee2-5585105b9eed} aComponent={ConsoleWrap}
aText={Failed to create a proxy device for the USB device. (Error:
VERR_INVALID_PARAMETER)}, preserve=false aResultDetail=-2

In commit
https://cgit.freebsd.org/src/commit/?id=9b077d72bcc313baea2b9283afc7f568739eaadc
+#define	USB_FS_XFER_MAX 126
-	if (fs_ep_ptr == NULL || ep_index_max > 127)
+	if (fs_ep_ptr == NULL || ep_index_max > USB_FS_XFER_MAX)
To fix VirtualBox decrease USBFBSD_MAXENDPOINTS from 127 to 126:
-#define USBFBSD_MAXENDPOINTS 127
+#define USBFBSD_MAXENDPOINTS 126

PR:		270900
Tested by:	groenveld@acm.org, russo@bogodyn.org
Approved by:	with hat of vbox (maintainer)
MFH:		2024Q3

emulators/virtualbox-ose: fix build emulators/virtualbox-ose-additions{,-nox11}
on main: error: unknown type name 'uma_zone_t'

In file included from
/wrkdirs/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.50/src/VBox/Additions/freebsd/vboxvfs/vboxvfs_prov.c:42:
/wrkdirs/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.50/src/VBox/Additions/freebsd/vboxvfs/vboxvfs.h:209:2:
error: unknown type name 'uma_zone_t'
  209 |         uma_zone_t      sf_node_pool;
      |         ^

Reported by:	pkg-fallout
MFH:		2024Q3

emulators/virtualbox-ose{,-nox11}: add vboxinit start/stop script for VMs which
is controlled from phpvirtualbox

Set the "Startup Mode" to "Automatic" for the virtual machine in
phpvirtualbox to automatically start the virtual machine during OS boot.

This script also stops virtual machines during reboot even if
vboxinit_enable="YES" is not present in /etc/rc.conf.

phpvirtualbox uses the "Web Service" (WEBSERVICE) to configure and
manage virtual machines, so we install the script only when the
WEBSERVICE option is enabled.

PR:	280062

emulators/virtualbox-ose: Refactor DOCS

Although the documentation builds fine currently however the doc
UserManual.pdf fails to build from the docbook with pdflatex from TeX
2024. So decouple the documentation file from the builds as an
additional DISTFILE. As this version is no longer supported by upstream
it is highly unlikely that the build of the documentation will be fixed
by upstream. Or unless someone has enough enthusiasm to fix the build
of the documentation once TeX 2024 hits the tree.

Approved by: portmgr (blanket)
Sponsored by: Nepustil

cleanup: remove occurrences of WITH_DEBUG

DEBUG like all ports features, must not ever be set in a port, they are
user facing features, that the user needs to enable in their
environment/make.conf, either by defining WITH_DEBUG globally, or by
setting WITH_DEBUG_PORTS with origin of ports they want DEBUG enabled
in.

multimedia/libvpx: update 1.14.0

Changes:	https://chromium.googlesource.com/webm/libvpx/+log/v1.13.1..v1.14.0
Reported by:	portscout

emulators/virtualbox-ose{,-kmod,-additions}: update to 6.1.50

Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v50

PR:			276437
Approved by:		arrowd (mentor), olce
Differential Revision:	https://reviews.freebsd.org/D43510
MFH:			2024Q1

*/*: Sunset 12.4-RELEASE/12-STABLE from ports tree

- Remove all references to defunct ARCH arm
- Remove all references to defunct ARCH sparc64
- Remove x11-drivers/xf86-video-sunffb which requires defunct sparc64
  ARCH
- Remove sysutils/afbinit requires defunct sparc64 ARCH
- Remove all references to bktr driver
- Remove all references to defunct FreeBSD_12
- Remove all references to OSVERSION/OSREL corresponding to 12
- Remove conditionals in Mk/Uses/cabal.mk
- Remove sparc reference from Mk/Uses/qt-dist.mk
- Remove BROKEN_sparc64/NOT_FOR_ARCH=sparc64
- Remove BROKEN_FreeBSD_12* from:
- Remove OpenSSL patches from:
- Remove conditional flags for OSVERSION >= 1300000 to fixed flags.
  Also move conditional flags for non sparc64/arm ARCH to fixed flags.

Reviewed by:	brooks, jbeich, rene, salvadore
Differential Revision: https://reviews.freebsd.org/D42068

emulators/virtualbox-ose: add option to build vboximg-mount

Introduce new port option VBOXIMG that enables building and installing
"vboximg-mount" utility. It is not enabled by default as it needs
fusesfs-libs as another dependency.

The utility gives access to insides of VM images like .vdi files etc.
Use "vboximg-mount -g" to get access to files on internal file systems
not supported by native FreeBSD mount command. Refer to utility's
internal online help for syntax details and to original documentation:

https://docs.oracle.com/en/virtualization/virtualbox/6.0/user/vboximg-mount.html

PR:		274817
Tested by:	vvd
Approved by:	vbox (maintainer timeout over 2 weeks)

emulators/virtualbox-ose{,-kmod,-additions}: update to 6.1.48

Based on patch from Sergey V. Dyatko <sergey.dyatko@gmail.com>.
Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v48

PR:			274555
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D42322
MFH:			2023Q4

emulators/virtualbox-ose: fix build errors on CURRENT

PR:			272991
Reviewed by:		corvink, manu
Approved by:		manu, vbox (maintainer timeout)

audio/pulseaudio: Update to 16.1

Bump PORTREVISION on consumers.

Sponsored by:	Serenity Cybersecurity, LLC

PR:		262713

all: remove support for expired FreeBSD 13.1

Approved by:	portmgr (implicit), salvadore (gcc ports)
Reviewed by:	jbeich

Differential Revision: https://reviews.freebsd.org/D40845

emulators/virtualbox-ose{,-nox11,-kmod,-additions,-additions-nox11}: update to
6.1.46

Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v46
Also fixed PORTREVISION in master/slave ports.

PR:			272572
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D41110
MFH:			2023Q3

emulators/virtualbox-ose{,-legacy}: sort out options

Sort out options: order (portlint), convert to OPTION_*.
Add entry in "Troubleshooting" about "VERR_NO_MEMORY".
Force devel/llvm15 for emulators/virtualbox-ose-legacy on recent 14 with
llvm16 in base.

PR:			200764 252227
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D40751

emulators/virtualbox-ose: Remove unnecessary dependency on 32-bit compat for
amd64

32-bit in-kernel support and lib32 libs are not necessary for VirtualBox 6.x,
so just remove this requirement.
Also the port support amd64 only - remove I386 from PLIST_SUB.

PR:			266382
Tested by:		Olivier Certner <olivier.freebsd@free.fr>
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D40487

emulators/virtualbox-ose: added replace %%VBOX_ETC%% in files/pkg-message.in

Approved by:	arrowd (mentor)

emulators/virtualbox-ose: on 14 "Failed to construct device 'VMMDev' instance #0
(VERR_INTERNAL_ERROR_3)"

Force llvm from ports from 11 to 14 - by default it'll pick 14.
Use VBOX_LLVM_VER in make.conf to define different llvm.

PR:			270189
Reviewed by:		cy, grahamperrin
Tested by:		cy, grahamperrin, groenveld@acm.org, rkoberman@gmail.com
Approved by:		arrowd
Differential Revision:	https://reviews.freebsd.org/D40254

emulators/virtualbox-ose: error: use of undeclared identifier 'mempcpy'

1. There are no mempcpy on 12, on 13 before 1300513 and on 14 before 1400026.
Log with error is here:
https://lists.freebsd.org/archives/freebsd-pkg-fallout/2023-May/402233.html
2. 12 have llvm11 in base after 1203502 (llvm12 after 1203503 and llvm13
after 1203505), so not need to force build with llvm11 from ports.

Reported
by:		https://portsfallout.com/fallout?port=emulators%2Fvirtualbox-ose%24
Reviewed by:		rene
Approved by:		arrowd (mentor), fuz
Differential Revision:	https://reviews.freebsd.org/D40163

emulators/virtualbox-ose[-legacy]: rename option MANUAL to DOCS and make it
enabled by default

PR:			266992
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D40118

emulators/virtualbox-ose: Fix whitespace

Tab, not spaces.

emulators/virtualbox-ose[-legacy]: VM VirtualBox Manager: Help menu: unable to
open external browser

While here sort out LOCALBASE, PREFIX, VBOX_DIR, VBOX_ETC

PR:			266778
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D40119

emulators/virtualbox-ose{-*}: Update to 6.1.44

Changes:		https://www.virtualbox.org/wiki/Changelog-6.1#v44
Author:			lwhsu@FreeBSD.org
Note:			BROKEN on 14

PR:			266907
Reported by:		Ian Dickens <ian@south-border.com>
Approved by:		arrowd (mentor), joneum (ports-secteam)
Differential Revision:	https://reviews.freebsd.org/D40088

*: Bump PORTREVISIONs for math/mpc update to 1.3.1

emulators/virtualbox-ose: Fix build with LLVM 15

The previous commit (f4a869a6424a) was in complete.

emulators/virtualbox-ose-kmod: Fix build with LLVM 15

Starting with clang 15, the -Wint-conversion warning diagnostic for
implicit int <-> pointer conversions defaults to an error. Use a cast to
fix such an error here.

See also:      
https://lists.freebsd.org/archives/freebsd-emulation/2023-February/000431.html
               
https://lists.freebsd.org/archives/freebsd-emulation/2023-February/000460.html
PR:		269721
Reported by:	fbl@aoek.com, ohartmann@walstatt.org, rkoberman@gmail.com
Differential Revision: https://reviews.freebsd.org/D38906
Sponsored by:	The FreeBSD Foundation

multimedia/libvpx: update 1.13.0

Changes:	https://chromium.googlesource.com/webm/libvpx/+log/v1.12.0..v1.13.0
Reported by:	portscout

emulators/virtualbox-ose-additions*: Fix patch and build (for non-legacy)

PR:		268603
Fixes:		c35a71080172 emulators/virtualbox-ose: fix builds on CURRENT

emulators/virtualbox-ose: fix builds on CURRENT

SAVENAME was retired by D36542 https://reviews.freebsd.org/D36542

Bug 267079 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267079
involves failures to build four ports, for VirtualBox guest additions,
on FreeBSD-CURRENT:

    emulators/virtualbox-ose-additions
    emulators/virtualbox-ose-additions-legacy
    emulators/virtualbox-ose-additions-nox11
    emulators/virtualbox-ose-additions-nox11-legacy

Fix bug 267079 for CURRENT 1400068 and greater by hiding the use of
SAVENAME in patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c
for:

    emulators/virtualbox-ose
    emulators/virtualbox-ose-legacy

PR:                  : 267079
Author:              : mjg
Approved by:         : ports-committers (lwhsu), khng
Differential revision: https://reviews.freebsd.org/D37074

Mk/**tex.mk: Convert bsd.tex.mk to USES=tex

- Update all the consumers to use USES=tex
- USE_TEX=yes is the old way of writing USES=tex which has been removed
  and replaced in all ports
- Almost all of the USE_TEX features remains unchanged
- Some consumers had the same variables defined both in the mk
  infrastructure and also in the ports which have been removed from the
  ports as those are redundant.

In case any of the consumers are failing to build please make sure that
the nexessary USES=tex is there. Unlike previous USE_TEX=yes will no
longer load the required VARS for tex and related dependencies.

Reviewed by:	portmgr
Approved by:	portmgr (blanket)

Mk/Uses: always use colon for build/run suffix

Most USES use a colon for build/run(/test) suffixes. Change kde.mk,
qt.mk and pyqt.mk to do the same, and update all ports using that.

Document in CHANGES.

PR:			266034
Exp-run by:		antoine
Approved by:		tcberner (mentor)
Differential Revision:	https://reviews.freebsd.org/D36349

Remove WWW entries moved into port Makefiles

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

Add WWW entries to port Makefiles

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

emulators/virtualbox-ose-additions: Remove devclass from DRIVER_MODULE on recent
main.

Reviewed by:	madpilot
Differential Revision:	https://reviews.freebsd.org/D35954

emulators/virtualbox-ose: Update to 6.1.36

Changelog: https://www.virtualbox.org/wiki/Changelog

PR:		265351

emulators/virtualbox-ose: Add VBoxSharedClipboard.so to non X11 builds

This library is built when X11 is disabled too, since the functionality
can also be used by remote protocols.

PR:		261729
MFH:		2022Q3

*/*: Release my babies from my "created by" comments

emulators/virtualbox-ose: Fix build with new setuptools

emulators/virtualbox-ose-kmod*: Tie to a specific release branch.

Use a more restricted range of supported __FreeBSD_version values for
the virtualbox kernel module since it uses internal KPIs for which KBI
stability is not guaranteed.  DECLARE_MODULE_TIED would tie the module
to a specific __FreeBSD_version which would cause the module to stop
loading when an SA or EN is pushed on a release branch.  Instead, use
DECLARE_MODULE_MAXVER with an upper bound that is limited to the range
of a releng branch so that a module built on X.Y will load on X.Y with
SAs or ENs applied but will fail to load on X.Y-1 or X.Y+1.

Reviewed by:	kevans, imp, madpilot, lwhsu (earlier version)
Differential Revision:	https://reviews.freebsd.org/D16119

emulators/virtualbox-ose*: Update to 6.1.34

PR:		263439

textproc/libxml2: bump all LIB_DEPENDS consumers

This is a separate commit to facilitate easier cherry-picking for
quarterly.

PR: 262853, 262940, 262877, 263126
Approved by: fluffy (mentor)

textproc/libxml2: bump all dependencies

This should make sure that all dependent ports will pick
up the new version commited with a13ec21cd733f67a9fc0dc00ab45268bdc236246

emulators/virtualbox-ose-kmod: Fix kernel panic in DHCP bridge mode

PR:		262656
Approved by:	madpilot

emulators/virtualbox-ose: Put vbox/networks.conf in the right place

Since virtualbox-ose 6.1.26 a new networks.conf file has been
introduced and the software looks for it in /etc/vbox.

This commit introduces a patch to make virtualbox look for it in
PREFIX/etc/vbox.

To help users with configurations already using this file in /etc/vbox
notes to UPDATING, pkg-message and to the main virtualbox executable
script have been added.

Also adding some comments to the Makefile to note that QA warning
due to reinplace being run but not having changed any file are
expected due to the design of this port Makefile.

PR:		261522

emulators/virtualbox-ose(-legacy): Take advantage of ccache

This patch teaches the virtualbox ports to take advantage of ccache
if the ports are configured to use it.

PR:		254616

emulators/virtualbox-ose-additions(-legacy): Fix build on recent head

On recent head, after src commit 66c5fbca7719dc, the insmntque1(9)
function arguments changed.

Adapt virtualbox code, following what has been done in base with
other filesystems migrating to insmntque(9).

emulators/virtualbox-ose*: Update to 6.1.32

Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v32

*/*: Remove redundant '-[0-9]*' from CONFLICTS_INSTALL

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

emulators/virtualbox-ose: Update to 6.1.30

emulators/virtualbox-ose: Fix unintentional change

AAn unintentional change slipped in a previous commit. Revert that
part.

No change in the produced packages.

Fixes:		32c43c50524246

emulators/virtualbox-ose*: Fix mistake in patch

In the commit to update virtualbox-ose to 6.1.28 I made a one line
mistake when reapplying a patch which failed to apply as is.

In the patch
files/patch-src_VBox_HostDrivers_Support_freebsd_SUPDrv-freebsd.c
I did not replay a part removing the line:

rc = copyout(pHdr, pvUser, cbOut);

which was rewriting some data that it should not. The correct code
was anyway present after this leftover statement.

This error made virtualbox log a lot of warnings about Bad CPU
context like this:

vboxdrv: Bad CPU context error at line 373 in SUPDrv-freebsd.c:
ulCmd=0x2000568a: 0x282->0x287!

These seem to be unharmful, but anyway indicate a problem that this
commit fixes.

Reported by:		Kevin Oberman <rkoberman@gmail.com> (via mailing list)
Fixes:			a3db7da59f9498

emulators/virtualbox-ose: Update description and message files

- Add updated information about supported versions, installation
  commands and mitigation for a known issue.
- Removed reference to the wiki page.

Reviewed on github:

https://github.com/freebsd/freebsd-ports/pull/115

PR:             254412

emulators/virtualbox-ose*: Update to 6.1.28

Changelog: https://www.virtualbox.org/wiki/Changelog

emulators/virtualbox-ose-additons: Fix build on recent head

Fix build after head commit b4a58fbf640409a1 (vfs: remove cn_thread)

MFH:		2021Q4

INSTALLS_ICONS: retire the macro and rework the related dependencies

While here, make sure gtk-update-icon-cache is only on run dependency
where added as a dependency
Enforce gtk3 to depend on gtk-update-icon-cache (previously it was
inheriting the dependency)

multimedia/libvpx: update 1.11.0

Changes:	https://chromium.googlesource.com/webm/libvpx/+log/v1.10.0..v1.11.0
Reported by:	portscout, Repology

emulators/virtualbox-ose-additions: Assign default value to pointer

In the virtualbox virtual filesystem code we ship as a patch some
code in an else block is commented out. This produces a code path
in which a pointer variable is dereferenced in an unassigned state,
causing random crashes.

Lacking a better fix, give a default value of NULL to the pointer,
which at least avoids the random pointer dereference issue.

PR:		255386

emulators/virtualbox-ose(-legacy): Make VirtualBox limit AIO requests

Import patch to teach VirtualBox to check availability of AIO
resources before trying to allocate more.

This prevents crashes when using AIO in VirtualBox.

PR:		168298

emulators/virtualbox-ose: don't hardcode compiler version

PR:		257921

emulators/virtualbox-ose: Avoid overwriting slave ports OPTIONS_EXCLUDE

To disable the PULSEAUDIO option I used the OPTIONS_EXCLUDE variable
in commit 416b34d584e268.

Turns out this overwrites OPTIONS_EXCLUDE from slave ports. I'm
fixing this by only adding the PULSEAUDIO exclusion to the existing
EXCLUDE variable if defined.

NOTE: While it would be enough to bump PORTREVISION in the slave
port, I'm bumping PORTREVISION on master port to avoid adding
variables that are easily forgotten in future changes and could
cause even more breakage.

PR:		258256
Pointy Hat:	myself

emulators/virtualbox-ose: Update to 6.1.26

This new version has a regression in the pulseaudio host audio
driver. If enabled any VMs configured to use it fails to start.

Since no fix has been found the PULSEAUDIO option is forcibly
disabled. If you have any VM configured to use pulseaudio for audio
input/output, please reconfigure them to use a different driver.

Upstream ticket:	https://www.virtualbox.org/ticket/20484

Other changes:

- Remove old patches that don't apply, the audio system has been
  reworked upstream and the behavior of these patches is included in
  the new code
- Add upgrading pkg-message note about the PULSEAUDIO option issue
  described above

Reviewed by:		koobs
Differential Revision:	https://reviews.freebsd.org/D31264

emulators/virtualbox-ose: Add back missing extra patch file

Looks like this patch was removed in commit df5c241ed2d1

It is required to build with the DEBUG optioni (not default).

PR:		257777
Reported by:	Mario Felicioni <marietto2008@gmail.com>

graphics/mesa-libs: Bump reverse deps for libglvnd

Per discussion with bapt on helping pkg handle the changing of these
deps and avoiding impossible upgrade senarios.

PR:		246767
Reviewed by:	manu, bapt
Approved by:	x11
Differential Revision:	https://reviews.freebsd.org/D30824

emulators/virtualbox-ose-kmod: Fix hang at module loading time

After src commit e266a0f7f001 a module is not allowed to call
kern_kldload while being loaded. The virtualbox module is doing
exactly this though. virutalbox used to do this because the ng_ether
netgraph node did not provide version information in the past and
there was no way to properly depend on it.

ng_ether has gained versioning information in base r238844 more
than ten years ago, so we can now unconditionally properly depend
on it, since this revision is now included in all supported FreeBSD
versions.

Thanks to Tomoaki AOKI for identifying the base commuit exposing
the issue.
PR:			256505
Tested by:		Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
MFH:			2021Q2
Differential Revision:	https://reviews.freebsd.org/D30722

emulators/virtualbox-ose: Fix additions build on recent HEAD

Src HEAD commit 6d3e78ad6c11 vfs_quotactl function signature, adapt
virtualbox code to be able to compile there too.

MFH:		2021Q2

*: Three ports missed in the RESTRICTED removal.

emulators/virtualbox-ose: Update to 6.1.22

emulators/virtualbox-ose: Update to 6.1.20

- Also update related kmod and additions ports
- In additions, use INSTALL_LIB to install X11 modules, so binaries
  get stripped
- Trim some `#if __FreeBSD_version` checks for unsupported FreeBSD
  versions from patches

PR:		255301

emulators/virtualbox-ose-additions: Fix vboxvfs panic

Fix panic on mount when trying to use vbox VFS after
base r355790 (or git commit hash 6fa079fc3f5e).

PR:		255208
MFH:		2021Q2

emulators/virtualbox-ose: Fix build with ports provided SSL library on 11.x

Due to a compiler/linker command line ordering issue, VirtualBox 6
fails to compile on 11.x when a ports provided SSL library is
used.

Fix the order of -L options passed to the linker where the ssl
library is used.

Thanks to  Chad Jacob Milios <milios@ccsys.com> for suggesting the
correct fix.

PR:		254295
Submitted by:	russo@bogodyn.org
MFH:		2021Q2

all: Remove all other $FreeBSD keywords.

Remove # $FreeBSD$ from Makefiles.

Reimplement patch to disable Asyncronous IO in virtualbox-ose 6 as
an option, leaving AIO enabled by default, so no functional change
in default build.

Requested/Suggested by:	David G Lawrence <dg@dglawrence.com>

emulators/virtualbox-ose-kmod: Fix kernel panic on 13/14 with bridge mode by
adding EPOCH support

In r560502, I added a patch to support EPOCH to VirtualBox 5. When we upgraded
to VirtualBox 6, that patch was (unintentionally) removed, making it impossible
to use bridge move without this current patch.

Approved by:	jkim, madpilot
Differential Revision:	https://reviews.freebsd.org/D29319

Remove trailing spaaces from patch.

- Update VirtualBox OSE to 6.1.18
- Old VirtualBox OSE 5.2.44 preserved as "-legacy" versions of the
  ports (repocopied)
- Add back extra patch removed in r528258, actually required to
  build DEBUG kmod
- Correctly define WITH_DEBUG when enabling the DEBUG option, so
  binaries are not stripped

Please note that this new version supports only amd64 CPUs. If you need
to use older hardware please install the legacy ports.

Note that moving VM snapshots across major updates is unsupported, it's
strongly suggested to properly shutdown VMs before upgrading, please
check UPDATING for further details.

Fix VirtualBox build on recent head and 13 after src commit
0659df6faddf

PR:		252675
Submitted by:	O. Hartmann <ohartmann@walstatt.org>
		Mateusz Piotrowski <0mp@FreeBSD.org> (duplicate)
Reported by:	se (mailing lists), others
Approved by:	ports-secteam (fluffy)
MFH:		2020Q1

emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and
bridge mode.

Reviewed by:		kp, jkim (previous version)
Approved by:		kp, jkim (previous version), 0mp (mentor)
Differential Revision:	https://reviews.freebsd.org/D26359

Fix patch to virtualbox-ose-additions OpenGL ssupport to actually
work at runtime as much as possible.

The OpenGL bits in VirtualBox 5 are an old implementation that does
not play too well with what wee have in the tree now. Thesse patches
simply change the funzionn prototypess in VirtualBox to match the
ones from mesa so it caan compile and interface as much as possible
with it.

Thanks to Ronald Klop <ronald-lists@klop.ws> for testing.

PR:		250315
Submitted by:	rozhuk.im@gmail.com
Approved by:	portmgr (fixit blanket)

Fix emulators/virtualbox-ose build after r552109.

VirtualBox embeds an outdated version of glext.h, causing it to
fail to build due to symbols being redefined incorrectly.

Import patch which forces virtualbox to append it's own include
paths, thus not "obscuring" the system provided OpenGL include file.

PR:		250315
Submitted by:	rozhuk.im@gmail.com
Approved by:	portmgr (fixit blanket)

emulators/virtualbox-ose: Turn off aio usage and make VirtualBox use generic
Unix implementation.

This fixes instabilities on some loads involving disk IO.

PR:		168298, 221294
Approved by:	vbox (timeout)

emulators/virtualbox-ose-kmod: Fix a pair of VM bugs

- Use vm_pager_allocate() to allocate OBJT_PHYS objects.  This ensures
  that they're initialized properly.
- Don't assume that user wiring will succeed.

This had been a team effort, with multiple independent reports,
a wide variety of experiments, and patches written by kib@
and refined by markj@.

I'm bumping PORTREVISION and aligning the revision of both kmod and
application; it's possible the application bump isn't actually
needed but let's make sure they both get rebuilt with this
important (because of changed kernel assumptions) fix.

PR:		249326
Submitted by:	kib, markj
Reported by:	adridg, Rainer Hurling
Reviewed by:	adridg
Approved by:	koobs (vbox)
MFH:		2020Q3

Fix crash when accessing physical CD/DVD

PR:		248333
Reported by:	mfv@bway.net
Approved by:	koobs (vbox)
MFH:		2020Q3

Fix emulators/virtualbox-os-additions on head after vget(9) change.

Do not allow compiling C++ files for drivers with built-in functions.

This change lets us do "kldload vboxvfs.ko" (although it is still broken).

Remove unncessary memcpy(3) and fix file system ID handling.

I removed a bzero() call to reduce compiler warnings in the previous commit
(r544829).  It turned out the next memcpy() call was also wrong.  Just use
natural assignments here not to obfuscate the code.

Reported by:	Martin Simmons (martin at lispworks dot com) (some time ago)

Remove a superfluous bzero(3) call to reduce compiler warnings.

PR:	226073